From nobody@FreeBSD.org  Sun Oct  7 18:32:05 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5CF10106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  7 Oct 2012 18:32:05 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 3BE328FC1D
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  7 Oct 2012 18:32:05 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q97IW4Gs028716
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 7 Oct 2012 18:32:04 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id q97IW4VH028715;
	Sun, 7 Oct 2012 18:32:04 GMT
	(envelope-from nobody)
Message-Id: <201210071832.q97IW4VH028715@red.freebsd.org>
Date: Sun, 7 Oct 2012 18:32:04 GMT
From: Hon-Yu Lawrence Cheung <cheunghonyu@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] multimedia/ffmpegthumbnailer is missing gconf2 depend when GNOME OptionsNG has been selected
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: mbsd@isgroup.com.ua

>Number:         172459
>Category:       ports
>Synopsis:       [PATCH] multimedia/ffmpegthumbnailer is missing gconf2 depend when GNOME OptionsNG has been selected
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jhale
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 07 18:40:09 UTC 2012
>Closed-Date:    Fri Oct 12 09:22:25 UTC 2012
>Last-Modified:  Fri Oct 12 09:22:25 UTC 2012
>Originator:     Hon-Yu Lawrence Cheung
>Release:        FreeBSD 9.1-RC1
>Organization:
>Environment:
FreeBSD a5552.honyucheung.net 9.1-RC1 FreeBSD 9.1-RC1 #0 r240844: Sun Sep 23 11:27:52 HKT 2012     root@a5552.honyucheung.net:/usr/obj/usr/src/sys/ACER5552  amd64
>Description:
multimedia/ffmpegthumbnailer with options GNOME fails in install phrase result from missing depends of gconftool-2 from devel/gconf2.
>How-To-Repeat:
In a fresh system without devel/gconf2 installed, multimedia/ffmpegthumbnailer with options GNOME fails to build.

The following is error log
===============================================================================
===>  Installing for ffmpegthumbnailer-gnome-2.0.8_1
===>   ffmpegthumbnailer-gnome-2.0.8_1 depends on executable: pkgconf - found
===>   ffmpegthumbnailer-gnome-2.0.8_1 depends on shared library: png15 - found
===>   ffmpegthumbnailer-gnome-2.0.8_1 depends on shared library: swscale - found
===>   ffmpegthumbnailer-gnome-2.0.8_1 depends on shared library: jpeg.11 - found
===>   ffmpegthumbnailer-gnome-2.0.8_1 depends on shared library: glib-2.0.0 - found
===>   Generating temporary packing list
===>  Checking if multimedia/ffmpegthumbnailer already installed
Making install in man
gmake[1]: Entering directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/man'
gmake[2]: Entering directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/man'
gmake[2]: Nothing to be done for `install-exec-am'.
 .././install-sh -c -d '/usr/local/man/man1'
 install  -o root -g wheel -m 444 ffmpegthumbnailer.1 '/usr/local/man/man1'
gmake[2]: Leaving directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/man'
gmake[1]: Leaving directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/man'
gmake[1]: Entering directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8'
gmake[2]: Entering directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8'
 ./install-sh -c -d '/usr/local/lib'
 /bin/sh ./libtool   --mode=install /usr/bin/install -c -o root -g wheel   libffmpegthumbnailer.la '/usr/local/lib'
libtool: install: /usr/bin/install -c -o root -g wheel .libs/libffmpegthumbnailer.so.4 /usr/local/lib/libffmpegthumbnailer.so.4
libtool: install: (cd /usr/local/lib && { ln -s -f libffmpegthumbnailer.so.4 libffmpegthumbnailer.so || { rm -f libffmpegthumbnailer.so && ln -s libffmpegthumbnailer.so.4 libffmpegthumbnailer.so; }; })
libtool: install: (cd /usr/local/lib && { ln -s -f libffmpegthumbnailer.so.4 libffmpegthumbnailer.so || { rm -f libffmpegthumbnailer.so && ln -s libffmpegthumbnailer.so.4 libffmpegthumbnailer.so; }; })
libtool: install: /usr/bin/install -c -o root -g wheel .libs/libffmpegthumbnailer.lai /usr/local/lib/libffmpegthumbnailer.la
libtool: install: /usr/bin/install -c -o root -g wheel .libs/libffmpegthumbnailer.a /usr/local/lib/libffmpegthumbnailer.a
libtool: install: chmod 644 /usr/local/lib/libffmpegthumbnailer.a
libtool: install: ranlib /usr/local/lib/libffmpegthumbnailer.a
 ./install-sh -c -d '/usr/local/bin'
  /bin/sh ./libtool   --mode=install install  -s -o root -g wheel -m 555 ffmpegthumbnailer '/usr/local/bin'
libtool: install: install -o root -g wheel -m 555 -s .libs/ffmpegthumbnailer /usr/local/bin/ffmpegthumbnailer
 ./install-sh -c -d '/usr/local/include'
 ./install-sh -c -d '/usr/local/include/libffmpegthumbnailer'
 install  -o root -g wheel -m 444  libffmpegthumbnailer/videothumbnailer.h libffmpegthumbnailer/videothumbnailerc.h libffmpegthumbnailer/imagetypes.h libffmpegthumbnailer/ifilter.h libffmpegthumbnailer/videoframe.h libffmpegthumbnailer/filmstripfilter.h '/usr/local/include/libffmpegthumbnailer'
 ./install-sh -c -d '/usr/local/libdata/pkgconfig'
 install  -o root -g wheel -m 444 libffmpegthumbnailer.pc '/usr/local/libdata/pkgconfig'
gmake[2]: Leaving directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8'
gmake[1]: Leaving directory `/wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8'
cd /wrkdirs/usr/ports/multimedia/ffmpegthumbnailer/work/ffmpegthumbnailer-2.0.8/ && /usr/bin/env TMPDIR="/tmp" TMPDIR="/tmp" SHELL=/bin/sh NO_LINT=YES    PREFIX=/usr/local  LOCALBASE=/usr/local  MOTIFLIB="-L/usr/local/lib -lXm -lXp" LIBDIR="/usr/lib"  CC="cc" CFLAGS="-O2 -pipe -fno-strict-aliasing"  CPP="cpp" CPPFLAGS=" -I/usr/local/include"  LDFLAGS=" -pthread -L/usr/local/lib"  CXX="c++" CXXFLAGS="-O2 -pipe -fno-strict-aliasing"  MANPREFIX="/usr/local" BSD_INSTALL_PROGRAM="install  -s -o root -g wheel -m 555"  BSD_INSTALL_LIB="install  -s -o root -g wheel -m 444"  BSD_INSTALL_SCRIPT="install  -o root -g wheel -m 555"  BSD_INSTALL_DATA="install  -o root -g wheel -m 444"  BSD_INSTALL_MAN="install  -o root -g wheel -m 444" make install-pkgconfigDATA
 ./install-sh -c -d '/usr/local/libdata/pkgconfig'
 install  -o root -g wheel -m 444 libffmpegthumbnailer.pc '/usr/local/libdata/pkgconfig'
install  -o root -g wheel -m 444 /usr/ports/multimedia/ffmpegthumbnailer/files/ffmpegthumbnailer.schemas /usr/local/etc/gconf/schemas
gconftool-2: not found
env: gconftool-2: No such file or directory
*** [post-install] Error code 127

Stop in /usr/ports/multimedia/ffmpegthumbnailer.
>Fix:
add BUILD_DEPENDS+= gconftool-2:${PORTSDIR}/devel/gconf2 inside ${PORT_OPTIONS:MGNOME} section.


Patch attached with submission follows:

*** Makefile.original   Mon Oct  8 01:56:20 2012
--- Makefile    Mon Oct  8 02:21:10 2012
***************
*** 33,42 ****
--- 33,43 ----
  .include <bsd.port.pre.mk>
  
  .if ${PORT_OPTIONS:MGNOME}
  PKGNAMESUFFIX+=       -gnome
  GCONF_SCHEMAS=        ffmpegthumbnailer.schemas
+ BUILD_DEPENDS+=       gconftool-2:${PORTSDIR}/devel/gconf2
  .endif
  
  MAN1=         ffmpegthumbnailer.1
  
  post-install:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Oct 7 18:40:20 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172459 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: mbsd@isgroup.com.ua
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/172459: [PATCH] multimedia/ffmpegthumbnailer is missing gconf2 depend when GNOME OptionsNG has been selected
Date: Sun, 7 Oct 2012 18:40:18 UT

 Maintainer of multimedia/ffmpegthumbnailer,
 
 Please note that PR ports/172459 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172459
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: mbsd <mbsd@isgroup.com.ua>
To: bug-followup@FreeBSD.org, cheunghonyu@gmail.com
Cc:  
Subject: Re: ports/172459:
Date: Sun, 07 Oct 2012 22:15:18 +0300

 Yes I'm agree. That dependency has to be here.
 
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Sun Oct 7 19:36:16 UTC 2012 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172459 
Responsible-Changed-From-To: freebsd-ports-bugs->jhale 
Responsible-Changed-By: jhale 
Responsible-Changed-When: Mon Oct 8 00:20:24 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172459 

From: "Jason E. Hale" <jhale@freebsd.org>
To: bug-followup@freebsd.org, mbsd@isgroup.com.ua
Cc: cheunghonyu@gmail.com
Subject: Re: ports/172459: [PATCH] multimedia/ffmpegthumbnailer is missing gconf2 depend when GNOME OptionsNG has been selected
Date: Thu, 11 Oct 2012 04:55:01 -0700 (PDT)

 --nextPart2260499.uZ4jldtAj9
 Content-Transfer-Encoding: 7Bit
 Content-Type: text/plain; charset="us-ascii"
 
 There were a few other changes that I needed to make.  Could you review the 
 attached patch?
 
 - Trimmed Makefile header
 - Dropped ABI version numbers from LIB_DEPENDS to satisfy portlint(1)
 - USE_GNOME= pkgconfig -> USE_PKGCONFIG= build
 - Removed soon to be deprecated WANT_GNOME
 - Install GCONF_SCHEMAS in PREFIX instead of LOCALBASE
 --nextPart2260499.uZ4jldtAj9
 Content-Disposition: attachment; filename="ffmpegthumbnailer.diff"
 Content-Transfer-Encoding: 7Bit
 Content-Type: text/x-patch; charset="ISO-8859-1"; name="ffmpegthumbnailer.diff"
 
 Index: Makefile
 ===================================================================
 --- Makefile	(revision 305645)
 +++ Makefile	(working copy)
 @@ -1,7 +1,4 @@
 -# New ports collection makefile for:	ffmpegthumbnailer
 -# Date created:		Mo 18 Feb 2008 06:11:13 CET
 -# Whom:			Dierk Sacher <dierk@blaxxtarz.de>
 -#
 +# Created by: Dierk Sacher <dierk@blaxxtarz.de>
  # $FreeBSD$
  
  PORTNAME=	ffmpegthumbnailer
 @@ -15,36 +12,36 @@
  
  LIB_DEPENDS=	png15:${PORTSDIR}/graphics/png \
  		swscale:${PORTSDIR}/multimedia/ffmpeg \
 -		jpeg.11:${PORTSDIR}/graphics/jpeg
 +		jpeg:${PORTSDIR}/graphics/jpeg
  
  CPPFLAGS+=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include
  LDFLAGS+=	${PTHREAD_LIBS} -L${LOCALBASE}/lib
  CONFIGURE_ARGS=	--with-pkgconfigdir=${PREFIX}/libdata/pkgconfig --enable-gio
  
  GNU_CONFIGURE=	yes
 -USE_GMAKE=	yes
 -USE_GNOME=	gnomehack pkgconfig _glib20
 +USE_PKGCONFIG=	build
 +USE_GNOME=	gnomehack _glib20
  USE_LDCONFIG=	yes
  
 -WANT_GNOME=	yes
 -
  OPTIONS_DEFINE=	GNOME
  
 -.include <bsd.port.pre.mk>
 +MAN1=		ffmpegthumbnailer.1
  
 +.include <bsd.port.options.mk>
 +
  .if ${PORT_OPTIONS:MGNOME}
  PKGNAMESUFFIX+=	-gnome
 +USE_GNOME+=	gconf2
  GCONF_SCHEMAS=	ffmpegthumbnailer.schemas
  .endif
  
 -MAN1=		ffmpegthumbnailer.1
 -
  post-install:
  	cd ${WRKSRC}/ && ${SETENV} ${MAKE_ENV} ${MAKE} install-pkgconfigDATA
  .if ${PORT_OPTIONS:MGNOME}
 -	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${LOCALBASE}/etc/gconf/schemas
 +	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${PREFIX}/etc/gconf/schemas
  	@${SETENV} GCONF_CONFIG_SOURCE=`gconftool-2 --get-default-source` \
 -		gconftool-2 --makefile-install-rule ${LOCALBASE}/etc/gconf/schemas/${GCONF_SCHEMAS} \
 +		gconftool-2 --makefile-install-rule ${PREFIX}/etc/gconf/schemas/${GCONF_SCHEMAS} \
  		> /dev/null
  .endif
 -.include <bsd.port.post.mk>
 +
 +.include <bsd.port.mk>
 
 Property changes on: Makefile
 ___________________________________________________________________
 Added: svn:mime-type
 ## -0,0 +1 ##
 +text/plain
 \ No newline at end of property
 Added: svn:eol-style
 ## -0,0 +1 ##
 +native
 \ No newline at end of property
 
 --nextPart2260499.uZ4jldtAj9--
 

From: paranormal <paranormal@isgroup.com.ua>
To: bug-followup <bug-followup@FreeBSD.org>
Cc:  
Subject: Re: ports/172459: [PATCH] multimedia/ffmpegthumbnailer is missing
 gconf2 depend when GNOME OptionsNG has been selected
Date: Fri, 12 Oct 2012 02:03:04 +0300

 --=-xdIULZbpVV+NghpZ52Ex
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable
 
 I've tested it, and it looks nice and works like before ;).
 I've done all dirty job, thank you very much.
 
 Is it normal to install gnome schemas like this:
 gconftool-2 --makefile-install-rule in post-install: ?
 
 I didn't see anything like this in any other port.
 It was my improvisation.
 
 So, if it is normal, please commit it.
 
 --=-xdIULZbpVV+NghpZ52Ex
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (FreeBSD)
 
 iQIcBAABAgAGBQJQd1AoAAoJEOKdyUSm7MVLjJQP/RQJjytHjZt7LB4jJn3Dtz7a
 SbWy3AMr2mmVW0n3JcUwL9x7kfGEgEb9EqZVd/LLdogaB1B7R58flNT7kYY9/qe+
 kywHfPpnIL2AhFhBacVwruvK4P0mLsMA2bTivvbVN23C0Auo4wSBYS1pmyJj+lhA
 2+CRgrVrl1oX+44KBRhYzLD8hvazYNkSdciybfQa3gausV7/DhN+X1RrfFziOjjO
 vVSg6Nz8qjBZB1aOVqhlTcPELLyTAdXczxJ2vBfHhQJNkxDTbFp+YrSsn2HSnVTX
 V5Wj9rdH8ZsU4S43iLAWejoZtqAztroQecfLPy3EuC+ev8YS4lHKJ5C7FK0v/zwz
 05c9+UNptHD4EjXR+M3PjICPGQHd/aD07L9IERft/UKP0bdg9Lk8qcuZyP6XfidB
 ouGNathROrsCzfO5Dzm0xs00WlBWwOM8nzSlydcNggaHE6A3PRIS1CbxA5AeYj9N
 D7A0U5cD/rnpex1E1F5QWwlmLEHnjmYaJcS7qZlaZ9tnnOdkCaGfZgV0/ArXtLRS
 6Gcf39ZSXjEwqzHRRB+tkHtYnAnIqWG4aie4Jb0G8YbW8RIufzXC5MfBZ7B9i6r1
 xOBRt6QbSuchNfEmQJrIWZCq2QJ4yEzg1IKzLt35A6Sy3cpaWSMebY5/KLylzqJ9
 dlcEAZJxYZhmVa04UioQ
 =wZAe
 -----END PGP SIGNATURE-----
 
 --=-xdIULZbpVV+NghpZ52Ex--
 

From: "Jason E. Hale" <jhale@freebsd.org>
To: paranormal <paranormal@isgroup.com.ua>, bug-followup@freebsd.org
Cc:  
Subject: Re: ports/172459: [PATCH] multimedia/ffmpegthumbnailer is missing gconf2 depend when GNOME OptionsNG has been selected
Date: Fri, 12 Oct 2012 03:08:01 -0400

 On Friday, October 12, 2012 00:54:21 paranormal wrote:
 > 
 >  Is it normal to install gnome schemas like this:
 >  gconftool-2 --makefile-install-rule in post-install: ?
 > 
 >  I didn't see anything like this in any other port.
 >  It was my improvisation.
 > 
 >  So, if it is normal, please commit it.
 > 
 
 I looked at how bsd.gnome.mk handles gconf schemas 
 and I think this is the way to go:
 
 .if ${PORT_OPTIONS:MGNOME}
 	${MKDIR} ${PREFIX}/etc/gconf/schemas
 	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${PREFIX}/etc/gconf/schemas
 	@${SETENV} GCONF_CONFIG_SOURCE=xml:${GCONF_CONFIG_OPTIONS}:${PREFIX}/${GCONF_CONFIG_DIRECTORY} \
 		gconftool-2 --makefile-install-rule ${PREFIX}/etc/gconf/schemas/${GCONF_SCHEMAS} \
 		> /dev/null || ${TRUE}
 .endif
 
 I'm more of a KDE guy, but this code seems to work fine on tinderbox. The problem
 with `gconftool-2 --get-default-source` is that it provides LOCALBASE instead
 of PREFIX.
 
 https://redports.org/buildarchive/20121012041037-24617/
 
 - Jason

From: mbsd <mbsd@isgroup.com.ua>
To: bug-followup@FreeBSD.org, cheunghonyu@gmail.com
Cc:  
Subject: Re: ports/172459: [PATCH] multimedia/ffmpegthumbnailer is missing
 gconf2 depend when GNOME OptionsNG has been selected
Date: Fri, 12 Oct 2012 10:53:21 +0300

 I'm disagree. I'd like to see string:
 install blablabla ffmpegthumbnailer.schemas
 in installing output. That was the reason why I had been
 deleting /dev/null || ${TRUE}
 
 But if your insist: no problem.
 

From: mbsd <mbsd@isgroup.com.ua>
To: bug-followup@FreeBSD.org, cheunghonyu@gmail.com
Cc:  
Subject: Re: ports/172459: [PATCH] multimedia/ffmpegthumbnailer is missing
 gconf2 depend when GNOME OptionsNG has been selected
Date: Fri, 12 Oct 2012 11:43:08 +0300

 oups, sorry. I was scared by red colour of string I thought it something
 new.
 > /dev/null || ${TRUE}
 
 please commit your patch.
 
State-Changed-From-To: open->closed 
State-Changed-By: jhale 
State-Changed-When: Fri Oct 12 09:22:24 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172459 
>Unformatted:
