From pi@zfs.opsec.eu  Sun Oct  7 13:41:38 2012
Return-Path: <pi@zfs.opsec.eu>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A24C51065670
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  7 Oct 2012 13:41:38 +0000 (UTC)
	(envelope-from pi@zfs.opsec.eu)
Received: from zfs.opsec.eu (zfs.opsec.eu [IPv6:2001:14f8:200:4::18])
	by mx1.freebsd.org (Postfix) with ESMTP id 5F12A8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  7 Oct 2012 13:41:38 +0000 (UTC)
Received: from pi by zfs.opsec.eu with local (Exim 4.80 (FreeBSD))
	(envelope-from <pi@zfs.opsec.eu>)
	id 1TKr6t-0000oS-0C
	for FreeBSD-gnats-submit@freebsd.org; Sun, 07 Oct 2012 15:41:35 +0200
Message-Id: <E1TKr6t-0000oS-0C@zfs.opsec.eu>
Date: Sun, 07 Oct 2012 15:41:35 +0200
From: Kurt Jaeger <fbsd-ports@opsec.eu>
Reply-To: Kurt Jaeger <fbsd-ports@opsec.eu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch update] sysutils/ntfsprogs Makefile GNOME issue
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         172453
>Category:       ports
>Synopsis:       [patch update] sysutils/ntfsprogs Makefile GNOME issue
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bdrewery
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 07 13:50:13 UTC 2012
>Closed-Date:    Mon Oct 08 11:42:13 CDT 2012
>Last-Modified:  Mon Oct  8 16:50:05 UTC 2012
>Originator:     Kurt Jaeger
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
-
>Environment:
System: FreeBSD zfs.opsec.eu 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64


>Description:
	make fails due to missing GNOME flag

	If one does not compile with the gnome options, one does not need
	the WANT_GNOME=yes, but I'm not sure how to conditionally integrate
	the WANT_GNOME-flag before bsd.port.pre.mk.

>How-To-Repeat:

# cd /usr/ports/sysutils/ntfsprogs/
# make
"/usr/ports/Mk/bsd.gnome.mk", line 657: The Pre include part of bsd.gnome.mk part is not included. Did you forget WANT_GNOME=yes before bsd.port.pre.mk?

>Fix:

--- sysutils/ntfsprogs/Makefile	2012-10-07 00:00:55.661792113 +0200
+++ /usr/home/pi/myp/sysutils/ntfsprogs/Makefile	2012-10-07 15:38:13.032576157 +0200
@@ -38,6 +38,8 @@
 
 SUB_FILES=	pkg-message
 
+WANT_GNOME=	yes
+
 .include <bsd.port.pre.mk>
 
 .if ${ARCH} == "i386"


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->bdrewery 
Responsible-Changed-By: bdrewery 
Responsible-Changed-When: Mon Oct 8 11:35:02 CDT 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172453 
State-Changed-From-To: open->closed 
State-Changed-By: bdrewery 
State-Changed-When: Mon Oct 8 11:42:12 CDT 2012 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172453 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/172453: commit references a PR
Date: Mon,  8 Oct 2012 16:42:18 +0000 (UTC)

 Author: bdrewery
 Date: Mon Oct  8 16:42:09 2012
 New Revision: 305546
 URL: http://svn.freebsd.org/changeset/ports/305546
 
 Log:
   - Fix build when selecting GNOMEVFS2 option
   
   PR:		ports/172453
   Submitted by:	Kurt Jaeger <fbsd-ports@opsec.eu> (based on)
 
 Modified:
   head/sysutils/ntfsprogs/Makefile
 
 Modified: head/sysutils/ntfsprogs/Makefile
 ==============================================================================
 --- head/sysutils/ntfsprogs/Makefile	Mon Oct  8 16:22:29 2012	(r305545)
 +++ head/sysutils/ntfsprogs/Makefile	Mon Oct  8 16:42:09 2012	(r305546)
 @@ -38,6 +38,12 @@ MLINKS=	ntfsmount.8 mount_ntfs-fuse.8
  
  SUB_FILES=	pkg-message
  
 +.include <bsd.port.options.mk>
 +
 +.if ${PORT_OPTIONS:MGNOMEVFS2}
 +WANT_GNOME=	yes
 +.endif
 +
  .include <bsd.port.pre.mk>
  
  .if ${ARCH} == "i386"
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
