From nemysis@gmx.ch  Sat Oct  6 19:52:05 2012
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 45CBD1065670
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  6 Oct 2012 19:52:05 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.22])
	by mx1.freebsd.org (Postfix) with SMTP id 72F448FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  6 Oct 2012 19:52:03 +0000 (UTC)
Received: (qmail invoked by alias); 06 Oct 2012 19:52:02 -0000
Received: from 201-230.4-85.cust.bluewin.ch (EHLO something.email.com) [85.4.230.201]
  by mail.gmx.net (mp010) with SMTP; 06 Oct 2012 21:52:02 +0200
Received: by something.email.com (sSMTP sendmail emulation); Sat, 06 Oct 2012 21:52:02 +0200
Message-Id: <20121006195205.45CBD1065670@hub.freebsd.org>
Date: Sat, 06 Oct 2012 21:52:02 +0200
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc: dinoex@FreeBSD.org
Subject: [PATCH] graphics/netpbm: Not clean reinstall, OptionsNG
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         172411
>Category:       ports
>Synopsis:       [PATCH] graphics/netpbm: Not clean reinstall, OptionsNG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 06 20:00:22 UTC 2012
>Closed-Date:    Fri Feb 15 17:09:59 CET 2013
>Last-Modified:  Fri Feb 15 17:09:59 CET 2013
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:

- OptionsNG

+.include <bsd.port.options.mk>

+.if ${PORT_OPTIONS:MX11}

+.if ${PORT_OPTIONS:MDOCS}


- Not clean reinstall

make reinstall
...
    SRCDIR=/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86 BUILDDIR=/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86 install.bin 
    gmake[4]: Entering directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter/other/fiasco/lib'
    gmake[4]: Nothing to be done for `install.bin'.
    gmake[4]: Leaving directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter/other/fiasco/lib'
    gmake[3]: Leaving directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter/other/fiasco'
    cd /usr/local/bin ; \
    ln -s pnmtoplainpnm pnmnoraw
    ln: pnmnoraw: File exists
    gmake[2]: *** [install.bin.local] Error 1
    gmake[2]: Leaving directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter/other'
    gmake[1]: *** [other/install.bin] Error 2
    gmake[1]: Leaving directory `/var/tmp/ports/usr/ports/graphics/netpbm/work/netpbm-10.35.86/converter'
    gmake: *** [converter/install.bin] Error 2
    *** Error code 2

    Stop in /usr/ports/graphics/netpbm.
    *** Error code 1

    Stop in /usr/ports/graphics/netpbm.


Only this helps for a clean reinstall

cd /usr/local/bin ; rm -f pnmnoraw gemtopbm ppmtojpeg bmptoppm ppmtouil pnmtopnm pnmtofits pnmtotiff pgmslice pnmfile


After this command is clean make reinstall.

===>   Compressing manual pages for netpbm-10.35.86
===>   Running ldconfig
/sbin/ldconfig -m /usr/local/lib
===>   Registering installation for netpbm-10.35.86

Port maintainer (dinoex@FreeBSD.org) is cc'd.

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .4 in tiff.4 unless it is really necessary.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .11 in jpeg.11 unless it is really necessary.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .1 in jbig.1 unless it is really necessary.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .4 in jasper.4 unless it is really necessary.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .5 in xml2.5 unless it is really necessary.
0 fatal errors and 6 warnings found.


port test: clean


>Fix:

--- netpbm-10.35.86.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/graphics/netpbm/Makefile ./Makefile
--- /usr/ports/graphics/netpbm/Makefile	2012-08-04 07:44:18.000000000 +0200
+++ ./Makefile	2012-10-06 21:26:54.000000000 +0200
@@ -12,7 +12,7 @@
 EXTRACT_SUFX=	.tgz
 
 MAINTAINER=	dinoex@FreeBSD.org
-COMMENT=	A toolkit for conversion of images between different formats
+COMMENT=	Toolkit for conversion of images between different formats
 
 LIB_DEPENDS=	tiff.4:${PORTSDIR}/graphics/tiff \
 		jpeg.11:${PORTSDIR}/graphics/jpeg \
@@ -35,7 +35,9 @@
 
 MAN1=		netpbm.1
 
-.if defined(WITH_X11)
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MX11}
 USE_XORG=	x11
 MAKE_ENV+=	WITH_X11="${WITH_X11}"
 PLIST_SUB+=	X11=''
@@ -71,8 +73,8 @@
 	@${REINPLACE_CMD} -e 's|doc/USERDOC|${DOCSDIR}/USERDOC|g' \
 		${WRKSRC}/doc/netpbm.1
 	${INSTALL_MAN} ${WRKSRC}/doc/netpbm.1 ${MANPREFIX}/man/man1
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/doc/USERDOC ${DOCSDIR}/
 .endif
 
--- netpbm-10.35.86.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Oct 6 20:00:34 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172411 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/172411: commit references a PR
Date: Fri, 15 Feb 2013 14:44:13 +0000 (UTC)

 Author: dinoex
 Date: Fri Feb 15 14:44:06 2013
 New Revision: 312291
 URL: http://svnweb.freebsd.org/changeset/ports/312291
 
 Log:
   - cleanup options
   PR:		172411
   Submitted by:	nemysis
 
 Modified:
   head/graphics/netpbm/Makefile
 
 Modified: head/graphics/netpbm/Makefile
 ==============================================================================
 --- head/graphics/netpbm/Makefile	Fri Feb 15 14:21:45 2013	(r312290)
 +++ head/graphics/netpbm/Makefile	Fri Feb 15 14:44:06 2013	(r312291)
 @@ -31,7 +31,9 @@ USE_LDCONFIG=	yes
  
  MAN1=		netpbm.1
  
 -.if defined(WITH_X11)
 +.include <bsd.port.options.mk>
 +
 +.if ${PORT_OPTIONS:MX11}
  USE_XORG=	x11
  MAKE_ENV+=	WITH_X11="${WITH_X11}"
  PLIST_SUB+=	X11=''
 @@ -67,8 +69,8 @@ post-install:
  	@${REINPLACE_CMD} -e 's|doc/USERDOC|${DOCSDIR}/USERDOC|g' \
  		${WRKSRC}/doc/netpbm.1
  	${INSTALL_MAN} ${WRKSRC}/doc/netpbm.1 ${MANPREFIX}/man/man1
 -.if !defined(NOPORTDOCS)
 -	@${MKDIR} ${DOCSDIR}
 +.if ${PORT_OPTIONS:MDOCS}
 +	${MKDIR} ${DOCSDIR}
  	${INSTALL_DATA} ${WRKSRC}/doc/USERDOC ${DOCSDIR}/
  .endif
  
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Fri Feb 15 17:09:43 CET 2013 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172411 
>Unformatted:
