From nobody@FreeBSD.org  Wed Sep 26 14:03:09 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 24F94106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Sep 2012 14:03:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 1004C8FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Sep 2012 14:03:09 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q8QE38TK054697
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Sep 2012 14:03:08 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id q8QE38Ij054686;
	Wed, 26 Sep 2012 14:03:08 GMT
	(envelope-from nobody)
Message-Id: <201209261403.q8QE38Ij054686@red.freebsd.org>
Date: Wed, 26 Sep 2012 14:03:08 GMT
From: HU Dong <itechbear@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: chinese/fcitx fixes a startup warning
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: lichray@gmail.com

>Number:         172093
>Category:       ports
>Synopsis:       chinese/fcitx fixes a startup warning
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 26 14:10:02 UTC 2012
>Closed-Date:    Mon Oct 15 19:14:40 UTC 2012
>Last-Modified:  Mon Oct 15 19:14:52 UTC 2012
>Originator:     HU Dong
>Release:        9.0 release i386
>Organization:
None
>Environment:
FreeBSD hostname 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:15:25 UTC 2012     root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
fcitx would report 2 warnings when started due to misconfigured file path in xkb.c.

***
I/O warning: failed to load external entity "/usr/share/X11/xkb/rules/base.xml"
I/O warning: failed to load external entity "/usr/share/X11/xkb/rules/base.extras.xml"
>How-To-Repeat:
kill all fcitx process, then execute fcitx from any terminal emulator.
>Fix:
see the attatched patch

Patch attached with submission follows:

diff -ruN fcitx.bak/files/patch-src__module__xkb__xkb.c fcitx/files/patch-src__module__xkb__xkb.c
--- fcitx.bak/files/patch-src__module__xkb__xkb.c	1970-01-01 08:00:00.000000000 +0800
+++ fcitx/files/patch-src__module__xkb__xkb.c	2012-09-26 21:51:22.000000000 +0800
@@ -0,0 +1,20 @@
+--- ./src/module/xkb/xkb.c.orig	2012-09-26 21:43:54.000000000 +0800
++++ ./src/module/xkb/xkb.c	2012-09-26 21:47:31.000000000 +0800
+@@ -45,7 +45,7 @@
+ #include "rules.h"
+ 
+ #ifndef XKB_RULES_XML_FILE
+-#define XKB_RULES_XML_FILE "/usr/share/X11/xkb/rules/evdev.xml"
++#define XKB_RULES_XML_FILE "/usr/local/share/X11/xkb/rules/evdev.xml"
+ #endif
+ 
+ #define GROUP_CHANGE_MASK \
+@@ -205,7 +205,7 @@
+             }
+ 
+             if( xkbParentDir == NULL || strlen(xkbParentDir) == 0 ) {
+-                xkbParentDir = strdup("/usr/share/X11");
++                xkbParentDir = strdup("/usr/local/share/X11");
+             }
+ 
+             asprintf(&rulesFile, "%s/xkb/rules/%s.xml", xkbParentDir, rulesName);


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Sep 26 14:10:13 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172093 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: lichray@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/172093: chinese/fcitx fixes a startup warning
Date: Wed, 26 Sep 2012 14:10:10 UT

 Maintainer of chinese/fcitx,
 
 Please note that PR ports/172093 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172093
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Zhihao Yuan <lichray@gmail.com>
To: bug-followup@FreeBSD.org, itechbear@gmail.com
Cc:  
Subject: Re: ports/172093: chinese/fcitx fixes a startup warning
Date: Wed, 26 Sep 2012 16:09:40 -0500

 Hi,
 
 I don't know how to produce this problem but the patch is correct.
 Please commit it.
 
 And, committer, could you do me a favor? There is a tiny problem in
 the pkg-plist -- the entry "qtim" should be "libqtim". Please change
 it at the same time. Thanks.
 
 -- 
 Zhihao Yuan, nickname lichray
 The best way to predict the future is to invent it.
 ___________________________________________________
 4BSD -- http://4bsd.biz/

From: Zhihao Yuan <lichray@gmail.com>
To: bug-followup@FreeBSD.org, itechbear@gmail.com
Cc:  
Subject: Re: ports/172093: chinese/fcitx fixes a startup warning
Date: Sun, 30 Sep 2012 17:14:37 -0500

 Wait a sec. Could you please do a `make configure` under chinese/fcitx
 again? I want to make sure whether you see a warning, saying "Warning:
 Could not determine X binary directory. Assuming /usr/bin." If so,
 another patch should be preferred:
 https://github.com/fcitx/fcitx/commit/e87eaf11f116d9d09c52996deecf2096767419c1
 
 -- 
 Zhihao Yuan, nickname lichray
 The best way to predict the future is to invent it.
 ___________________________________________________
 4BSD -- http://4bsd.biz/
State-Changed-From-To: feedback->closed 
State-Changed-By: delphij 
State-Changed-When: Mon Oct 15 19:14:15 UTC 2012 
State-Changed-Why:  
Fixed with maintainer submitted patch, thanks for your 
submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172093 
Responsible-Changed-From-To: freebsd-ports-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Mon Oct 15 19:14:42 UTC 2012 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172093 
>Unformatted:
