From ohauer@FreeBSD.org  Tue Sep 25 19:49:52 2012
Return-Path: <ohauer@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CA81E106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Sep 2012 19:49:52 +0000 (UTC)
	(envelope-from ohauer@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B68478FC0A;
	Tue, 25 Sep 2012 19:49:52 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8PJnq7X018290;
	Tue, 25 Sep 2012 19:49:52 GMT
	(envelope-from ohauer@freefall.freebsd.org)
Received: (from ohauer@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8PJnqpY018288;
	Tue, 25 Sep 2012 19:49:52 GMT
	(envelope-from ohauer)
Message-Id: <201209251949.q8PJnqpY018288@freefall.freebsd.org>
Date: Tue, 25 Sep 2012 19:49:52 GMT
From: Olli Hauer <ohauer@freebsd.org>
Reply-To:
To: FreeBSD-gnats-submit@freebsd.org
Cc: <r.neese@gmail.com>
Subject: [patch] www/fusionpbx remove dead code from Makefile
X-Send-Pr-Version: 3.113
X-GNATS-Notify: r.neese@gmail.com

>Number:         172074
>Category:       ports
>Synopsis:       [patch] www/fusionpbx remove dead code from Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 25 19:50:05 UTC 2012
>Closed-Date:    Mon Oct 01 18:42:02 UTC 2012
>Last-Modified:  Sat Oct 06 18:45:12 UTC 2012
>Originator:     ohauer
>Release:        
>Organization:
>Environment:

>Description:
remove dead code from Makefile, PLIST_SUB
variables are not used in pkg-plist

>How-To-Repeat:
$> grep ^% pkg-plist | grep -v ^%%WWWDIR

>Fix:

--- fusionpbx.diff begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 304799)
+++ Makefile	(working copy)
@@ -37,14 +37,6 @@
 
 .include <bsd.port.options.mk>
 
-.for opt in ${ALL_OPTIONS}
-.if ${PORT_OPTIONS:M${opt}}
-PLIST_SUB+=	${opt}=""
-.else
-PLIST_SUB+=	${opt}="@comment "
-.endif
-.endfor
-
 .if ${PORT_OPTIONS:MPDOPGSQL}
 USE_PGSQL=	yes
 USE_PHP+=	pgsql pdo_pgsql
--- fusionpbx.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Sep 25 19:50:17 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172074 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: r.neese@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/172074: [patch] www/fusionpbx remove dead code from Makefile
Date: Tue, 25 Sep 2012 19:50:14 UT

 Maintainer of www/fusionpbx,
 
 Please note that PR ports/172074 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172074
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

Date: Wed, 26 Sep 2012 00:21:13 -0400
From: Richard E Neese <r.neese@gmail.com>
To: Olli Hauer <ohauer@freebsd.org>
Subject: Re: [patch] www/fusionpbx remove dead code from Makefile

 commit

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/172074: commit references a PR
Date: Wed, 26 Sep 2012 04:39:41 +0000 (UTC)

 Author: ohauer
 Date: Wed Sep 26 04:39:30 2012
 New Revision: 304874
 URL: http://svn.freebsd.org/changeset/ports/304874
 
 Log:
   - remove dead code from Makefile
   
   PR:		ports/172074
   Submitted by:	ohauer
   Approved by:	Richard E Neese <r.neese@gmail.com> (maintainer)
 
 Modified:
   head/www/fusionpbx/Makefile
 
 Modified: head/www/fusionpbx/Makefile
 ==============================================================================
 --- head/www/fusionpbx/Makefile	Wed Sep 26 03:18:26 2012	(r304873)
 +++ head/www/fusionpbx/Makefile	Wed Sep 26 04:39:30 2012	(r304874)
 @@ -37,14 +37,6 @@ PDOMYSQL_DESC=	Install MySQL PDO Connect
  
  .include <bsd.port.options.mk>
  
 -.for opt in ${ALL_OPTIONS}
 -.if ${PORT_OPTIONS:M${opt}}
 -PLIST_SUB+=	${opt}=""
 -.else
 -PLIST_SUB+=	${opt}="@comment "
 -.endif
 -.endfor
 -
  .if ${PORT_OPTIONS:MPDOPGSQL}
  USE_PGSQL=	yes
  USE_PHP+=	pgsql pdo_pgsql
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: rm 
State-Changed-When: Mon Oct 1 18:42:01 UTC 2012 
State-Changed-Why:  
Committed. Closing. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172074 
>Unformatted:
