From nobody@FreeBSD.org  Fri Sep 21 03:24:42 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6C09D1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 21 Sep 2012 03:24:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 4D0708FC24
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 21 Sep 2012 03:24:42 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q8L3OgHQ014944
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 21 Sep 2012 03:24:42 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id q8L3OgxN014943;
	Fri, 21 Sep 2012 03:24:42 GMT
	(envelope-from nobody)
Message-Id: <201209210324.q8L3OgxN014943@red.freebsd.org>
Date: Fri, 21 Sep 2012 03:24:42 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [pkgng] ports-mgmt/pkg: `make clean all deinstall install' always fails
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         171831
>Category:       ports
>Synopsis:       [pkgng] ports-mgmt/pkg: `make clean all deinstall install' always fails
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 21 03:30:19 UTC 2012
>Closed-Date:    Sat Mar 09 16:54:11 CST 2013
>Last-Modified:  Sat Mar  9 23:00:02 UTC 2013
>Originator:     Garrett Cooper
>Release:        9.1-PRERELEASE
>Organization:
EMC Isilon
>Environment:
FreeBSD forza.west.isilon.com 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 r240770: Thu Sep 20 19:28:45 PDT 2012     gcooper@forza.west.isilon.com:/usr/obj/usr/src/sys/FORZA  amd64
>Description:
I commonly do `make all deinstall install`, and this fails (for obvious reasons) because pkgng is deleting itself:

..

sted-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../pkg//version.c
cc -O2 -pipe -O2 -fno-strict-aliasing -O2 -fno-strict-aliasing  -I/scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../libpkg -g -O0 -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../pkg//which.c
cc -O2 -pipe -O2 -fno-strict-aliasing -O2 -fno-strict-aliasing  -I/scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../libpkg -g -O0 -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../pkg//fetch.c
cc -O2 -pipe -O2 -fno-strict-aliasing -O2 -fno-strict-aliasing  -I/scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../libpkg -g -O0 -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../pkg//shell.c
cc -O2 -pipe -O2 -fno-strict-aliasing -O2 -fno-strict-aliasing  -I/scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../libpkg -g -O0 -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../pkg//stats.c
cc -O2 -pipe -O2 -fno-strict-aliasing -O2 -fno-strict-aliasing  -I/scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../libpkg -g -O0 -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign  -static -o pkg-static add.o audit.o autoremove.o backup.o check.o clean.o create.o delete.o event.o info.o install.o main.o progressmeter.o query.o register.o repo.o rquery.o update.o upgrade.o search.o set.o shlib.o updating.o utils.o version.o which.o fetch.o shell.o stats.o -L/scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../libpkg  -lpkg  -lutil  -ljail  -lpthread  -L/scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../external/sqlite  -L/scratch/freebsd/ports/por
 ts-mgmt/pkg/work/pkg-1.0/pkg-static/../external/libyaml  -lsqlite3  -lyaml  -larchive  -lsbuf  -lfetch  -lpthread  -lelf  -lssl  -lcrypto  -lmd  -lz  -lbz2  -llzma -ledit  -lncursesw
/scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/pkg-static/../libpkg/libpkg.a(update.o): In function `pkg_update':
/scratch/freebsd/ports/ports-mgmt/pkg/work/pkg-1.0/libpkg/update.c:97: warning: warning: mktemp() possibly used unsafely; consider using mkstemp()
===>  Deinstalling for ports-mgmt/pkg
===>   Deinstalling pkg-1.0
The following packages will be deinstalled:

        pkg-1.0

The deinstallation will free 6 MB
Deleting pkg-1.0... done
===>  Installing for pkg-1.0
===>   Generating temporary packing list
===>  Checking if ports-mgmt/pkg already installed
/usr/local/sbin/pkg: not found
*** [check-already-installed] Error code 127

Stop in /scratch/freebsd/ports/ports-mgmt/pkg.

I'm can think of some ways that this could be resolved (hardlinks, copying, etc), but I'm not sure if they're the most safe/secure means to do it.
>How-To-Repeat:
cd /usr/ports/ports-mgmt/pkg make clean all deinstall install
>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Sep 21 03:30:36 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171831 

From: Bryan Drewery <bdrewery@FreeBSD.org>
To: bug-followup@FreeBSD.org, yaneurabeya@gmail.com,
        Baptiste Daroussin <bapt@freebsd.org>
Cc:  
Subject: Re: ports/171831: [pkgng] ports-mgmt/pkg: `make clean all deinstall
 install&#39; always fails
Date: Sat, 09 Mar 2013 16:44:37 -0600

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 ------enig2LOEFAKILKJMOWMESQDTA
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 This fixes it for me:
 
 http://people.freebsd.org/~bdrewery/fix-deinstall-install.txt
 
 Regards,
 Bryan
 
 
 ------enig2LOEFAKILKJMOWMESQDTA
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (MingW32)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
 
 iQIcBAEBAgAGBQJRO7tVAAoJEG54KsA8mwz5JvYP/ivFfgD21nJU5uh+h8M1XKMd
 a81SowtJRxUHjserph1MfkHgtVkGRLDKrkQ0ct6FO+7T2V4squXibb9loE+KLyYv
 3ixvvTo1ohDVlK3OGSV8zZci1lh03T7e6U35JBHvq3+QuYW1HTIOPYvTDC8hLTPs
 M2GYM0cq+H1yqJit5xCftfrKViDuy7z6WGdefOKmRRFR10PhYMBa2veAgQDAQYlt
 ascawezCtr31+fQdZNfm9i7yV5+YNG5EXlGnCf5xfdHMqrwzJ6FkeUNio0aANeho
 DxT8lu1V5ihcLWGbNiZAVomYgR0J1lZjmEuhJz1xsYZ9y/PRgf+Wkn0TDBnjnb/p
 RlLatPjkWcIjVa85cuGEFVW65YvzPvYjZEkF01/zx+ggPj52dKiBt2jy8f20leMS
 BFw216E9Co0ljGahdZp+08CugY+giZCrBh0traoWTQVe6ac4PdUwRiZebPbhrsqa
 XYHwQzVrwJDKiAaKerqYlQCLR0JexVdZnmmpy8hLoZDU8m2wyzvrNbGPU43kI4yX
 azv28RZm81uYLSV38YAA1LssaZ8Dd0dt0iqa4oq7b90MbBy2y54ruogMUDUdhqGJ
 eS/MMqr4n4+MBIKY9/1t5/BCkzv+fuvfufGaJzKR6kzNcRP6ECT3gScPavI1vZM2
 QUrL/DWiPCXqzkdl205W
 =K1cE
 -----END PGP SIGNATURE-----
 
 ------enig2LOEFAKILKJMOWMESQDTA--
State-Changed-From-To: open->closed 
State-Changed-By: bdrewery 
State-Changed-When: Sat Mar 9 16:54:10 CST 2013 
State-Changed-Why:  
Fixed! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171831 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/171831: commit references a PR
Date: Sat,  9 Mar 2013 22:54:06 +0000 (UTC)

 Author: bdrewery
 Date: Sat Mar  9 22:53:59 2013
 New Revision: 313770
 URL: http://svnweb.freebsd.org/changeset/ports/313770
 
 Log:
   - Use USE_SUBMAKE to fix running 'make build deinstall install' not properly
     using the pkg-static(8) from WRKSRC during the install phase
   
   PR:		ports/171831
   Reported by:	Garrett Cooper <yaneurabeya@gmail.com>
   Approved by:	portmgr (bapt)
 
 Modified:
   head/ports-mgmt/pkg/Makefile
 
 Modified: head/ports-mgmt/pkg/Makefile
 ==============================================================================
 --- head/ports-mgmt/pkg/Makefile	Sat Mar  9 22:45:46 2013	(r313769)
 +++ head/ports-mgmt/pkg/Makefile	Sat Mar  9 22:53:59 2013	(r313770)
 @@ -22,6 +22,9 @@ MANCOMPRESSED=	yes
  
  MAKE_ENV+=	WITHOUT_PROFILE=yes __MAKE_CONF=/dev/null SRCCONF=/dev/null
  USE_STAGE=	yes
 +# Use a submake as 'deinstall install' needs to reevaluate PKG_CMD
 +# so that pkg-static is used from the wrkdir
 +USE_SUBMAKE=	yes
  
  MAN8=	pkg.8 \
  	pkg-add.8 \
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 

From: Baptiste Daroussin <bapt@freebsd.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, yaneurabeya@gmail.com
Subject: Re: ports/171831: [pkgng] ports-mgmt/pkg: `make clean all deinstall
 install&#39; always fails
Date: Sat, 9 Mar 2013 23:50:41 +0100

 --GcSOTaE82DYSpZPK
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Sat, Mar 09, 2013 at 04:44:37PM -0600, Bryan Drewery wrote:
 > This fixes it for me:
 >=20
 > http://people.freebsd.org/~bdrewery/fix-deinstall-install.txt
 >=20
 > Regards,
 > Bryan
 >=20
 
 
 Same here, please commit!
 
 regards,
 Bapt
 
 --GcSOTaE82DYSpZPK
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (FreeBSD)
 
 iEYEARECAAYFAlE7vMEACgkQ8kTtMUmk6EwuAwCeMuicvUcuY29ODVWNJczmryYS
 86sAoLvbxRs4q5BMR9BGQnIbu1nBhPN9
 =o+S7
 -----END PGP SIGNATURE-----
 
 --GcSOTaE82DYSpZPK--
>Unformatted:
