From nemysis@gmx.ch  Mon Sep 17 12:00:44 2012
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 52A1810656D4
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 17 Sep 2012 12:00:44 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.22])
	by mx1.freebsd.org (Postfix) with SMTP id AF7498FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 17 Sep 2012 12:00:43 +0000 (UTC)
Received: (qmail invoked by alias); 17 Sep 2012 12:00:41 -0000
Received: from 201-230.4-85.cust.bluewin.ch (EHLO something.email.com) [85.4.230.201]
  by mail.gmx.net (mp012) with SMTP; 17 Sep 2012 14:00:41 +0200
Received: by something.email.com (sSMTP sendmail emulation); Mon, 17 Sep 2012 14:00:41 +0200
Message-Id: <20120917120044.52A1810656D4@hub.freebsd.org>
Date: Mon, 17 Sep 2012 14:00:41 +0200
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc: kevlo@FreeBSD.org
Subject: [PATCH] devel/iniparser: Fixed fatal error an Licence place, removed pkg-plist
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         171706
>Category:       ports
>Synopsis:       [PATCH] devel/iniparser: Fixed fatal error an Licence place, removed pkg-plist
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kevlo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 17 12:10:06 UTC 2012
>Closed-Date:    Tue Sep 18 02:10:33 UTC 2012
>Last-Modified:  Tue Sep 18 02:10:33 UTC 2012
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:

Frorm this Port

/usr/local/ports/local/patch/devel/iniparser> " portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: only one MASTER_SITE configured.  Consider adding additional mirrors.
0 fatal errors and 3 warnings found.


Here are fatal error and Licence is on wrong place.

/usr/ports/devel/iniparser> " portlint -A
WARN: /usr/ports/devel/iniparser/pkg-plist: There are only 5 items in the plist.  Consider using PLIST_FILES instead of pkg-plist when installing less than 6 items.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: only one MASTER_SITE configured.  Consider adding additional mirrors.
FATAL: Makefile: extra item "USE_LDCONFIG" placed in the LICENSE section.
WARN: Makefile: "LICENSE_FILE" has to appear earlier.
WARN: Makefile: "LICENSE" has to appear earlier.
WARN: Makefile: "LICENSE_FILE" has to appear earlier.
1 fatal error and 6 warnings found.


Removed file(s):
- pkg-plist

Port maintainer (kevlo@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- iniparser-3.1_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/devel/iniparser/Makefile ./Makefile
--- /usr/ports/devel/iniparser/Makefile	2012-09-01 08:45:23.000000000 +0200
+++ ./Makefile	2012-09-17 13:55:35.000000000 +0200
@@ -7,19 +7,26 @@
 
 PORTNAME=	iniparser
 PORTVERSION=	3.1
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	http://ndevilla.free.fr/iniparser/
 
 MAINTAINER=	kevlo@FreeBSD.org
-COMMENT=	A free stand-alone ini file parsing library
-
-USE_LDCONFIG=	yes
+COMMENT=	Free stand-alone ini file parsing library
 
 LICENSE=	MIT
 LICENSE_FILE=	${WRKSRC}/LICENSE
 
+USE_LDCONFIG=	yes
+
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
+PLIST_FILES=	include/dictionary.h \
+		include/iniparser.h \
+		lib/libiniparser.a \
+		lib/libiniparser.so \
+		lib/libiniparser.so.0
+
 do-build:
 	cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE}
 
diff -ruN --exclude=CVS /usr/ports/devel/iniparser/pkg-plist ./pkg-plist
--- /usr/ports/devel/iniparser/pkg-plist	2011-07-01 08:38:55.000000000 +0200
+++ ./pkg-plist	1970-01-01 01:00:00.000000000 +0100
@@ -1,5 +0,0 @@
-include/dictionary.h
-include/iniparser.h
-lib/libiniparser.a
-lib/libiniparser.so
-lib/libiniparser.so.0
--- iniparser-3.1_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kevlo 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Sep 17 12:10:17 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171706 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/171706: commit references a PR
Date: Tue, 18 Sep 2012 02:09:59 +0000 (UTC)

 Author: kevlo
 Date: Tue Sep 18 02:09:45 2012
 New Revision: 304425
 URL: http://svn.freebsd.org/changeset/ports/304425
 
 Log:
   Use PLIST_FILES instead of pkg-plist; no functional change.
   
   PR:	ports/171706
   Submitted by:	nemysis <nemysis at gmx dot ch>
 
 Deleted:
   head/devel/iniparser/pkg-plist
 Modified:
   head/devel/iniparser/Makefile
 
 Modified: head/devel/iniparser/Makefile
 ==============================================================================
 --- head/devel/iniparser/Makefile	Tue Sep 18 01:01:52 2012	(r304424)
 +++ head/devel/iniparser/Makefile	Tue Sep 18 02:09:45 2012	(r304425)
 @@ -11,15 +11,17 @@ CATEGORIES=	devel
  MASTER_SITES=	http://ndevilla.free.fr/iniparser/
  
  MAINTAINER=	kevlo@FreeBSD.org
 -COMMENT=	A free stand-alone ini file parsing library
 -
 -USE_LDCONFIG=	yes
 +COMMENT=	Free stand-alone ini file parsing library
  
  LICENSE=	MIT
  LICENSE_FILE=	${WRKSRC}/LICENSE
  
 +USE_LDCONFIG=	yes
  WRKSRC=		${WRKDIR}/${PORTNAME}
  
 +PLIST_FILES=	include/dictionary.h include/iniparser.h lib/libiniparser.a \
 +		lib/libiniparser.so lib/libiniparser.so.0
 +
  do-build:
  	cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE}
  
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: kevlo 
State-Changed-When: Tue Sep 18 02:10:20 UTC 2012 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171706 
>Unformatted:
