From nobody@FreeBSD.org  Wed Sep 12 19:39:44 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 78199106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Sep 2012 19:39:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 63CCF8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Sep 2012 19:39:44 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q8CJdifn044151
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Sep 2012 19:39:44 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id q8CJdijb044150;
	Wed, 12 Sep 2012 19:39:44 GMT
	(envelope-from nobody)
Message-Id: <201209121939.q8CJdijb044150@red.freebsd.org>
Date: Wed, 12 Sep 2012 19:39:44 GMT
From: "Christopher J. Ruwe" <cjr@cruwe.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: easytag: missing dependency on libid3tag
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         171585
>Category:       ports
>Synopsis:       audio/easytag: missing dependency on libid3tag
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    novel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 12 19:40:07 UTC 2012
>Closed-Date:    Sun Sep 23 17:33:43 UTC 2012
>Last-Modified:  Sun Sep 23 17:33:43 UTC 2012
>Originator:     Christopher J. Ruwe
>Release:        9-stable
>Organization:
>Environment:
FreeBSD dijkstra.cruwe.de 9.0-STABLE FreeBSD 9.0-STABLE #10 r237934: Tue Jul  3 17:29:27 CEST 2012     cjr@dijkstra.cruwe.de:/usr/obj/usr/src/sys/DIJKSTRA  amd64
>Description:
Easytag is a - I quote from the makefile - "GTK2 Tag editor for MP3 and OGG files". Since some time it is not possible anymore to edit mp3 files - mp4 and ogg is working fine. The problem appeared in PCBSD also (http://forums.pcbsd.org/showthread.php?t=17282).



>How-To-Repeat:
Build easytag in an environment where libid3tag is missing - poudriere in my case. Install easytag. Try to load a directory containing mp3-files. You will not be presented with any editing option. Then check Help -> About. The MP3 tagging capability will be crossed out.

Install libid3tag. Build easytag anew. The problem will be gone.
>Fix:
It appears that easytag depends on libid3tag to edit mp3 tags and that dependency is not pulled anymore - I do not understand why. Neither do I know why the problem has not been noticed before - at least according to the PR DB. Anyways, adding id3tag to the depends-statements solves the problem.

Adding a conditional depend for id3tag is possible, but, considering the description in the makefile, not really an option.

Patch attached with submission follows:

diff -uN /usr/ports/audio/easytag/Makefile easytag/Makefile
--- /usr/ports/audio/easytag/Makefile	2012-09-12 21:11:10.210680516 +0200
+++ easytag/Makefile	2012-09-12 21:14:24.890676921 +0200
@@ -15,6 +15,7 @@
 COMMENT=	GTK2 Tag editor for MP3 and OGG files
 
 LIB_DEPENDS=	id3:${PORTSDIR}/audio/id3lib \
+		id3tag:${PORTSDIR}/audio/libid3tag \
 		vorbis:${PORTSDIR}/audio/libvorbis \
 		FLAC:${PORTSDIR}/audio/flac \
 		mp4v2.10:${PORTSDIR}/multimedia/mp4v2


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->novel 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Sep 12 20:01:44 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171585 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/171585: commit references a PR
Date: Sun, 23 Sep 2012 17:29:38 +0000 (UTC)

 Author: novel
 Date: Sun Sep 23 17:29:12 2012
 New Revision: 304754
 URL: http://svn.freebsd.org/changeset/ports/304754
 
 Log:
   - Add a missing dependency on libid3tag [1]
   - Drop shlib versions from the dependency lines
   - Update headers to the new format
   
   PR:		171585 [1]
   Submitted by:	Christopher J. Ruwe <cjr@cruwe.de> [1]
 
 Modified:
   head/audio/easytag/Makefile
 
 Modified: head/audio/easytag/Makefile
 ==============================================================================
 --- head/audio/easytag/Makefile	Sun Sep 23 17:12:59 2012	(r304753)
 +++ head/audio/easytag/Makefile	Sun Sep 23 17:29:12 2012	(r304754)
 @@ -1,13 +1,9 @@
 -# New ports collection makefile for:	easytag-devel
 -# Date created:				15 Feb 2005
 -# Whom:					Adam Weinberger <adamw@FreeBSD.org>
 -#
 +# Created by:	Adam Weinberger <adamw@FreeBSD.org>
  # $FreeBSD$
 -#
  
  PORTNAME=	easytag
  PORTVERSION=	2.1.7
 -PORTREVISION=	2
 +PORTREVISION=	3
  CATEGORIES=	audio
  MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}%20%28gtk%202%29/${PORTVERSION:C/\.[0-9]+$//}
  
 @@ -15,9 +11,10 @@ MAINTAINER=	novel@FreeBSD.org
  COMMENT=	GTK2 Tag editor for MP3 and OGG files
  
  LIB_DEPENDS=	id3:${PORTSDIR}/audio/id3lib \
 +		id3tag:${PORTSDIR}/audio/libid3tag \
  		vorbis:${PORTSDIR}/audio/libvorbis \
  		FLAC:${PORTSDIR}/audio/flac \
 -		mp4v2.10:${PORTSDIR}/multimedia/mp4v2
 +		mp4v2:${PORTSDIR}/multimedia/mp4v2
  
  MAN1=		easytag.1
  CONFLICTS=	easytag-devel-[0-9]*
 @@ -30,7 +27,7 @@ CPPFLAGS+=	-I${LOCALBASE}/include -DHAVE
  LDFLAGS+=	-L${LOCALBASE}/lib
  
  .if defined(WITH_WAVPACK)
 -LIB_DEPENDS+=		wavpack.2:${PORTSDIR}/audio/wavpack
 +LIB_DEPENDS+=		wavpack:${PORTSDIR}/audio/wavpack
  CONFIGURE_ARGS+=	--enable-wavpack
  .else
  CONFIGURE_ARGS+=	--disable-wavpack
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: novel 
State-Changed-When: Sun Sep 23 17:33:42 UTC 2012 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171585 
>Unformatted:
