From mandree@FreeBSD.org  Tue Sep 11 00:17:40 2012
Return-Path: <mandree@FreeBSD.org>
Received: from apollo.emma.line.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 20E12106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 11 Sep 2012 00:17:40 +0000 (UTC)
	(envelope-from mandree@FreeBSD.org)
Received: from mandree by apollo.emma.line.org with local (Exim 4.80 (FreeBSD))
	(envelope-from <mandree@FreeBSD.org>)
	id 1TBEAL-000KXD-5k
	for FreeBSD-gnats-submit@freebsd.org; Tue, 11 Sep 2012 02:17:21 +0200
Message-Id: <E1TBEAL-000KXD-5k@apollo.emma.line.org>
Date: Tue, 11 Sep 2012 02:17:21 +0200
From: Matthias Andree <mandree@FreeBSD.org>
Reply-To: Matthias Andree <mandree@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: x11/yelp: no longer builds with new libxul port 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         171530
>Category:       ports
>Synopsis:       x11/yelp: no longer builds with new libxul port
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 11 00:20:02 UTC 2012
>Closed-Date:    Fri Dec 28 18:38:10 UTC 2012
>Last-Modified:  Fri Dec 28 18:38:10 UTC 2012
>Originator:     Matthias Andree
>Release:        FreeBSD 9.1-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD apollo.emma.line.org 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #4: Wed Aug 29 22:15:30 CEST 2012 toor@apollo.emma.line.org:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:
yelp no longer builds with libxul-10.0.7 (1.9.2.8 was insecure but would
build), unable to detect that libxul was actually built against GTK 2.

$ cat /var/db/ports/libxul/options 
# This file is auto-generated by 'make config'.
# # Options for libxul-10.0.7
# _OPTIONS_READ=libxul-10.0.7
# _FILE_COMPLETE_OPTIONS_LIST=DBUS DEBUG GNOME LIBPROXY LOGGING
# OPTIMIZED_CFLAGS ALSA OSS PULSEAUDIO GTK2 QT4 GCONF GIO GNOMEUI
# GNOMEVFS2
# OPTIONS_FILE_SET+=DBUS
# OPTIONS_FILE_UNSET+=DEBUG
# OPTIONS_FILE_UNSET+=GNOME
# OPTIONS_FILE_UNSET+=LIBPROXY
# OPTIONS_FILE_SET+=LOGGING
# OPTIONS_FILE_UNSET+=OPTIMIZED_CFLAGS
# OPTIONS_FILE_UNSET+=ALSA
# OPTIONS_FILE_SET+=OSS
# OPTIONS_FILE_UNSET+=PULSEAUDIO
# OPTIONS_FILE_SET+=GTK2
# OPTIONS_FILE_UNSET+=QT4
# OPTIONS_FILE_UNSET+=GCONF
# OPTIONS_FILE_UNSET+=GIO
# OPTIONS_FILE_UNSET+=GNOMEUI
# OPTIONS_FILE_UNSET+=GNOMEVFS2


Running "make configure" yields:

checking for gawk... (cached) gawk
checking which gecko to use... libxul
checking manual gecko home set... checking for compiler -fshort-wchar
option... yes
checking whether to enable C++ RTTI... no
checking whether we have a gtk 2 gecko build... configure: error: This
program needs a gtk 2 gecko build


Relevant excerpt from config.log:

configure:19662: checking whether to enable C++ RTTI
configure:19671: result: no
configure:19697: checking whether we have a gtk 2 gecko build
configure:19716: c++ -o conftest -O2 -pipe -march=athlon64
-fno-strict-aliasing -I/usr/local/include  -I/usr/local/include/libxul
-fshort-wchar -I/usr/local/include/nspr  -I/usr/local/include/libxul
-fshort-wchar -I/usr/local/include/nspr   -L/usr/local/lib
-fstack-protector conftest.cpp  >&5
conftest.cpp: In function 'int main()':
conftest.cpp:48: error: 'MOZ_DEFAULT_TOOLKIT' was not declared in this
scope
configure:19716: $? = 1
configure: program exited with status 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "Yelp"
| #define PACKAGE_TARNAME "yelp"
| #define PACKAGE_VERSION "2.30.2"
| #define PACKAGE_STRING "Yelp 2.30.2"
| #define PACKAGE_BUGREPORT
"http://bugzilla.gnome.org/enter_bug.cgi?product=yelp"
| #define PACKAGE_URL ""
| #define PACKAGE "yelp"
| #define VERSION "2.30.2"
| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_MEMORY_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_UNISTD_H 1
| #define HAVE_DLFCN_H 1
| #define LT_OBJDIR ".libs/"
| #define GETTEXT_PACKAGE "yelp"
| #define HAVE_LOCALE_H 1
| #define HAVE_LC_MESSAGES 1
| #define HAVE_BIND_TEXTDOMAIN_CODESET 1
| #define HAVE_GETTEXT 1
| #define HAVE_DCGETTEXT 1
| #define ENABLE_NLS 1
| #define GNOMELOCALEDIR "/usr/local/share/locale"
| #define HAVE_LIBBZ2 1
| #define bzread BZ2_bzread
| #define bzopen BZ2_bzopen
| #define bzdopen BZ2_bzdopen
| #define bzwrite BZ2_bzwrite
| #define bzerror BZ2_bzerror
| #define bzclose BZ2_bzclose
| #define bzflush BZ2_bzflush
| #define bzCompress BZ2_bzCompress
| #define bzCompressInit BZ2_bzCompressInit
| #define bzDecompress BZ2_bzDecompress
| #define bzDecompressInit BZ2_bzDecompressInit
| #define HAVE_MOZILLA_TOOLKIT 1
| /* end confdefs.h.  */
| #include <mozilla-config.h>
|                 #include <string.h>
|                 #include <stdlib.h>
|                   int main(void) {
|                   if (strcmp (MOZ_DEFAULT_TOOLKIT, "gtk2") == 0 ||
|                       strcmp (MOZ_DEFAULT_TOOLKIT, "cairo-gtk2") == 0)
|                           return EXIT_SUCCESS;
| 
|                   return EXIT_FAILURE;
|                 }
| 
configure:19719: error: This program needs a gtk 2 gecko build


	
>How-To-Repeat:
	
>Fix:

	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Sep 11 00:20:15 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171530 

From: Matthias Andree <mandree@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org
Cc:  
Subject: Re: ports/171530: x11/yelp: no longer builds with new libxul port
Date: Tue, 11 Sep 2012 02:22:51 +0200

 Perhaps this helps with devising a fix:
 
 $ egrep -ni '(toolkit|gtk)' /usr/local/include/libxul/mozilla-config.h
 113:#define MOZ_WIDGET_GTK2 1
 
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Fri Dec 28 18:37:40 UTC 2012 
State-Changed-Why:  
kwm@ has committed a fix by having Yelp depends on webkit instead of gecko. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171530 
>Unformatted:
