From nemysis@gmx.ch  Thu Sep  6 00:24:01 2012
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E94081065674
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Sep 2012 00:24:01 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.22])
	by mx1.freebsd.org (Postfix) with SMTP id 196468FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Sep 2012 00:24:00 +0000 (UTC)
Received: (qmail invoked by alias); 06 Sep 2012 00:23:59 -0000
Received: from 201-230.4-85.cust.bluewin.ch (EHLO something.email.com) [85.4.230.201]
  by mail.gmx.net (mp034) with SMTP; 06 Sep 2012 02:23:59 +0200
Received: by something.email.com (sSMTP sendmail emulation); Thu, 06 Sep 2012 02:23:58 +0200
Message-Id: <20120906002401.E94081065674@hub.freebsd.org>
Date: Thu, 06 Sep 2012 02:23:58 +0200
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jgh@FreeBSD.org
Subject: [MAINTAINER] games/simsu: Makefile simplified
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         171358
>Category:       ports
>Synopsis:       [MAINTAINER] games/simsu: Makefile simplified
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ak
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 06 00:30:02 UTC 2012
>Closed-Date:    Sat Sep 08 22:16:04 UTC 2012
>Last-Modified:  Sat Sep 08 22:16:04 UTC 2012
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:

Makefile simplified


Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- simsu-1.2.2_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/games/simsu/Makefile ./Makefile
--- /usr/ports/games/simsu/Makefile	2012-09-01 15:39:34.000000000 +0200
+++ ./Makefile	2012-09-06 02:19:58.000000000 +0200
@@ -7,54 +7,35 @@
 
 PORTNAME=	simsu
 PORTVERSION=	1.2.2
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	games
 MASTER_SITES=	http://gottcode.org/${PORTNAME}/
-EXTRACT_SUFX=	-src.tar.bz2
+DISTNAME=	${PORTNAME}-${DISTVERSION}-src
 
 MAINTAINER=	nemysis@gmx.ch
 COMMENT=	Simsu is a basic Sudoku game
 
 LICENSE=	GPLv3
 
-USE_QT4=	moc_build qmake_build rcc_build uic_build iconengines imageformats
+WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
 
+USE_BZIP2=	yes
+USE_QT4=	moc_build qmake_build rcc_build uic_build iconengines imageformats
 INSTALLS_ICONS=	yes
-HAS_CONFIGURE=	yes
+MAKE_JOBS_SAFE=	yes
 
 do-configure:
 	@cd ${WRKSRC} && ${SETENV} ${CONFIGURE_ENV} \
 		${QMAKE} PREFIX=${PREFIX} ${WRKSRC}/${PORTNAME}.pro
 
-CONFIGURE_ENV+=	UIC="${UIC}" QMAKE="${QMAKE}" QMAKESPEC="${QMAKESPEC}"
-MAKE_ENV+=	QMAKESPEC="${QMAKESPEC}"
-
-USE_GMAKE=	yes
-MAKE_JOBS_SAFE=	yes
-
 PORTDATA=	*
 PORTDOCS=	CREDITS ChangeLog
 
 .include <bsd.port.options.mk>
 
-do-install:
-# Executable
-	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
-
-# Data
-	${MKDIR} ${DATADIR}
-	@(cd ${WRKSRC} && ${COPYTREE_SHARE} "symmetry translations" ${DATADIR})
-
-# Icons
-	${MKDIR} ${PREFIX}/share/icons/hicolor
-.for d in icons
-	@(cd ${WRKSRC}/${d} && ${COPYTREE_SHARE} hicolor ${PREFIX}/share/icons/)
-.endfor
-
-# Pixmaps and Desktop
-	${INSTALL_DATA} ${WRKSRC}/icons/${PORTNAME}_32.xpm ${PREFIX}/share/pixmaps/
-	${MKDIR} ${PREFIX}/share/applications
-	${INSTALL_DATA} ${WRKSRC}/icons/${PORTNAME}.desktop ${PREFIX}/share/applications/
+post-install:
+# Pixmaps
+	${INSTALL_DATA} ${WRKSRC}/icons/hicolor/48x48/apps/simsu.png ${PREFIX}/share/pixmaps/
 
 # Documentation
 .if ${PORT_OPTIONS:MDOCS}
diff -ruN --exclude=CVS /usr/ports/games/simsu/pkg-plist ./pkg-plist
--- /usr/ports/games/simsu/pkg-plist	2012-05-13 12:12:22.000000000 +0200
+++ ./pkg-plist	2012-09-06 02:11:14.000000000 +0200
@@ -9,5 +9,5 @@
 share/icons/hicolor/48x48/apps/simsu.png
 share/icons/hicolor/64x64/apps/simsu.png
 share/icons/hicolor/scalable/apps/simsu.svg
-share/pixmaps/simsu_32.xpm
+share/pixmaps/simsu.png
 @dirrmtry share/applications
--- simsu-1.2.2_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ak 
Responsible-Changed-By: ak 
Responsible-Changed-When: Fri Sep 7 16:51:26 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171358 

From: nemysis <nemysis@gmx.ch>
To: bug-followup@FreeBSD.org, Alex Kozlov <ak@freebsd.org>
Cc:  
Subject: Re: ports/171358: [MAINTAINER] games/simsu: Makefile simplified
Date: Sat, 8 Sep 2012 11:24:45 +0200

 --Sig_/nx7GNEOTC81SATnxMggLp+H
 Content-Type: multipart/mixed; boundary="MP_/yKZ0PLqecKnEjC=aHDiHguT"
 
 --MP_/yKZ0PLqecKnEjC=aHDiHguT
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline
 
 Have changed Order in Makefile.
 
 --MP_/yKZ0PLqecKnEjC=aHDiHguT
 Content-Type: text/x-patch
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: attachment; filename=simsu.diff
 
 =3D=3D=3D> Generating patch
 =3D=3D=3D> Viewing diff with more
 diff -ruN --exclude=3DCVS /usr/ports/games/simsu/Makefile ./Makefile
 --- /usr/ports/games/simsu/Makefile	2012-09-01 15:39:34.000000000 +0200
 +++ ./Makefile	2012-09-08 11:21:32.000000000 +0200
 @@ -7,29 +7,19 @@
 =20
  PORTNAME=3D	simsu
  PORTVERSION=3D	1.2.2
 -PORTREVISION=3D	1
 +PORTREVISION=3D	2
  CATEGORIES=3D	games
  MASTER_SITES=3D	http://gottcode.org/${PORTNAME}/
  EXTRACT_SUFX=3D	-src.tar.bz2
 =20
  MAINTAINER=3D	nemysis@gmx.ch
 -COMMENT=3D	Simsu is a basic Sudoku game
 +COMMENT=3D	Basic Sudoku game
 =20
  LICENSE=3D	GPLv3
 =20
 +USE_BZIP2=3D	yes
  USE_QT4=3D	moc_build qmake_build rcc_build uic_build iconengines imageform=
 ats
 -
  INSTALLS_ICONS=3D	yes
 -HAS_CONFIGURE=3D	yes
 -
 -do-configure:
 -	@cd ${WRKSRC} && ${SETENV} ${CONFIGURE_ENV} \
 -		${QMAKE} PREFIX=3D${PREFIX} ${WRKSRC}/${PORTNAME}.pro
 -
 -CONFIGURE_ENV+=3D	UIC=3D"${UIC}" QMAKE=3D"${QMAKE}" QMAKESPEC=3D"${QMAKESP=
 EC}"
 -MAKE_ENV+=3D	QMAKESPEC=3D"${QMAKESPEC}"
 -
 -USE_GMAKE=3D	yes
  MAKE_JOBS_SAFE=3D	yes
 =20
  PORTDATA=3D	*
 @@ -37,24 +27,13 @@
 =20
  .include <bsd.port.options.mk>
 =20
 -do-install:
 -# Executable
 -	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
 -
 -# Data
 -	${MKDIR} ${DATADIR}
 -	@(cd ${WRKSRC} && ${COPYTREE_SHARE} "symmetry translations" ${DATADIR})
 -
 -# Icons
 -	${MKDIR} ${PREFIX}/share/icons/hicolor
 -.for d in icons
 -	@(cd ${WRKSRC}/${d} && ${COPYTREE_SHARE} hicolor ${PREFIX}/share/icons/)
 -.endfor
 -
 -# Pixmaps and Desktop
 -	${INSTALL_DATA} ${WRKSRC}/icons/${PORTNAME}_32.xpm ${PREFIX}/share/pixmap=
 s/
 -	${MKDIR} ${PREFIX}/share/applications
 -	${INSTALL_DATA} ${WRKSRC}/icons/${PORTNAME}.desktop ${PREFIX}/share/appli=
 cations/
 +do-configure:
 +	@cd ${WRKSRC} && ${SETENV} ${CONFIGURE_ENV} \
 +		${QMAKE} ${QMAKEFLAGS} PREFIX=3D${PREFIX}
 +
 +post-install:
 +# Pixmaps
 +	${INSTALL_DATA} ${WRKSRC}/icons/hicolor/48x48/apps/simsu.png ${PREFIX}/sh=
 are/pixmaps/
 =20
  # Documentation
  .if ${PORT_OPTIONS:MDOCS}
 diff -ruN --exclude=3DCVS /usr/ports/games/simsu/pkg-plist ./pkg-plist
 --- /usr/ports/games/simsu/pkg-plist	2012-05-13 12:12:22.000000000 +0200
 +++ ./pkg-plist	2012-09-08 11:06:11.000000000 +0200
 @@ -9,5 +9,6 @@
  share/icons/hicolor/48x48/apps/simsu.png
  share/icons/hicolor/64x64/apps/simsu.png
  share/icons/hicolor/scalable/apps/simsu.svg
 +share/pixmaps/simsu.png
  share/pixmaps/simsu_32.xpm
  @dirrmtry share/applications
 =3D=3D=3D> Done
 
 --MP_/yKZ0PLqecKnEjC=aHDiHguT--
 
 --Sig_/nx7GNEOTC81SATnxMggLp+H
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (FreeBSD)
 
 iF4EAREIAAYFAlBLDt4ACgkQSY5SjAQUAPtbEAD/XH5gg2rI7v/ijayeAMC/cRdS
 1zadt360i8R5L7CPNjMBAJRvE6BiMz/G7J78yqb9Rto5vaVXqlUtAcAC8cPfxju4
 =n4OX
 -----END PGP SIGNATURE-----
 
 --Sig_/nx7GNEOTC81SATnxMggLp+H--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/171358: commit references a PR
Date: Sat,  8 Sep 2012 21:02:56 +0000 (UTC)

 Author: ak
 Date: Sat Sep  8 21:02:41 2012
 New Revision: 303930
 URL: http://svn.freebsd.org/changeset/ports/303930
 
 Log:
   - Simplify Makefile [1]
   - Remove deprecated comments at the top of Makefile
   
   PR:	ports/171358
   Submitted by:	nemysis <nemysis at gmx.ch> (maintainer) [1]
 
 Modified:
   head/games/simsu/Makefile
   head/games/simsu/pkg-plist   (contents, props changed)
 
 Modified: head/games/simsu/Makefile
 ==============================================================================
 --- head/games/simsu/Makefile	Sat Sep  8 20:34:17 2012	(r303929)
 +++ head/games/simsu/Makefile	Sat Sep  8 21:02:41 2012	(r303930)
 @@ -1,35 +1,20 @@
 -# New Ports collection makefile for:	simsu
 -# Date created:		2012-04-21
 -# Whom:			nemysis@gmx.ch
 -#
  # $FreeBSD$
 -#
  
  PORTNAME=	simsu
  PORTVERSION=	1.2.2
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	games
  MASTER_SITES=	http://gottcode.org/${PORTNAME}/
  EXTRACT_SUFX=	-src.tar.bz2
  
  MAINTAINER=	nemysis@gmx.ch
 -COMMENT=	Simsu is a basic Sudoku game
 +COMMENT=	Basic Sudoku game
  
  LICENSE=	GPLv3
  
 +USE_BZIP2=	yes
  USE_QT4=	moc_build qmake_build rcc_build uic_build iconengines imageformats
 -
  INSTALLS_ICONS=	yes
 -HAS_CONFIGURE=	yes
 -
 -do-configure:
 -	@cd ${WRKSRC} && ${SETENV} ${CONFIGURE_ENV} \
 -		${QMAKE} PREFIX=${PREFIX} ${WRKSRC}/${PORTNAME}.pro
 -
 -CONFIGURE_ENV+=	UIC="${UIC}" QMAKE="${QMAKE}" QMAKESPEC="${QMAKESPEC}"
 -MAKE_ENV+=	QMAKESPEC="${QMAKESPEC}"
 -
 -USE_GMAKE=	yes
  MAKE_JOBS_SAFE=	yes
  
  PORTDATA=	*
 @@ -37,24 +22,13 @@ PORTDOCS=	CREDITS ChangeLog
  
  .include <bsd.port.options.mk>
  
 -do-install:
 -# Executable
 -	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
 -
 -# Data
 -	${MKDIR} ${DATADIR}
 -	@(cd ${WRKSRC} && ${COPYTREE_SHARE} "symmetry translations" ${DATADIR})
 -
 -# Icons
 -	${MKDIR} ${PREFIX}/share/icons/hicolor
 -.for d in icons
 -	@(cd ${WRKSRC}/${d} && ${COPYTREE_SHARE} hicolor ${PREFIX}/share/icons/)
 -.endfor
 -
 -# Pixmaps and Desktop
 -	${INSTALL_DATA} ${WRKSRC}/icons/${PORTNAME}_32.xpm ${PREFIX}/share/pixmaps/
 -	${MKDIR} ${PREFIX}/share/applications
 -	${INSTALL_DATA} ${WRKSRC}/icons/${PORTNAME}.desktop ${PREFIX}/share/applications/
 +do-configure:
 +	@cd ${WRKSRC} && ${SETENV} ${CONFIGURE_ENV} \
 +		${QMAKE} ${QMAKEFLAGS} PREFIX=${PREFIX}
 +
 +post-install:
 +# Pixmaps
 +	${INSTALL_DATA} ${WRKSRC}/icons/hicolor/48x48/apps/simsu.png ${PREFIX}/share/pixmaps/
  
  # Documentation
  .if ${PORT_OPTIONS:MDOCS}
 
 Modified: head/games/simsu/pkg-plist
 ==============================================================================
 --- head/games/simsu/pkg-plist	Sat Sep  8 20:34:17 2012	(r303929)
 +++ head/games/simsu/pkg-plist	Sat Sep  8 21:02:41 2012	(r303930)
 @@ -9,5 +9,6 @@ share/icons/hicolor/32x32/apps/simsu.png
  share/icons/hicolor/48x48/apps/simsu.png
  share/icons/hicolor/64x64/apps/simsu.png
  share/icons/hicolor/scalable/apps/simsu.svg
 +share/pixmaps/simsu.png
  share/pixmaps/simsu_32.xpm
  @dirrmtry share/applications
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: ak 
State-Changed-When: Sat Sep 8 22:16:01 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171358 
>Unformatted:
