From bdrewery@FreeBSD.org  Tue Sep  4 15:02:21 2012
Return-Path: <bdrewery@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A8CBA106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  4 Sep 2012 15:02:21 +0000 (UTC)
	(envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 8D8A28FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  4 Sep 2012 15:02:21 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q84F2LtP062278
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 4 Sep 2012 15:02:21 GMT
	(envelope-from bdrewery@freefall.freebsd.org)
Received: (from bdrewery@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q84F2LDu062237
	for FreeBSD-gnats-submit@freebsd.org; Tue, 4 Sep 2012 15:02:21 GMT
	(envelope-from bdrewery)
Received: (qmail 75650 invoked from network); 4 Sep 2012 10:02:17 -0500
Received: from unknown (HELO test8.xzibition.com) (10.10.0.34)
  by sweb.xzibition.com with SMTP; 4 Sep 2012 10:02:17 -0500
Received: by test8.xzibition.com (sSMTP sendmail emulation); Tue, 04 Sep 2012 10:02:16 -0500
Message-Id: <201209041502.q84F2LDu062237@freefall.freebsd.org>
Date: Tue, 04 Sep 2012 10:02:16 -0500
From: Bryan Drewery <bdrewery@freebsd.org>
Reply-To: Bryan Drewery <bdrewery@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] devel/gdb: Use USE_READLINE=port to ensure port version of readline
X-Send-Pr-Version: 3.113
X-GNATS-Notify: luca.pizzamiglio@gmail.com

>Number:         171325
>Category:       ports
>Synopsis:       [PATCH] devel/gdb: Use USE_READLINE=port to ensure port version of readline
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bdrewery
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 04 15:10:01 UTC 2012
>Closed-Date:    Sun Sep 09 13:56:06 UTC 2012
>Last-Modified:  Sun Sep 09 13:56:06 UTC 2012
>Originator:     Bryan Drewery
>Release:        FreeBSD 8.3-RELEASE i386
>Organization:
>Environment:

	
>Description:
	ports/162995 added USE_READLINE=port support to bsd.port.mk. This ensures that the port version is always used.
	By switching to using this, we can ensure someone does not accidentally break gdb again, and make portlint happy.
>How-To-Repeat:
	
>Fix:

	

--- patch-devel-gdb-use-readline.txt begins here ---
# svn status
M       Makefile

Index: Makefile
===================================================================
--- Makefile	(revision 303654)
+++ Makefile	(working copy)
@@ -39,11 +39,7 @@
 
 ONLY_FOR_ARCHS=	i386 amd64	# untested elsewhere, might work
 
-# Forcing to use readline.6 from ports (newer readline in FreeBSD world is not
-# compatible anymore). Please ignore portlint here.
-LIB_DEPENDS+=	readline.6:${PORTSDIR}/devel/readline
-CFLAGS+=	-isystem ${LOCALBASE}/include
-LDFLAGS+=	-L${LOCALBASE}/lib
+USE_READLINE=	port
 
 OPTIONS_DEFINE=	DEBUG EXPAT PYTHON THREADS GDB_LINK
 GDB_LINK_DESC=	Create the gdb link
--- patch-devel-gdb-use-readline.txt ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->bdrewery 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Sep 4 15:10:15 UTC 2012 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171325 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Sep 4 15:10:23 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171325 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: luca.pizzamiglio@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/171325: [PATCH] devel/gdb: Use USE_READLINE=port to ensure port version of readline
Date: Tue, 4 Sep 2012 15:10:19 UT

 Maintainer of devel/gdb,
 
 Please note that PR ports/171325 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171325
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Luca Pizzamiglio <luca.pizzamiglio@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/171325: [PATCH] devel/gdb: Use USE_READLINE=port to ensure
 port version of readline
Date: Wed, 5 Sep 2012 10:28:32 +0200

 I tested the patch on redports and unfortunately the dependency is
 failed on FreeBSD9/amd64.
 
 the readline port was not installed and the linking phase failed (I
 don't understand why, I've not enough information)..
 
 
 On Tue, Sep 4, 2012 at 5:10 PM, Edwin Groothuis <edwin@freebsd.org> wrote:
 > Maintainer of devel/gdb,
 >
 > Please note that PR ports/171325 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171325
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org

From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Luca Pizzamiglio <luca.pizzamiglio@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/171325: [PATCH] devel/gdb: Use USE_READLINE=port to ensure
 port version of readline
Date: Fri, 07 Sep 2012 21:50:29 -0500

 Luca,
 
 I think that failure was a fluke with redports. I re-ran the same
 revision as last time and it passed this time:
 
 http://redports.org/buildarchive/20120908011804-47766/
 
 Can you please try rebuilding yourself as well?
 
 Regards,
 Bryan

From: Luca Pizzamiglio <luca.pizzamiglio@gmail.com>
To: Bryan Drewery <bdrewery@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/171325: [PATCH] devel/gdb: Use USE_READLINE=port to ensure
 port version of readline
Date: Sat, 8 Sep 2012 17:54:19 +0200

 Hi Bryan,
 
 I've tested your patch on a "real" amd64 FreeBSD9 system without problem.
 Patch approved!
 thanks for your support!
 
 Luca
 
 On Sat, Sep 8, 2012 at 4:50 AM, Bryan Drewery <bdrewery@freebsd.org> wrote:
 > Luca,
 >
 > I think that failure was a fluke with redports. I re-ran the same
 > revision as last time and it passed this time:
 >
 > http://redports.org/buildarchive/20120908011804-47766/
 >
 > Can you please try rebuilding yourself as well?
 >
 > Regards,
 > Bryan
State-Changed-From-To: feedback->closed 
State-Changed-By: bdrewery 
State-Changed-When: Sun Sep 9 13:56:03 UTC 2012 
State-Changed-Why:  
Committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171325 
>Unformatted:
