From glewis@misty.eyesbeyond.com  Tue Sep  4 02:30:11 2012
Return-Path: <glewis@misty.eyesbeyond.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0E2F6106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  4 Sep 2012 02:30:11 +0000 (UTC)
	(envelope-from glewis@misty.eyesbeyond.com)
Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16])
	by mx1.freebsd.org (Postfix) with ESMTP id BB43E8FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  4 Sep 2012 02:30:10 +0000 (UTC)
Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1])
	by misty.eyesbeyond.com (8.14.5/8.14.5) with ESMTP id q842U381040137
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 3 Sep 2012 19:30:03 -0700 (PDT)
	(envelope-from glewis@misty.eyesbeyond.com)
Received: (from glewis@localhost)
	by misty.eyesbeyond.com (8.14.5/8.14.5/Submit) id q842U3aK040136;
	Mon, 3 Sep 2012 19:30:03 -0700 (PDT)
	(envelope-from glewis)
Message-Id: <201209040230.q842U3aK040136@misty.eyesbeyond.com>
Date: Mon, 3 Sep 2012 19:30:03 -0700 (PDT)
From: Greg Lewis <glewis@freebsd.org>
Reply-To: Greg Lewis <glewis@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: multimedia/vlc doesn't compile
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         171304
>Category:       ports
>Synopsis:       multimedia/vlc doesn't compile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-multimedia
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 04 02:40:09 UTC 2012
>Closed-Date:    Wed Sep 05 16:54:08 UTC 2012
>Last-Modified:  Wed Sep  5 17:30:03 UTC 2012
>Originator:     Greg Lewis
>Release:        FreeBSD 8.3-RELEASE-p3 i386
>Organization:
FreeBSD
>Environment:
System: FreeBSD misty.eyesbeyond.com 8.3-RELEASE-p3 FreeBSD 8.3-RELEASE-p3 #0: Sat Jun 23 13:28:02 PDT 2012 glewis@misty.eyesbeyond.com:/usr/obj/usr/src/sys/MISTY i386


>Description:

On my machine, vlc will fail to compile misc/cpu.c, emitting errors like
this:

misc/cpu.c:129: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'static'

>How-To-Repeat:
Just try and build the port.  I suspect your processor has to support
certain MMX or SSE features.

>Fix:

Use a newer version of GCC.  I actually believe 4.4 or better should work.

Index: Makefile
===================================================================
--- Makefile	(revision 303631)
+++ Makefile	(working copy)
@@ -25,6 +25,8 @@
 BUILD_DEPENDS=	ffmpeg${FFMPEG_SUFFIX}>0.11:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
 RUN_DEPENDS=	ffmpeg${FFMPEG_SUFFIX}>0.11:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
 
+USE_GCC=	4.6+
+
 OPTIONS_DEFINE=	A52 AALIB ASS AVAHI CACA DBUS DIRAC DOCS DTS DVDREAD \
 		DVDNAV FAAD FLAC FLUID FRIBIDI GLX GNOMEVFS GNUTLS GOOM \
 		HTTPD JACK LIVEMEDIA LUA MAD MATROSKA MODPLUG MPEG2 MTP \
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-multimedia 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Sep 4 02:40:21 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171304 
State-Changed-From-To: open->closed 
State-Changed-By: nox 
State-Changed-When: Wed Sep 5 16:54:06 UTC 2012 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171304 

From: Juergen Lock <nox@jelal.kn-bremen.de>
To: bug-followup@freebsd.org
Cc: Greg Lewis <glewis@freebsd.org>, multimedia@freebsd.org
Subject: Re: ports/171304: multimedia/vlc doesn't compile
Date: Wed, 5 Sep 2012 19:25:18 +0200

 Hm query-pr.cgi doesn't pick up the patch properly, here is it again,
 this time against the port dir:
 
 Index: files/patch-include-vlc_common.h
 --- /dev/null
 +++ files/patch-include-vlc_common.h
 @@ -0,0 +1,11 @@
 +--- include/vlc_common.h.orig
 ++++ include/vlc_common.h
 +@@ -642,7 +642,7 @@ static inline unsigned popcount (unsigne
 + #endif
 + }
 + 
 +-#ifdef __OS2__
 ++#if defined(__OS2__) || defined(__FreeBSD__)
 + #   undef bswap16
 + #   undef bswap32
 + #   undef bswap64
>Unformatted:
