From nobody@FreeBSD.org  Wed Aug 29 08:31:39 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 201971065675
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 Aug 2012 08:31:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 0BB268FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 Aug 2012 08:31:39 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7T8Vcks048757
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 Aug 2012 08:31:38 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q7T8VcX9048756;
	Wed, 29 Aug 2012 08:31:38 GMT
	(envelope-from nobody)
Message-Id: <201208290831.q7T8VcX9048756@red.freebsd.org>
Date: Wed, 29 Aug 2012 08:31:38 GMT
From: Pietro Cerutti <gahr@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] math/R -- remove limitation on unthreaded version of Tk
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         171156
>Category:       ports
>Synopsis:       [patch] math/R -- remove limitation on unthreaded version of Tk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 29 08:40:10 UTC 2012
>Closed-Date:    Tue Sep 18 10:22:43 UTC 2012
>Last-Modified:  Tue Sep 18 10:30:07 UTC 2012
>Originator:     Pietro Cerutti
>Release:        
>Organization:
The FreeBSD Project
>Environment:
>Description:
math/R specifies that it requires an unthreaded version of Tk, via the USE_TK_NO_THREADS variable. I have successfully built R with a threaded version of Tk and run R --gui=Tk without any problems.

I kindly ask you to check whether this limitation is actually needed. If it's not the case, I'll remove the variable.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 302796)
+++ Makefile	(working copy)
@@ -194,7 +194,6 @@
 .endif
 
 .if ${PORT_OPTIONS:MTCLTK}
-USE_TK_NO_THREADS=	yes
 USE_TK =		84+
 CONFIGURE_ARGS+=	--with-tcltk \
 			--with-tcl-config=${TCL_LIBDIR}/tclConfig.sh \


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->bf 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Aug 29 08:40:24 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171156 
State-Changed-From-To: open->closed 
State-Changed-By: gahr 
State-Changed-When: Tue Sep 18 10:22:42 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171156 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/171156: commit references a PR
Date: Tue, 18 Sep 2012 10:22:43 +0000 (UTC)

 Author: gahr
 Date: Tue Sep 18 10:22:28 2012
 New Revision: 304440
 URL: http://svn.freebsd.org/changeset/ports/304440
 
 Log:
   - Remove limitation on unthreaded version of Tk
   
   PR:		171156
   Submitted by:	gahr
   Approved by:	maintainer (timeout 20 days)
 
 Modified:
   head/math/R/Makefile
 
 Modified: head/math/R/Makefile
 ==============================================================================
 --- head/math/R/Makefile	Tue Sep 18 10:19:30 2012	(r304439)
 +++ head/math/R/Makefile	Tue Sep 18 10:22:28 2012	(r304440)
 @@ -194,7 +194,6 @@ CONFIGURE_ARGS+=	--without-libpng
  .endif
  
  .if ${PORT_OPTIONS:MTCLTK}
 -USE_TK_NO_THREADS=	yes
  USE_TK =		84+
  CONFIGURE_ARGS+=	--with-tcltk \
  			--with-tcl-config=${TCL_LIBDIR}/tclConfig.sh \
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
