From nobody@FreeBSD.org  Tue Aug 28 15:34:09 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1373D1065676
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Aug 2012 15:34:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id F25E08FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Aug 2012 15:34:08 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7SFY8FZ047760
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Aug 2012 15:34:08 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q7SFY8Qc047758;
	Tue, 28 Aug 2012 15:34:08 GMT
	(envelope-from nobody)
Message-Id: <201208281534.q7SFY8Qc047758@red.freebsd.org>
Date: Tue, 28 Aug 2012 15:34:08 GMT
From: Pietro Cerutti <gahr@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] lang/otcl -- fix build with Tcl 8.6 + remove limitation on unthreaded version
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: 5u623l20@gmail.com

>Number:         171142
>Category:       ports
>Synopsis:       [patch] lang/otcl -- fix build with Tcl 8.6 + remove limitation on unthreaded version
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gahr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 28 15:40:01 UTC 2012
>Closed-Date:    Wed Aug 29 07:28:44 UTC 2012
>Last-Modified:  Wed Aug 29 07:30:08 UTC 2012
>Originator:     Pietro Cerutti
>Release:        
>Organization:
The FreeBSD Project
>Environment:
>Description:
The patch attached fixes lang/otcl when building against Tcl/Tk 8.6. This new release has made obsolete direct access to the members of Tcl_Interp errorLine and result. Legacy code can define USE_INTERP_ERRORLINE and USE_INTERP_RESULT to directly get to the members.

Moreover, I have removed the limitation on using an unthreaded version of Tk. I have successfully built and run otcl linked against Tcl/Tk 8.6 with threads.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 302796)
+++ Makefile	(working copy)
@@ -19,7 +19,6 @@
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
 
 USE_TK=		82+
-USE_TK_NO_THREADS=	yes
 USE_XORG=	xext
 
 USE_AUTOTOOLS=	autoconf
@@ -37,6 +36,10 @@
 CFLAGS+=	-DHAVE_UNISTD_H
 CONFIGURE_ARGS+=	--with-tcl-ver=${TCL_VER} --with-tk-ver=${TK_VER}
 
+.if ${USE_TCL} > 85
+CFLAGS+=	-DUSE_INTERP_ERRORLINE -DUSE_INTERP_RESULT
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|/usr/X11R6|${LOCALBASE}|g' \
 		-e's|X11/Intrinsic.h|X11/Xlib.h|g' \


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gahr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Aug 28 15:40:19 UTC 2012 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171142 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Aug 28 15:40:23 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171142 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: 5u623l20@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/171142: [patch] lang/otcl -- fix build with Tcl 8.6 + remove limitation on unthreaded version
Date: Tue, 28 Aug 2012 15:40:21 UT

 Maintainer of lang/otcl,
 
 Please note that PR ports/171142 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171142
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Muhammad Moinur Rahman <5u623l20@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/171142: [patch] lang/otcl -- fix build with Tcl 8.6 +
 remove limitation on unthreaded version
Date: Wed, 29 Aug 2012 10:36:42 +0600

 --000e0ce03b2a07ef2804c8601b49
 Content-Type: text/plain; charset=UTF-8
 
 Approved
 
 On Tue, Aug 28, 2012 at 9:40 PM, Edwin Groothuis <edwin@freebsd.org> wrote:
 
 > Maintainer of lang/otcl,
 >
 > Please note that PR ports/171142 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171142
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 
 --000e0ce03b2a07ef2804c8601b49
 Content-Type: text/html; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 <font color=3D"#000000"><font><font face=3D"courier new,monospace">Approved=
 <br></font></font></font><br><div class=3D"gmail_quote">On Tue, Aug 28, 201=
 2 at 9:40 PM, Edwin Groothuis <span dir=3D"ltr">&lt;<a href=3D"mailto:edwin=
 @freebsd.org" target=3D"_blank">edwin@freebsd.org</a>&gt;</span> wrote:<br>
 <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
 x #ccc solid;padding-left:1ex">Maintainer of lang/otcl,<br>
 <br>
 Please note that PR ports/171142 has just been submitted.<br>
 <br>
 If it contains a patch for an upgrade, an enhancement or a bug fix<br>
 you agree on, reply to this email stating that you approve the patch<br>
 and a committer will take care of it.<br>
 <br>
 The full text of the PR can be found at:<br>
 =C2=A0 =C2=A0 <a href=3D"http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports=
 /171142" target=3D"_blank">http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dpor=
 ts/171142</a><br>
 <span class=3D"HOEnZb"><font color=3D"#888888"><br>
 --<br>
 Edwin Groothuis via the GNATS Auto Assign Tool<br>
 edwin@FreeBSD.org<br>
 </font></span></blockquote></div><br>
 
 --000e0ce03b2a07ef2804c8601b49--
State-Changed-From-To: feedback->closed 
State-Changed-By: gahr 
State-Changed-When: Wed Aug 29 07:28:43 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171142 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/171142: commit references a PR
Date: Wed, 29 Aug 2012 07:28:32 +0000 (UTC)

 Author: gahr
 Date: Wed Aug 29 07:28:18 2012
 New Revision: 303320
 URL: http://svn.freebsd.org/changeset/ports/303320
 
 Log:
   - Fix build against Tcl/Tk 8.6
   - Remove limitation on using a non-threaded version of Tcl/Tk
   
   PR:		171142
   Submitted by:	gahr
   Approved by:	Muhammad Moinur Rahman <5u623l20@gmail.com> (maintainer)
 
 Modified:
   head/lang/otcl/Makefile
 
 Modified: head/lang/otcl/Makefile
 ==============================================================================
 --- head/lang/otcl/Makefile	Wed Aug 29 07:02:49 2012	(r303319)
 +++ head/lang/otcl/Makefile	Wed Aug 29 07:28:18 2012	(r303320)
 @@ -19,7 +19,6 @@ LICENSE=	MIT
  WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
  
  USE_TK=		82+
 -USE_TK_NO_THREADS=	yes
  USE_XORG=	xext
  
  USE_AUTOTOOLS=	autoconf
 @@ -37,6 +36,10 @@ PORTDOCS=	${DOCS:S/doc\///}
  CFLAGS+=	-DHAVE_UNISTD_H
  CONFIGURE_ARGS+=	--with-tcl-ver=${TCL_VER} --with-tk-ver=${TK_VER}
  
 +.if ${USE_TCL} > 85
 +CFLAGS+=	-DUSE_INTERP_ERRORLINE -DUSE_INTERP_RESULT
 +.endif
 +
  post-patch:
  	@${REINPLACE_CMD} -e 's|/usr/X11R6|${LOCALBASE}|g' \
  		-e's|X11/Intrinsic.h|X11/Xlib.h|g' \
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
