From nobody@FreeBSD.org  Fri Aug 24 17:25:59 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EAA1E106567D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 24 Aug 2012 17:25:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id BC9498FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 24 Aug 2012 17:25:59 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7OHPx1r097234
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 24 Aug 2012 17:25:59 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q7OHPxA5097206;
	Fri, 24 Aug 2012 17:25:59 GMT
	(envelope-from nobody)
Message-Id: <201208241725.q7OHPxA5097206@red.freebsd.org>
Date: Fri, 24 Aug 2012 17:25:59 GMT
From: Alberto Villa <avilla@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] audio/gstreamer-plugins-flite: unresolvable links to libflite*
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         170997
>Category:       ports
>Synopsis:       [patch] audio/gstreamer-plugins-flite: unresolvable links to libflite*
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-multimedia
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 24 17:30:01 UTC 2012
>Closed-Date:    Fri Aug 24 18:15:36 UTC 2012
>Last-Modified:  Fri Aug 24 18:20:02 UTC 2012
>Originator:     Alberto Villa
>Release:        FreeBSD 10-CURRENT
>Organization:
>Environment:
FreeBSD woodstock.peanuts 10.0-CURRENT FreeBSD 10.0-CURRENT #12 r239638: Fri Aug 24 05:33:08 CEST 2012     root@woodstock.peanuts:/usr/obj/usr/src/sys/HPDV6  amd64
>Description:
gstreamer-plugins-flite has a build dependency on flite assuming that it's linking to flite static library. Instead, libchk reports:

Unresolvable link(s) found in: /usr/local/lib/gstreamer-0.10/libgstflite.so
        libflite.so.1
        libflite_cmulex.so.1
        libflite_cmu_us_kal.so.1
        libflite_usenglish.so.1
>How-To-Repeat:
# pkg install gstreamer-plugins-flite
$ ldd /usr/local/lib/gstreamer-0.10/libgstflite.so | grep flite
>Fix:
The attached patch changes BUILD_DEPENDS to LIB_DEPENDS and bumps PORTREVISION for gstreamer-plugins-flite. It could be changed to make the plugin link to the static library, but I didn't want to dig into GStreamer configure nightmare, so this was my solution.

Patch attached with submission follows:

Index: audio/gstreamer-plugins-flite/Makefile
===================================================================
--- audio/gstreamer-plugins-flite/Makefile	(revision 303048)
+++ audio/gstreamer-plugins-flite/Makefile	(working copy)
@@ -5,7 +5,7 @@
 # $FreeBSD$
 #
 
-PORTREVISION=	0
+PORTREVISION=	1
 CATEGORIES=	audio
 
 COMMENT=	Gstreamer flite run-time speech synthesis engine plugin
Index: multimedia/gstreamer-plugins/Makefile.common
===================================================================
--- multimedia/gstreamer-plugins/Makefile.common	(revision 303048)
+++ multimedia/gstreamer-plugins/Makefile.common	(working copy)
@@ -285,10 +285,10 @@
 			${GST_LIB_DIR}/libgstflac.so
 
 # flite
-gst_flite_BUILD_DEPENDS+=	${LOCALBASE}/lib/libflite.a:${PORTSDIR}/audio/flite
-gst_flite_PLIST_FILES=		${GST_LIB_DIR}/libgstflite.la \
-				${GST_LIB_DIR}/libgstflite.so
-gst_flite_DIST=			bad
+gst_flite_LIB_DEPENDS+=	flite.1:${PORTSDIR}/audio/flite
+gst_flite_PLIST_FILES=	${GST_LIB_DIR}/libgstflite.la \
+			${GST_LIB_DIR}/libgstflite.so
+gst_flite_DIST=		bad
 
 # gconf
 gst_gconf_USE_GNOME+=	gnomeprefix gconf2


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-multimedia 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Aug 24 17:30:19 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170997 
State-Changed-From-To: open->closed 
State-Changed-By: avilla 
State-Changed-When: Fri Aug 24 18:15:35 UTC 2012 
State-Changed-Why:  
Committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170997 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170997: commit references a PR
Date: Fri, 24 Aug 2012 18:13:40 +0000 (UTC)

 Author: avilla
 Date: Fri Aug 24 18:13:28 2012
 New Revision: 303096
 URL: http://svn.freebsd.org/changeset/ports/303096
 
 Log:
   - Add dependency on flite shared library in gstreamer-plugins-flite to
     fix unresolvable links.
   - Bump PORTREVISION.
   
   PR:		170997
   Submitted by:	avilla (me)
   Approved by:	kwm (multimedia)
 
 Modified:
   head/audio/gstreamer-plugins-flite/Makefile
   head/multimedia/gstreamer-plugins/Makefile.common
 
 Modified: head/audio/gstreamer-plugins-flite/Makefile
 ==============================================================================
 --- head/audio/gstreamer-plugins-flite/Makefile	Fri Aug 24 17:16:37 2012	(r303095)
 +++ head/audio/gstreamer-plugins-flite/Makefile	Fri Aug 24 18:13:28 2012	(r303096)
 @@ -5,7 +5,7 @@
  # $FreeBSD$
  #
  
 -PORTREVISION=	0
 +PORTREVISION=	1
  CATEGORIES=	audio
  
  COMMENT=	Gstreamer flite run-time speech synthesis engine plugin
 
 Modified: head/multimedia/gstreamer-plugins/Makefile.common
 ==============================================================================
 --- head/multimedia/gstreamer-plugins/Makefile.common	Fri Aug 24 17:16:37 2012	(r303095)
 +++ head/multimedia/gstreamer-plugins/Makefile.common	Fri Aug 24 18:13:28 2012	(r303096)
 @@ -285,10 +285,10 @@ gst_flac_PLIST_FILES=	${GST_LIB_DIR}/lib
  			${GST_LIB_DIR}/libgstflac.so
  
  # flite
 -gst_flite_BUILD_DEPENDS+=	${LOCALBASE}/lib/libflite.a:${PORTSDIR}/audio/flite
 -gst_flite_PLIST_FILES=		${GST_LIB_DIR}/libgstflite.la \
 -				${GST_LIB_DIR}/libgstflite.so
 -gst_flite_DIST=			bad
 +gst_flite_LIB_DEPENDS+=	flite.1:${PORTSDIR}/audio/flite
 +gst_flite_PLIST_FILES=	${GST_LIB_DIR}/libgstflite.la \
 +			${GST_LIB_DIR}/libgstflite.so
 +gst_flite_DIST=		bad
  
  # gconf
  gst_gconf_USE_GNOME+=	gnomeprefix gconf2
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
