From nobody@FreeBSD.org  Mon Aug 20 22:13:33 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9D98A106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 20 Aug 2012 22:13:33 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8942E8FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 20 Aug 2012 22:13:33 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7KMDX9O005307
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 20 Aug 2012 22:13:33 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q7KMDXMA005306;
	Mon, 20 Aug 2012 22:13:33 GMT
	(envelope-from nobody)
Message-Id: <201208202213.q7KMDXMA005306@red.freebsd.org>
Date: Mon, 20 Aug 2012 22:13:33 GMT
From: Artis Caune <Artis.Caune@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] audio/redshift: fix NLS ports option
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: feld@feld.me

>Number:         170803
>Category:       ports
>Synopsis:       [PATCH] accessibility/redshift: fix NLS ports option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rakuco
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 20 22:20:11 UTC 2012
>Closed-Date:    Sat Aug 25 00:51:02 UTC 2012
>Last-Modified:  Sat Aug 25 01:00:08 UTC 2012
>Originator:     Artis Caune
>Release:        stable/9
>Organization:
>Environment:
FreeBSD freebsd 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE r239148: Fri Aug 10 00:00:00 UTC 2012 root@freebsd:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
There is a typo in Makefile for NLS ports option.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2012-08-21 10:11:40.030181322 +1200
+++ Makefile	2012-08-21 10:12:03.872425519 +1200
@@ -33,7 +33,7 @@
 
 .include <bsd.port.options.mk>
 
-.if ${PORT_OPTIONS:MNLS)
+.if ${PORT_OPTIONS:MNLS}
 USE_GETTEXT=	yes
 CONFIGURE_ARGS+=--with-libiconv-prefix=${LOCALBASE} \
                 --with-libintl-prefix=${LOCALBASE}


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Aug 24 02:34:18 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170803 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: feld@feld.me
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/170803: [PATCH] accessibility/redshift: fix NLS ports option
Date: Fri, 24 Aug 2012 02:34:15 UT

 Maintainer of accessibility/redshift,
 
 Please note that PR ports/170803 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/170803
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Mark Felder <feld@feld.me>
To: bug-followup@freebsd.org, Artis.Caune@gmail.com
Cc:  
Subject: Re: ports/170803: [PATCH] accessibility/redshift: fix NLS ports
 option
Date: Fri, 24 Aug 2012 08:24:01 -0500

 This has to be the most common typo in OptionsNG :-)
 
 Patch accepted!
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Fri Aug 24 14:19:39 UTC 2012 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170803 
Responsible-Changed-From-To: freebsd-ports-bugs->rakuco 
Responsible-Changed-By: rakuco 
Responsible-Changed-When: Sat Aug 25 00:49:27 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170803 
State-Changed-From-To: open->closed 
State-Changed-By: rakuco 
State-Changed-When: Sat Aug 25 00:51:01 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170803 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170803: commit references a PR
Date: Sat, 25 Aug 2012 00:51:05 +0000 (UTC)

 Author: rakuco
 Date: Sat Aug 25 00:50:50 2012
 New Revision: 303105
 URL: http://svn.freebsd.org/changeset/ports/303105
 
 Log:
   Fix typo in the NLS port option.
   
   PR:		ports/170803
   Submitted by:	Artis Caune <artis.caune@gmail.com>
   Approved by:	Mark Felder <feld@feld.me> (maintainer)
 
 Modified:
   head/accessibility/redshift/Makefile
 
 Modified: head/accessibility/redshift/Makefile
 ==============================================================================
 --- head/accessibility/redshift/Makefile	Fri Aug 24 23:40:38 2012	(r303104)
 +++ head/accessibility/redshift/Makefile	Sat Aug 25 00:50:50 2012	(r303105)
 @@ -33,7 +33,7 @@ VIDMODE_DESC=	Support VIDMODE for changi
  
  .include <bsd.port.options.mk>
  
 -.if ${PORT_OPTIONS:MNLS)
 +.if ${PORT_OPTIONS:MNLS}
  USE_GETTEXT=	yes
  CONFIGURE_ARGS+=--with-libiconv-prefix=${LOCALBASE} \
                  --with-libintl-prefix=${LOCALBASE}
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
