From rodrigo@bebik.net  Mon Aug 20 01:48:07 2012
Return-Path: <rodrigo@bebik.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3A14F1065672
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 20 Aug 2012 01:48:07 +0000 (UTC)
	(envelope-from rodrigo@bebik.net)
Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [IPv6:2a01:e0c:1:1599::12])
	by mx1.freebsd.org (Postfix) with ESMTP id 6F5D58FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 20 Aug 2012 01:48:04 +0000 (UTC)
Received: from oldfaithful.bebik.local (unknown [82.227.164.69])
	by smtp3-g21.free.fr (Postfix) with ESMTP id B1C86A60F5
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 20 Aug 2012 03:47:59 +0200 (CEST)
Received: by oldfaithful.bebik.local (Postfix, from userid 1001)
	id 1D9D92934C5; Mon, 20 Aug 2012 03:45:34 +0200 (CEST)
Message-Id: <20120820014534.1D9D92934C5@oldfaithful.bebik.local>
Date: Mon, 20 Aug 2012 03:45:34 +0200 (CEST)
From: Rodrigo OSORIO <rodrigo@bebik.net>
Reply-To: Rodrigo OSORIO <rodrigo@bebik.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: textproc/libmrss fix for php
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         170776
>Category:       ports
>Synopsis:       textproc/libmrss fix for php
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    clsung
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 20 01:50:12 UTC 2012
>Closed-Date:    Wed Dec 05 17:16:38 UTC 2012
>Last-Modified:  Wed Dec 05 17:16:38 UTC 2012
>Originator:     Rodrigo OSORIO
>Release:        FreeBSD 9.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD oldfaithful.bebik.local 9.0-STABLE FreeBSD 9.0-STABLE #2: Thu Jul 5 22:22:11 CEST 2012 root@hodja.bebik.local:/usr/src/obj/usr/src/sys/GENERIC amd64


	
>Description:
	Attached to this PR a patch to fix the broken state of the port. 
	This PR only fix the PHP issue and don't resolve the other warnings reported by portlint.

	This issue seems to be caused by the use of function_entry who seems to be deprecate for
	php 5.4 and later and must be replaced by zend_function_entry. Some forums point this
	URL as an explanation : https://bugs.php.net/bug.php?id=60016
	I'll propagate the fix upstream for the future versions but, imho, the following patch must be 
	commited to unbroke the port.

	
	
>How-To-Repeat:
	
>Fix:

	

--- libmrss.patch begins here ---
diff -ruN libmrss/Makefile libmrss/Makefile
--- libmrss/Makefile	2012-07-26 07:40:22.000000000 +0200
+++ libmrss/Makefile	2012-08-20 03:28:01.000000000 +0200
@@ -7,7 +7,7 @@
 
 PORTNAME=	libmrss
 PORTVERSION=	0.19.2
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	textproc
 MASTER_SITES=	http://www.autistici.org/bakunin/libmrss/
 
@@ -33,7 +33,6 @@
 .include <bsd.port.pre.mk>
 
 .if defined(WITH_PHPMRSS)
-BROKEN=		does not compile
 USE_PHP=	yes
 USE_PHP_BUILD=	yes
 USE_AUTOTOOLS+=	autoconf:env
diff -ruN libmrss/files/patch-phpmrss_php.c libmrss/files/patch-phpmrss_php.c
--- libmrss/files/patch-phpmrss_php.c	1970-01-01 01:00:00.000000000 +0100
+++ libmrss/files/patch-phpmrss_php.c	2012-08-20 03:26:04.000000000 +0200
@@ -0,0 +1,11 @@
+--- phpmrss/php.c	2008-01-25 19:32:24.000000000 +0100
++++ phpmrss/php.c 	2012-08-20 03:10:45.000000000 +0200
+@@ -58,7 +58,7 @@
+ return SUCCESS;
+ }
+ 
+-static function_entry mrss_functions[] = {
++static zend_function_entry mrss_functions[] = {
+   PHP_FE (mrss_parse_url, NULL) 
+   PHP_FE (mrss_parse_url_with_options, NULL) 
+   PHP_FE (mrss_parse_file, NULL) 
--- libmrss.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->clsung 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Aug 20 01:50:23 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170776 

From: Rodrigo OSORIO <rodrigo@bebik.net>
To: bug-followup@FreeBSD.org, rodrigo@bebik.net
Cc:  
Subject: Re: ports/170776: textproc/libmrss fix for php
Date: Mon, 19 Nov 2012 18:48:10 +0100

 Hi,
 
 After a little discussion with bapt@ He suggest me to cut this port,
 a simple libmrss port without php (less dependencies) and libmrss-php
 if you plan to use it with php.
 
 Meanwhile, this PR can be closed without action.
 
 Regards.
 - rodrigo
 
State-Changed-From-To: open->closed 
State-Changed-By: bapt 
State-Changed-When: Wed Dec 5 17:16:37 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170776 
>Unformatted:
