From nemysis@gmx.ch  Sat Aug 18 12:49:55 2012
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1A8951065670
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 18 Aug 2012 12:49:55 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.22])
	by mx1.freebsd.org (Postfix) with SMTP id 2A0E18FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 18 Aug 2012 12:49:53 +0000 (UTC)
Received: (qmail invoked by alias); 18 Aug 2012 12:49:52 -0000
Received: from cpe.r57.logikom.net (EHLO something.email.com) [213.244.239.57]
  by mail.gmx.net (mp070) with SMTP; 18 Aug 2012 14:49:52 +0200
Received: by something.email.com (sSMTP sendmail emulation); Sat, 18 Aug 2012 14:49:51 +0200
Message-Id: <20120818124955.1A8951065670@hub.freebsd.org>
Date: Sat, 18 Aug 2012 14:49:51 +0200
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jgh@FreeBSD.org
Subject: [MAINTAINER] games/nelly: Makefile changed, Port require always DATA
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         170739
>Category:       ports
>Synopsis:       [MAINTAINER] games/nelly: Makefile changed, Port require always DATA
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 18 12:50:09 UTC 2012
>Closed-Date:    Tue Aug 21 06:00:43 UTC 2012
>Last-Modified:  Tue Aug 21 06:00:43 UTC 2012
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC
>Description:

Makefile changed:

Deleted why Port require always DATA

-OPTIONS_DEFINE= DATA
-OPTIONS_DEFAULT= DATA

Here works better NOPORTDATA

-.if ${PORT_OPTIONS:MDATA}
+.if !defined (NOPORTDATA)

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- nelly-1.0_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/games/nelly/Makefile ./Makefile
--- /usr/ports/games/nelly/Makefile	2012-08-10 05:20:10.000000000 +0200
+++ ./Makefile	2012-08-18 14:47:37.000000000 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	nelly
 PORTVERSION=	1.0
+PORTREVISION=	1
 CATEGORIES=	games python
 MASTER_SITES=	http://www.partiallydisassembled.net/nelly/ \
 		http://media.pyweek.org/dl/2/rushed/
@@ -17,9 +18,6 @@
 RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}game>=0:${PORTSDIR}/devel/py-game \
 		${PYTHON_PKGNAMEPREFIX}opengl>=0:${PORTSDIR}/graphics/py-opengl
 
-OPTIONS_DEFINE=	DATA
-OPTIONS_DEFAULT=	DATA
-
 USE_PYTHON_RUN=	yes
 NO_BUILD=	yes
 
@@ -47,7 +45,7 @@
 	${INSTALL_SCRIPT} ${WRKSRC}/*.py ${DATADIR}
 
 # Data
-.if ${PORT_OPTIONS:MDATA}
+.if !defined (NOPORTDATA)
 .  for d in fonts levels textures
 	@(cd ${WRKSRC} && ${COPYTREE_SHARE} ${d} ${DATADIR})
 .  endfor
--- nelly-1.0_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: sunpoet 
Responsible-Changed-When: Sat Aug 18 16:09:04 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170739 
Responsible-Changed-From-To: sunpoet->jgh 
Responsible-Changed-By: sunpoet 
Responsible-Changed-When: Mon Aug 20 11:00:27 UTC 2012 
Responsible-Changed-Why:  
Jason would like to take nemysis's PRs. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170739 

From: nemysis <nemysis@gmx.ch>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170739: [MAINTAINER] games/nelly: Makefile changed, Port
 require always DATA
Date: Mon, 20 Aug 2012 22:43:50 +0200

 --MP_/4Qa6D7oOpZUf.nhcGboptIQ
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 
 --MP_/4Qa6D7oOpZUf.nhcGboptIQ
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=nelly.diff
 
 ===> Generating patch
 ===> Viewing diff with more
 diff -ruN --exclude=CVS /usr/ports/games/nelly/Makefile ./Makefile
 --- /usr/ports/games/nelly/Makefile	2012-08-10 05:20:10.000000000 +0200
 +++ ./Makefile	2012-08-20 22:42:40.000000000 +0200
 @@ -7,6 +7,7 @@
  
  PORTNAME=	nelly
  PORTVERSION=	1.0
 +PORTREVISION=	1
  CATEGORIES=	games python
  MASTER_SITES=	http://www.partiallydisassembled.net/nelly/ \
  		http://media.pyweek.org/dl/2/rushed/
 @@ -17,9 +18,6 @@
  RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}game>=0:${PORTSDIR}/devel/py-game \
  		${PYTHON_PKGNAMEPREFIX}opengl>=0:${PORTSDIR}/graphics/py-opengl
  
 -OPTIONS_DEFINE=	DATA
 -OPTIONS_DEFAULT=	DATA
 -
  USE_PYTHON_RUN=	yes
  NO_BUILD=	yes
  
 @@ -47,11 +45,9 @@
  	${INSTALL_SCRIPT} ${WRKSRC}/*.py ${DATADIR}
  
  # Data
 -.if ${PORT_OPTIONS:MDATA}
  .  for d in fonts levels textures
  	@(cd ${WRKSRC} && ${COPYTREE_SHARE} ${d} ${DATADIR})
  .  endfor
 -.endif
  
  # Pixmaps
  	${INSTALL_DATA} ${WRKSRC}/textures/menu.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
 ===> Done
 
 --MP_/4Qa6D7oOpZUf.nhcGboptIQ--
State-Changed-From-To: open->closed 
State-Changed-By: jgh 
State-Changed-When: Tue Aug 21 06:00:42 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170739 
>Unformatted:
