From nemysis@gmx.ch  Fri Aug 17 23:58:04 2012
Return-Path: <nemysis@gmx.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EB34F106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Aug 2012 23:58:04 +0000 (UTC)
	(envelope-from nemysis@gmx.ch)
Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.23])
	by mx1.freebsd.org (Postfix) with SMTP id 57FCE8FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Aug 2012 23:58:04 +0000 (UTC)
Received: (qmail invoked by alias); 17 Aug 2012 23:58:01 -0000
Received: from cpe.r57.logikom.net (EHLO something.email.com) [213.244.239.57]
  by mail.gmx.net (mp027) with SMTP; 18 Aug 2012 01:58:01 +0200
Received: by something.email.com (sSMTP sendmail emulation); Sat, 18 Aug 2012 01:57:59 +0200
Message-Id: <20120817235804.EB34F106566C@hub.freebsd.org>
Date: Sat, 18 Aug 2012 01:57:59 +0200
From: nemysis <nemysis@gmx.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] games/blockrage: Makefile changed, Port require always DATA
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         170718
>Category:       ports
>Synopsis:       [MAINTAINER] games/blockrage: Makefile changed, Port require always DATA
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 18 00:00:19 UTC 2012
>Closed-Date:    Tue Aug 21 05:19:10 UTC 2012
>Last-Modified:  Tue Aug 21 05:20:09 UTC 2012
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC
>Description:

Makefile changed:

Deleted why Port require always DATA

-OPTIONS_DEFINE= DATA
-OPTIONS_DEFAULT=        DATA

Here works better NOPORTDATA

-.if ${PORT_OPTIONS:MDATA}
+.if !defined (NOPORTDATA)


Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- blockrage-0.2.3_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/games/blockrage/Makefile ./Makefile
--- /usr/ports/games/blockrage/Makefile	2012-08-09 14:01:19.000000000 +0200
+++ ./Makefile	2012-08-18 01:46:46.000000000 +0200
@@ -12,13 +12,10 @@
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTVERSION}
 
 MAINTAINER=	nemysis@gmx.ch
-COMMENT=	Block Rage is falling blocks game with a 2-player hotseat mode
+COMMENT=	A falling blocks game with a 2-player hotseat mode
 
 LICENSE=	GPLv2
 
-OPTIONS_DEFINE=	DATA
-OPTIONS_DEFAULT=	DATA
-
 GNU_CONFIGURE=	yes
 ALL_TARGET=	${PORTNAME}
 USE_SDL=	sdl image mixer
@@ -47,13 +44,13 @@
 	${INSTALL_MAN} ${WRKSRC}/${MAN6} ${MAN6PREFIX}/man/man6
 
 # Data
-.if ${PORT_OPTIONS:MDATA}
+.if !defined (NOPORTDATA)
 .  for d in data blockrage-fhs.rc blockrage.cfg blockrage.rc
 	@(cd ${WRKSRC} && ${COPYTREE_SHARE} ${d} ${DATADIR})
 .  endfor
 .endif
 
-# Documentations
+# Documentation
 .if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
 .  for f in ${PORTDOCS}
--- blockrage-0.2.3_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jgh 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Sat Aug 18 05:48:41 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170718 

From: nemysis <nemysis@gmx.ch>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170718: [MAINTAINER] games/blockrage: Makefile changed,
 Port require always DATA
Date: Mon, 20 Aug 2012 21:48:54 +0200

 --MP_/fUU=kUT5EhN50_KB=UBd2Gk
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 
 --MP_/fUU=kUT5EhN50_KB=UBd2Gk
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=blockrage.diff
 
 ===> Generating patch
 ===> Viewing diff with more
 diff -ruN --exclude=CVS /usr/ports/games/blockrage/Makefile ./Makefile
 --- /usr/ports/games/blockrage/Makefile	2012-08-09 14:01:19.000000000 +0200
 +++ ./Makefile	2012-08-20 21:40:31.000000000 +0200
 @@ -12,13 +12,10 @@
  MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTVERSION}
  
  MAINTAINER=	nemysis@gmx.ch
 -COMMENT=	Block Rage is falling blocks game with a 2-player hotseat mode
 +COMMENT=	A falling blocks game with a 2-player hotseat mode
  
  LICENSE=	GPLv2
  
 -OPTIONS_DEFINE=	DATA
 -OPTIONS_DEFAULT=	DATA
 -
  GNU_CONFIGURE=	yes
  ALL_TARGET=	${PORTNAME}
  USE_SDL=	sdl image mixer
 @@ -47,13 +44,11 @@
  	${INSTALL_MAN} ${WRKSRC}/${MAN6} ${MAN6PREFIX}/man/man6
  
  # Data
 -.if ${PORT_OPTIONS:MDATA}
  .  for d in data blockrage-fhs.rc blockrage.cfg blockrage.rc
  	@(cd ${WRKSRC} && ${COPYTREE_SHARE} ${d} ${DATADIR})
  .  endfor
 -.endif
  
 -# Documentations
 +# Documentation
  .if ${PORT_OPTIONS:MDOCS}
  	${MKDIR} ${DOCSDIR}
  .  for f in ${PORTDOCS}
 ===> Done
 
 --MP_/fUU=kUT5EhN50_KB=UBd2Gk--
State-Changed-From-To: open->closed 
State-Changed-By: jgh 
State-Changed-When: Tue Aug 21 05:19:09 UTC 2012 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170718 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170718: commit references a PR
Date: Tue, 21 Aug 2012 05:19:03 +0000 (UTC)

 Author: jgh
 Date: Tue Aug 21 05:18:53 2012
 New Revision: 302841
 URL: http://svn.freebsd.org/changeset/ports/302841
 
 Log:
   - port requires data
   
   PR:	170718
   Submitted by:	maintainer, nemysis@gmx.ch
 
 Modified:
   head/games/blockrage/Makefile
 
 Modified: head/games/blockrage/Makefile
 ==============================================================================
 --- head/games/blockrage/Makefile	Tue Aug 21 04:56:41 2012	(r302840)
 +++ head/games/blockrage/Makefile	Tue Aug 21 05:18:53 2012	(r302841)
 @@ -7,18 +7,15 @@
  
  PORTNAME=	blockrage
  PORTVERSION=	0.2.3
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	games
  MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTVERSION}
  
  MAINTAINER=	nemysis@gmx.ch
 -COMMENT=	Block Rage is falling blocks game with a 2-player hotseat mode
 +COMMENT=	Falling blocks game with 2-player hotseat mode
  
  LICENSE=	GPLv2
  
 -OPTIONS_DEFINE=	DATA
 -OPTIONS_DEFAULT=	DATA
 -
  GNU_CONFIGURE=	yes
  ALL_TARGET=	${PORTNAME}
  USE_SDL=	sdl image mixer
 @@ -47,13 +44,11 @@ post-install:
  	${INSTALL_MAN} ${WRKSRC}/${MAN6} ${MAN6PREFIX}/man/man6
  
  # Data
 -.if ${PORT_OPTIONS:MDATA}
  .  for d in data blockrage-fhs.rc blockrage.cfg blockrage.rc
  	@(cd ${WRKSRC} && ${COPYTREE_SHARE} ${d} ${DATADIR})
  .  endfor
 -.endif
  
 -# Documentations
 +# Documentation
  .if ${PORT_OPTIONS:MDOCS}
  	${MKDIR} ${DOCSDIR}
  .  for f in ${PORTDOCS}
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
