From nobody@FreeBSD.org  Fri Aug 17 06:20:15 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 333C2106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 17 Aug 2012 06:20:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 1DF158FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 17 Aug 2012 06:20:15 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7H6KEYd053782
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 17 Aug 2012 06:20:14 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q7H6KEDR053781;
	Fri, 17 Aug 2012 06:20:14 GMT
	(envelope-from nobody)
Message-Id: <201208170620.q7H6KEDR053781@red.freebsd.org>
Date: Fri, 17 Aug 2012 06:20:14 GMT
From: Loganaden Velvindron <logan@afrinic.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Incomplete perl module dependency causes password not to update correctly
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         170692
>Category:       ports
>Synopsis:       sysutils/usermin: Incomplete perl module dependency causes password not to update correctly
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    olgeni
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 17 06:30:09 UTC 2012
>Closed-Date:    Fri Aug 17 12:06:39 UTC 2012
>Last-Modified:  Fri Aug 17 12:10:11 UTC 2012
>Originator:     Loganaden Velvindron
>Release:        9.0
>Organization:
Afrinic Ltd
>Environment:
FreeBSD ops01.mu.afrinic.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Daniel Shaw (daniel@afrinic.net) discovered that usermin couldn't find a dependency to change the password, in change password menu. The dependancy is p5-IO-Tty which is called by changepasswd.cgi.

sub pty_process_exec
{
local ($cmd, $uid, $gid) = @_;
if (&is_readonly_mode()) {
        # When in readonly mode, don't run the command
        $cmd = "/bin/true";
        }
&webmin_debug_log('CMD', "cmd=$cmd uid=$uid gid=$gid")
        if ($gconfig{'debug_what_cmd'});

eval "use IO::Pty";
if (!$@) {
        # Use the IO::Pty perl module if installed
        local $ptyfh = new IO::Pty;
        if (!$ptyfh) {


pty_process_exec is later called in changepasswd.cgi:

                ($fh, $fpid) = &proc::pty_process_exec(
                                        $passwd_cmd, $uinfo[2], $uinfo[3]);
>How-To-Repeat:
Go to change password, and change an existing user password. Nothing is displayed on the web page & the password isn't updated silently either.
>Fix:
A workaround is to install p5-IO-Tty manually, and then the password is changed correctly and the webpage confirms the change.

Patch attached with submission follows:

--- Makefile.orig	2012-08-17 10:02:14.000000000 +0400
+++ Makefile	2012-08-17 09:57:36.000000000 +0400
@@ -19,6 +19,7 @@ MAINTAINER=	olgeni@FreeBSD.org
 COMMENT=	Web-based interface for performing some user tasks
 
 RUN_DEPENDS=	p5-Net-SSLeay>=0:${PORTSDIR}/security/p5-Net-SSLeay \
+		p5-IO-Tty>=0:${PORTSDIR}/devel/p5-IO-Tty \
 		p5-Authen-PAM>=0:${PORTSDIR}/security/p5-Authen-PAM
 
 FETCH_CMD?=	/usr/bin/fetch -pRr


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->olgeni 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Aug 17 09:51:22 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170692 
State-Changed-From-To: open->closed 
State-Changed-By: olgeni 
State-Changed-When: Fri Aug 17 12:06:28 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170692 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170692: commit references a PR
Date: Fri, 17 Aug 2012 12:05:55 +0000 (UTC)

 Author: olgeni
 Date: Fri Aug 17 12:05:45 2012
 New Revision: 302678
 URL: http://svn.freebsd.org/changeset/ports/302678
 
 Log:
   Add missing dependency on p5-IO-Tty.
   
   PR:		ports/170692
   Submitted by:	Loganaden Velvindron <logan afrinic.net>
 
 Modified:
   head/sysutils/usermin/Makefile   (contents, props changed)
 
 Modified: head/sysutils/usermin/Makefile
 ==============================================================================
 --- head/sysutils/usermin/Makefile	Fri Aug 17 11:25:05 2012	(r302677)
 +++ head/sysutils/usermin/Makefile	Fri Aug 17 12:05:45 2012	(r302678)
 @@ -7,6 +7,7 @@
  
  PORTNAME=	usermin
  PORTVERSION=	1.510
 +PORTREVISION=	1
  CATEGORIES=	sysutils
  MASTER_SITES=	http://www.webmin.com/uupdates/:up \
  		SF/webadmin/${PORTNAME}/${PORTVERSION}:sf \
 @@ -19,6 +20,7 @@ MAINTAINER=	olgeni@FreeBSD.org
  COMMENT=	Web-based interface for performing some user tasks
  
  RUN_DEPENDS=	p5-Net-SSLeay>=0:${PORTSDIR}/security/p5-Net-SSLeay \
 +		p5-IO-Tty>=0:${PORTSDIR}/devel/p5-IO-Tty \
  		p5-Authen-PAM>=0:${PORTSDIR}/security/p5-Authen-PAM
  
  FETCH_CMD?=	/usr/bin/fetch -pRr
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170692: commit references a PR
Date: Fri, 17 Aug 2012 12:06:30 +0000 (UTC)

 Author: olgeni
 Date: Fri Aug 17 12:06:21 2012
 New Revision: 302679
 URL: http://svn.freebsd.org/changeset/ports/302679
 
 Log:
   Add missing dependency on p5-IO-Tty.
   
   PR:		ports/170692
   Submitted by:	Loganaden Velvindron <logan afrinic.net>
 
 Modified:
   head/sysutils/webmin/Makefile   (contents, props changed)
 
 Modified: head/sysutils/webmin/Makefile
 ==============================================================================
 --- head/sysutils/webmin/Makefile	Fri Aug 17 12:05:45 2012	(r302678)
 +++ head/sysutils/webmin/Makefile	Fri Aug 17 12:06:21 2012	(r302679)
 @@ -7,6 +7,7 @@
  
  PORTNAME=	webmin
  PORTVERSION=	1.590
 +PORTREVISION=	1
  CATEGORIES=	sysutils
  MASTER_SITES=	http://download.webmin.com/updates/:up \
  		SF/webadmin/${PORTNAME}/${PORTVERSION}:sf \
 @@ -19,6 +20,7 @@ MAINTAINER=	olgeni@FreeBSD.org
  COMMENT=	Web-based interface for system administration for Unix
  
  RUN_DEPENDS=	p5-Net-SSLeay>=0:${PORTSDIR}/security/p5-Net-SSLeay \
 +		p5-IO-Tty>=0:${PORTSDIR}/devel/p5-IO-Tty \
  		p5-Authen-PAM>=0:${PORTSDIR}/security/p5-Authen-PAM
  
  USE_PERL5=	yes
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
