From yuri.pankov@gmail.com  Mon Aug  6 21:24:26 2012
Return-Path: <yuri.pankov@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 77268106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  6 Aug 2012 21:24:26 +0000 (UTC)
	(envelope-from yuri.pankov@gmail.com)
Received: from polaris.xvoid.org (polaris.xvoid.org [IPv6:2001:470:28:4ba:20c:29ff:fe11:9beb])
	by mx1.freebsd.org (Postfix) with ESMTP id 1B9FB8FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  6 Aug 2012 21:24:25 +0000 (UTC)
Received: from phoenix.xvoid.org (phoenix.xvoid.org [IPv6:2001:470:28:4ba:20c:29ff:fea2:c22e])
	by polaris.xvoid.org (8.14.5/8.14.5) with ESMTP id q76LONIa086401;
	Tue, 7 Aug 2012 01:24:23 +0400 (MSK)
	(envelope-from yuri.pankov@gmail.com)
Received: from phoenix.xvoid.org (localhost [IPv6:::1])
	by phoenix.xvoid.org (8.14.5/8.14.5) with ESMTP id q76LONRK064322;
	Tue, 7 Aug 2012 01:24:23 +0400 (MSK)
	(envelope-from yuri.pankov@gmail.com)
Received: (from yuri@localhost)
	by phoenix.xvoid.org (8.14.5/8.14.5/Submit) id q76LJAZo064239;
	Tue, 7 Aug 2012 01:19:10 +0400 (MSK)
	(envelope-from yuri.pankov@gmail.com)
Message-Id: <201208062119.q76LJAZo064239@phoenix.xvoid.org>
Date: Tue, 7 Aug 2012 01:19:10 +0400 (MSK)
From: Yuri Pankov <yuri.pankov@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: luca.pizzamiglio@gmail.com
Subject: [PATCH] devel/gdb: Really depend on readline from ports
X-Send-Pr-Version: 3.113
X-GNATS-Notify: luca.pizzamiglio@gmail.com

>Number:         170429
>Category:       ports
>Synopsis:       [PATCH] devel/gdb: Really depend on readline from ports
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bdrewery
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 06 21:30:02 UTC 2012
>Closed-Date:    Thu Aug 09 16:47:37 UTC 2012
>Last-Modified:  Thu Aug  9 16:50:01 UTC 2012
>Originator:     Yuri Pankov
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD phoenix.xvoid.org 10.0-CURRENT FreeBSD 10.0-CURRENT #2 r239046: Sun Aug  5 10:58:12
>Description:
Removing ABI version number from LIB_DEPENDS to pet portlint broke gdb build when readline from ports isn't installed before gdb build.

Port maintainer (luca.pizzamiglio@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
pkg_delete -x readline
try to build devel/gdb
>Fix:

--- gdb-7.4.1_4.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/gdb/Makefile,v
retrieving revision 1.21
diff -u -r1.21 Makefile
--- Makefile	3 Aug 2012 02:00:58 -0000	1.21
+++ Makefile	6 Aug 2012 21:13:40 -0000
@@ -40,7 +40,7 @@
 
 # Forcing to use the readline from ports (readline in FreeBSD world is not
 # compatible anymore).
-LIB_DEPENDS+=	readline:${PORTSDIR}/devel/readline
+LIB_DEPENDS+=	readline.6:${PORTSDIR}/devel/readline
 CFLAGS+=	-isystem ${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 
--- gdb-7.4.1_4.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Aug 6 21:30:26 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170429 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: luca.pizzamiglio@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/170429: [PATCH] devel/gdb: Really depend on readline from ports
Date: Mon, 6 Aug 2012 21:30:24 UT

 Maintainer of devel/gdb,
 
 Please note that PR ports/170429 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/170429
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->bdrewery 
Responsible-Changed-By: bdrewery 
Responsible-Changed-When: Mon Aug 6 22:14:02 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170429 

From: Bryan Drewery <bdrewery@FreeBSD.org>
To: bug-followup@FreeBSD.org, yuri.pankov@gmail.com
Cc: luca.pizzamiglio@gmail.com
Subject: Re: ports/170429: [PATCH] devel/gdb: Really depend on readline from
 ports
Date: Mon, 06 Aug 2012 17:14:19 -0500

 Using versioned LIB_DEPENDS is discouraged. The problem could resurface
 again if base has readline.6 as well.
 
 This will ensure that the *package* called readline is installed, thus
 ensuring the port version:
 
 LIB_DEPENDS+= readline>0:${PORTSDIR}/devel/readline
 
 -- 
 Regards,
 Bryan Drewery
 bdrewery@freenode/EFNet
 

From: Yuri Pankov <yuri.pankov@gmail.com>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, luca.pizzamiglio@gmail.com
Subject: Re: ports/170429: [PATCH] devel/gdb: Really depend on readline from
 ports
Date: Tue, 07 Aug 2012 02:22:42 +0400

 On Mon, 06 Aug 2012 17:14:19 -0500, Bryan Drewery wrote:
 > Using versioned LIB_DEPENDS is discouraged. The problem could resurface
 > again if base has readline.6 as well.
 >
 > This will ensure that the *package* called readline is installed, thus
 > ensuring the port version:
 >
 > LIB_DEPENDS+= readline>0:${PORTSDIR}/devel/readline
 
 phoenix:yuri:~/ports/devel/gdb$ grep LIB_DEPENDS Makefile
 LIB_DEPENDS+=   readline>0:${PORTSDIR}/devel/readline
 LIB_DEPENDS+=   expat:${PORTSDIR}/textproc/expat2
 phoenix:yuri:~/ports/devel/gdb$ sudo make depends
 Syntax error: redirection unexpected
 *** [lib-depends] Error code 2
 
 Stop in /home/yuri/ports/devel/gdb.
 

From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Yuri Pankov <yuri.pankov@gmail.com>
Cc: bug-followup@FreeBSD.org, luca.pizzamiglio@gmail.com
Subject: Re: ports/170429: [PATCH] devel/gdb: Really depend on readline from
 ports
Date: Mon, 06 Aug 2012 17:30:15 -0500

 On 8/6/2012 5:22 PM, Yuri Pankov wrote:
 > On Mon, 06 Aug 2012 17:14:19 -0500, Bryan Drewery wrote:
 >> Using versioned LIB_DEPENDS is discouraged. The problem could resurface
 >> again if base has readline.6 as well.
 >>
 >> This will ensure that the *package* called readline is installed, thus
 >> ensuring the port version:
 >>
 >> LIB_DEPENDS+= readline>0:${PORTSDIR}/devel/readline
 > 
 > phoenix:yuri:~/ports/devel/gdb$ grep LIB_DEPENDS Makefile
 > LIB_DEPENDS+=   readline>0:${PORTSDIR}/devel/readline
 > LIB_DEPENDS+=   expat:${PORTSDIR}/textproc/expat2
 > phoenix:yuri:~/ports/devel/gdb$ sudo make depends
 > Syntax error: redirection unexpected
 > *** [lib-depends] Error code 2
 > 
 > Stop in /home/yuri/ports/devel/gdb.
 
 You can use BUILD_DEPENDS/RUN_DEPENDS then.
 

From: Yuri Pankov <yuri.pankov@gmail.com>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, luca.pizzamiglio@gmail.com
Subject: Re: ports/170429: [PATCH] devel/gdb: Really depend on readline from
 ports
Date: Tue, 07 Aug 2012 02:39:31 +0400

 This is a multi-part message in MIME format.
 --------------030505060400030701090800
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 7bit
 
 On Mon, 06 Aug 2012 17:30:15 -0500, Bryan Drewery wrote:
 > On 8/6/2012 5:22 PM, Yuri Pankov wrote:
 >> On Mon, 06 Aug 2012 17:14:19 -0500, Bryan Drewery wrote:
 >>> Using versioned LIB_DEPENDS is discouraged. The problem could resurface
 >>> again if base has readline.6 as well.
 >>>
 >>> This will ensure that the *package* called readline is installed, thus
 >>> ensuring the port version:
 >>>
 >>> LIB_DEPENDS+= readline>0:${PORTSDIR}/devel/readline
 >>
 >> phoenix:yuri:~/ports/devel/gdb$ grep LIB_DEPENDS Makefile
 >> LIB_DEPENDS+=   readline>0:${PORTSDIR}/devel/readline
 >> LIB_DEPENDS+=   expat:${PORTSDIR}/textproc/expat2
 >> phoenix:yuri:~/ports/devel/gdb$ sudo make depends
 >> Syntax error: redirection unexpected
 >> *** [lib-depends] Error code 2
 >>
 >> Stop in /home/yuri/ports/devel/gdb.
 >
 > You can use BUILD_DEPENDS/RUN_DEPENDS then.
 
 Thanks, that did the trick.
 
 --------------030505060400030701090800
 Content-Type: text/plain; charset=windows-1251;
  name="gdb.diff"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="gdb.diff"
 
 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIE1ha2VmaWxlCShyZXZpc2lvbiAz
 MDIyMTUpCisrKyBNYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtNyw3ICs3LDcgQEAKIAog
 UE9SVE5BTUU9CWdkYgogUE9SVFZFUlNJT049CTcuNC4xCi1QT1JUUkVWSVNJT049CTQKK1BP
 UlRSRVZJU0lPTj0JNQogQ0FURUdPUklFUz0JZGV2ZWwKIE1BU1RFUl9TSVRFUz0JR05VCiAK
 QEAgLTQwLDcgKzQwLDggQEAKIAogIyBGb3JjaW5nIHRvIHVzZSB0aGUgcmVhZGxpbmUgZnJv
 bSBwb3J0cyAocmVhZGxpbmUgaW4gRnJlZUJTRCB3b3JsZCBpcyBub3QKICMgY29tcGF0aWJs
 ZSBhbnltb3JlKS4KLUxJQl9ERVBFTkRTKz0JcmVhZGxpbmU6JHtQT1JUU0RJUn0vZGV2ZWwv
 cmVhZGxpbmUKK0JVSUxEX0RFUEVORFMrPQlyZWFkbGluZT4wOiR7UE9SVFNESVJ9L2RldmVs
 L3JlYWRsaW5lCitSVU5fREVQRU5EUys9CXJlYWRsaW5lPjA6JHtQT1JUU0RJUn0vZGV2ZWwv
 cmVhZGxpbmUKIENGTEFHUys9CS1pc3lzdGVtICR7TE9DQUxCQVNFfS9pbmNsdWRlCiBMREZM
 QUdTKz0JLUwke0xPQ0FMQkFTRX0vbGliCiAK
 --------------030505060400030701090800--

From: Luca Pizzamiglio <luca.pizzamiglio@gmail.com>
To: bug-followup@freebsd.org, yuri.pankov@gmail.com
Cc:  
Subject: Re: ports/170429: [PATCH] devel/gdb: Really depend on readline from ports
Date: Tue, 7 Aug 2012 15:03:28 +0200

 Hi guys,
 I would like to find a definitive solution about that and maybe the
 last patch submitted could fix this problem.
 
 libreadline provided by FreeBSD is not compatible anymore with gdb.
 Originally I forced the dependency of readline using the line:
 LIB_DEPENDS+=      readline.6:${PORTSDIR}/devel/readline
 
 A commiter changed it to:
 LIB_DEPENDS+=      readline:${PORTSDIR}/devel/readline
 
 I tested this change on redports (using 7,8,9 and current FreeBSD
 backend), that is a clean system, without packages installed, and
 readline dependency is always correctly detected and solved.
 Yuri has a problem to detect this dependency, but I don't understand why.
 
 BTW, the behavior should be:
 << hey, ignore system libreadline, I want the port's one! >>
 
 AFAIK, FreeBSD 8 has libreadline.so.8 and FreeBSD 7 has libreadline.so.7.
 Ports readline installs libreadline.so.6, so
 
 LIB_DEPENDS+=      readline.6:${PORTSDIR}/devel/readline
 
 was the not 100% clean solution adopted.
 
 This new syntax:
 BUILD_DEPENDS+=    readline>0:${PORTSDIR}/devel/readline
 RUN_DEPENDS+= readline>0:${PORTSDIR}/devel/readline
 
 is not documented on the Porter's Handbook and I didn't know it, but
 it does what I want, so it could be the 100% clean solution I was
 looking for.
 I'd wait redports build report to answer, but it's taking too much
 time (loooong queue).
 So I definitively approve this patch, thanks for that.
 I guess that no portrevision bumping is required, people don't need to
 recompile gdb if it's already work :)
 
 Thanks again
State-Changed-From-To: feedback->open 
State-Changed-By: bdrewery 
State-Changed-When: Wed Aug 8 14:41:32 UTC 2012 
State-Changed-Why:  
Maintainer feedback received. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170429 
State-Changed-From-To: open->closed 
State-Changed-By: bdrewery 
State-Changed-When: Thu Aug 9 16:47:35 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170429 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170429: commit references a PR
Date: Thu,  9 Aug 2012 16:47:42 +0000 (UTC)

 Author: bdrewery
 Date: Thu Aug  9 16:47:32 2012
 New Revision: 302345
 URL: http://svn.freebsd.org/changeset/ports/302345
 
 Log:
   - Restore readline.6 library dependency as the port only
     works with that shlib version.
   
   PR:		ports/170429
   Submitted by:	Yuri Pankov <yuri.pankov@gmail.com>
   Approved by:	Luca Pizzamiglio <luca.pizzamiglio@gmail.com (maintainer)
   Approved by:	eadler (mentor)
 
 Modified:
   head/devel/gdb/Makefile
 
 Modified: head/devel/gdb/Makefile
 ==============================================================================
 --- head/devel/gdb/Makefile	Thu Aug  9 15:43:08 2012	(r302344)
 +++ head/devel/gdb/Makefile	Thu Aug  9 16:47:32 2012	(r302345)
 @@ -38,9 +38,9 @@ MAN1=	gdb${VER}.1
  
  ONLY_FOR_ARCHS=	i386 amd64	# untested elsewhere, might work
  
 -# Forcing to use the readline from ports (readline in FreeBSD world is not
 -# compatible anymore).
 -LIB_DEPENDS+=	readline:${PORTSDIR}/devel/readline
 +# Forcing to use readline.6 from ports (newer readline in FreeBSD world is not
 +# compatible anymore). Please ignore portlint here.
 +LIB_DEPENDS+=	readline.6:${PORTSDIR}/devel/readline
  CFLAGS+=	-isystem ${LOCALBASE}/include
  LDFLAGS+=	-L${LOCALBASE}/lib
  
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
