From jbeich@tormail.org  Mon Aug  6 06:49:59 2012
Return-Path: <jbeich@tormail.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BDA6C106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  6 Aug 2012 06:49:59 +0000 (UTC)
	(envelope-from jbeich@tormail.org)
Received: from server4.allsitecontrol.com (server4.allsitecontrol.com [198.136.50.18])
	by mx1.freebsd.org (Postfix) with ESMTP id 8325C8FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  6 Aug 2012 06:49:59 +0000 (UTC)
Received: from tor19.anonymizer.ccc.de ([31.172.30.2]:34137 helo=internal.tormail.org)
	by server4.allsitecontrol.com with esmtpsa (TLSv1:RC4-SHA:128)
	(Exim 4.77)
	(envelope-from <jbeich@tormail.org>)
	id 1SyH8T-001Blj-TJ
	for FreeBSD-gnats-submit@freebsd.org; Mon, 06 Aug 2012 02:49:55 -0400
Received: from jbeich by internal.tormail.org with local (Exim 4.63)
	(envelope-from <jbeich@tormail.org>)
	id 1SyH7K-00044K-D3
	for FreeBSD-gnats-submit@freebsd.org; Mon, 06 Aug 2012 06:48:43 +0000
Message-Id: <1SyH7K-00044K-D3@internal.tormail.org>
Date: Mon, 06 Aug 2012 03:49:08 -0300
From: Jan Beich <jbeich@tormail.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] audio/oss: implicit declaration of 'device_set_desc'

>Number:         170406
>Category:       ports
>Synopsis:       [patch] audio/oss: implicit declaration of 'device_set_desc'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    stefan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 06 07:00:06 UTC 2012
>Closed-Date:    Sun May 26 12:30:25 UTC 2013
>Last-Modified:  Sun May 26 12:30:25 UTC 2013
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
CFLAGS += -Werror=implicit-function-declaration # for crash safety
>Description:
>How-To-Repeat:
$ make CC=clang
[...]
os_freebsd.c:236:5: warning: implicit declaration of function 'device_set_desc' is invalid in C99 [-Wimplicit-function-declaration]
    device_set_desc (osdev->dip, name);
    ^
1 warning generated.
>Fix:
--- clang.diff begins here ---
Index: audio/oss/files/patch-kernel-OS-FreeBSD-os_freebsd.c
===================================================================
--- audio/oss/files/patch-kernel-OS-FreeBSD-os_freebsd.c	(revision 301674)
+++ audio/oss/files/patch-kernel-OS-FreeBSD-os_freebsd.c	(working copy)
@@ -1,10 +1,11 @@
 --- kernel/OS/FreeBSD/os_freebsd.c	2012-02-02 17:46:03.000000000 -0500
 +++ kernel/OS/FreeBSD/os_freebsd.c	2012-02-20 12:58:46.000000000 -0500
-@@ -16,6 +16,7 @@
+@@ -16,6 +16,8 @@
  #include "midi_core.h"
  #include <oss_pci.h>
  #include <sys/conf.h>
 +#include <sys/module.h>
++#include <sys/bus.h>
  #include <sys/proc.h>
  #include <sys/sx.h>
  #include <sys/mman.h>
Index: audio/oss/Makefile
===================================================================
--- audio/oss/Makefile	(revision 301674)
+++ audio/oss/Makefile	(working copy)
@@ -91,6 +91,10 @@ do-configure:
 	(cd ${WRKSRC} && \
 	    ${SETENV} ${CONFIGURE_ENV} ${PATCH_WRKSRC}/configure)
 
+post-configure:
+	${TOUCH} ${WRKSRC}/include/device_if.h
+	${TOUCH} ${WRKSRC}/include/bus_if.h
+
 do-install:
 	${INSTALL_PROGRAM} ${PROTO_BINDIR}/* ${PREFIX}/bin/
 # @${ECHO_CMD} "OSSLIBDIR=${PREFIX}/lib/oss" > ${PROTO_ETCDIR}/oss.conf
--- clang.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jkim 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Aug 6 07:00:35 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170406 

From: Jan Beich <jbeich@tormail.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/170406: [patch] audio/oss: implicit declaration of 'device_set_desc'
Date: Wed, 10 Oct 2012 13:18:44 -1100

 --=-=-=
 Content-Type: text/plain
 
 Fixing conflict with 4.2.b2007.
 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: attachment; filename=clang.diff
 
 Index: audio/oss/Makefile
 ===================================================================
 --- audio/oss/Makefile	(revision 305693)
 +++ audio/oss/Makefile	(working copy)
 @@ -90,6 +92,10 @@ do-configure:
  	(cd ${WRKSRC} && \
  	    ${SETENV} ${CONFIGURE_ENV} ${PATCH_WRKSRC}/configure)
  
 +post-configure:
 +	${TOUCH} ${WRKSRC}/include/device_if.h
 +	${TOUCH} ${WRKSRC}/include/bus_if.h
 +
  do-install:
  	${INSTALL_PROGRAM} ${PROTO_BINDIR}/* ${PREFIX}/bin/
  # @${ECHO_CMD} "OSSLIBDIR=${PREFIX}/lib/oss" > ${PROTO_ETCDIR}/oss.conf
 Index: audio/oss/files/patch-kernel-OS-FreeBSD-os_freebsd.c
 ===================================================================
 --- audio/oss/files/patch-kernel-OS-FreeBSD-os_freebsd.c	(revision 0)
 +++ audio/oss/files/patch-kernel-OS-FreeBSD-os_freebsd.c	(working copy)
 @@ -0,0 +1,10 @@
 +--- kernel/OS/FreeBSD/os_freebsd.c~
 ++++ kernel/OS/FreeBSD/os_freebsd.c
 +@@ -17,6 +17,7 @@
 + #include <oss_pci.h>
 + #include <sys/conf.h>
 + #include <sys/module.h>
 ++#include <sys/bus.h>
 + #include <sys/proc.h>
 + #include <sys/sx.h>
 + #include <sys/mman.h>
 
 --=-=-=--
Responsible-Changed-From-To: jkim->freebsd-ports-bugs 
Responsible-Changed-By: jkim 
Responsible-Changed-When: Tue Mar 19 19:02:08 UTC 2013 
Responsible-Changed-Why:  
I do not maintain this port any more. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170406 
Responsible-Changed-From-To: freebsd-ports-bugs->stefan 
Responsible-Changed-By: stefan 
Responsible-Changed-When: Thu May 2 20:57:08 UTC 2013 
Responsible-Changed-Why:  
Track this while waiting for feedback with ports/170405. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170406 

From: Stefan Walter <stefan@freebsd.org>
To: Jan Beich <jbeich@tormail.org>
Cc: GNATS <FreeBSD-gnats-submit@FreeBSD.org>
Subject: Re: ports/170406: [patch] audio/oss: implicit declaration of
 'device_set_desc'
Date: Sun, 5 May 2013 11:55:49 +0200

 Hello Jan,
 
 can you elaborate a bit on what you're trying to achieve with this change?
 Wouldn't it be better if this change was made with the upstream authors?
 
 Best regards,
 Stefan
State-Changed-From-To: open->closed 
State-Changed-By: stefan 
State-Changed-When: Sun May 26 12:29:24 UTC 2013 
State-Changed-Why:  
Submitter feedback timeout (3 weeks), and I think such a change should be sent 
upstream, not made in the port. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170406 
>Unformatted:
