From nobody@FreeBSD.org  Fri Jul 20 21:10:40 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D55A11065695
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 20 Jul 2012 21:10:40 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id C07A08FC1D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 20 Jul 2012 21:10:40 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q6KLAevv010403
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 20 Jul 2012 21:10:40 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q6KLAefZ010402;
	Fri, 20 Jul 2012 21:10:40 GMT
	(envelope-from nobody)
Message-Id: <201207202110.q6KLAefZ010402@red.freebsd.org>
Date: Fri, 20 Jul 2012 21:10:40 GMT
From: "4721@hushmail.com" <4721@hushmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] lang/clang-devel: always build/install manpages
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         170036
>Category:       ports
>Synopsis:       [patch] lang/clang-devel: always build/install manpages
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brooks
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 20 21:20:16 UTC 2012
>Closed-Date:    Mon Jul 30 18:41:59 UTC 2012
>Last-Modified:  Mon Jul 30 18:50:16 UTC 2012
>Originator:     4721@hushmail.com
>Release:        
>Organization:
>Environment:
>Description:
patch makes manual page always built/installed. docs option only controlling html
documentation.

also moved single directory rmdir into packing list.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: lang/clang-devel/pkg-plist
===================================================================
--- lang/clang-devel/pkg-plist	(revision 301219)
+++ lang/clang-devel/pkg-plist	(working copy)
@@ -474,6 +474,7 @@
 @dirrm %%PYTHON_SITELIBDIR%%/Resources
 %%PORTDOCS%%@dirrm %%DOCSDIR%%/ps
 %%PORTDOCS%%@dirrm %%DOCSDIR%%/html/clang
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/html/img
 %%PORTDOCS%%@dirrm %%DOCSDIR%%/html
 %%PORTDOCS%%@dirrm %%DOCSDIR%%
 @dirrm %%DATADIR%%
Index: lang/clang-devel/Makefile
===================================================================
--- lang/clang-devel/Makefile	(revision 301219)
+++ lang/clang-devel/Makefile	(working copy)
@@ -130,10 +130,8 @@
 	${LN} -sf ${LOCALBASE}/lib/libLLVMSupport.a ${WRKSRC}/${RELTYPE}/lib/
 	cd ${WRKSRC}/utils/unittest && ${GMAKE}
 
-.if ${PORT_OPTIONS:MDOCS}
 post-build:
 	@cd ${WRKSRC}/tools/clang/docs/tools && ${GMAKE} clang.1
-.endif
 
 post-install:
 	@${INSTALL_SCRIPT} ${WRKSRC}/tools/clang/tools/scan-build/ccc-analyzer \
@@ -150,12 +148,8 @@
 	@${MKDIR} ${DATADIR}
 	@${INSTALL_DATA} ${WRKSRC}/tools/clang/tools/scan-build/scanview.css ${DATADIR}
 	@${INSTALL_DATA} ${WRKSRC}/tools/clang/tools/scan-build/sorttable.js ${DATADIR}
-.if ${PORT_OPTIONS:MDOCS}
 	@${INSTALL_MAN} ${WRKSRC}/tools/clang/docs/tools/clang.1 \
 	    ${MANPREFIX}/man/man1/
-.else
-	@${RMDIR} ${DOCSDIR}/html/img
-.endif
 
 TEST_CMD=	'(cd ${WRKSRC}/test; ${SETENV} ${MAKE_ENV} ${GMAKE} check)'
 regression-test: ${BUILD_COOKIE}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->brooks 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jul 20 21:20:27 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170036 
State-Changed-From-To: open->closed 
State-Changed-By: brooks 
State-Changed-When: Mon Jul 30 18:41:47 UTC 2012 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170036 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170036: commit references a PR
Date: Mon, 30 Jul 2012 18:41:28 +0000 (UTC)

 Author: brooks
 Date: Mon Jul 30 18:41:17 2012
 New Revision: 301736
 URL: http://svn.freebsd.org/changeset/ports/301736
 
 Log:
   Install manpages even when docs are off.
   
   Depend on devel/binutils on older OS versions which are missing a
   require option
   
   PR:		ports/170049, ports/170036
 
 Modified:
   head/lang/clang-devel/Makefile
 
 Modified: head/lang/clang-devel/Makefile
 ==============================================================================
 --- head/lang/clang-devel/Makefile	Mon Jul 30 18:40:23 2012	(r301735)
 +++ head/lang/clang-devel/Makefile	Mon Jul 30 18:41:17 2012	(r301736)
 @@ -7,7 +7,7 @@
  
  PORTNAME=	clang
  PORTVERSION=	3.2.r${SVN_REV}
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	lang devel
  MASTER_SITES=	${MASTER_SITE_LOCAL}
  MASTER_SITE_SUBDIR=	brooks
 @@ -92,6 +92,10 @@ RELTYPE=		Release
  BROKEN=		Does not compile on sparc64
  .endif
  
 +.if ${OSVERSION} < 900033
 +RUN_DEPENDS+=	${LOCALBASE}/bin/ld:${PORTSDIR}/devel/binutils
 +.endif
 +
  .if defined(BOOTSTRAP) || defined(SVN_FETCH)
  FETCH_DEPENDS+= svn:${PORTSDIR}/devel/subversion
  
 @@ -131,10 +135,8 @@ pre-build:
  	${LN} -sf ${LOCALBASE}/lib/libLLVMSupport.a ${WRKSRC}/${RELTYPE}/lib/
  	cd ${WRKSRC}/utils/unittest && ${GMAKE}
  
 -.if ${PORT_OPTIONS:MDOCS}
  post-build:
  	@cd ${WRKSRC}/tools/clang/docs/tools && ${GMAKE} clang.1
 -.endif
  
  post-install:
  	@${INSTALL_SCRIPT} ${WRKSRC}/tools/clang/tools/scan-build/ccc-analyzer \
 @@ -151,10 +153,9 @@ post-install:
  	@${MKDIR} ${DATADIR}
  	@${INSTALL_DATA} ${WRKSRC}/tools/clang/tools/scan-build/scanview.css ${DATADIR}
  	@${INSTALL_DATA} ${WRKSRC}/tools/clang/tools/scan-build/sorttable.js ${DATADIR}
 -.if ${PORT_OPTIONS:MDOCS}
  	@${INSTALL_MAN} ${WRKSRC}/tools/clang/docs/tools/clang.1 \
  	    ${MANPREFIX}/man/man1/
 -.else
 +.if !${PORT_OPTIONS:MDOCS}
  	@${RMDIR} ${DOCSDIR}/html/img
  .endif
  
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
