From nobody@FreeBSD.org  Fri Jul 20 21:04:28 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9C49A106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 20 Jul 2012 21:04:28 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8788C8FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 20 Jul 2012 21:04:28 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q6KL4SnF095922
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 20 Jul 2012 21:04:28 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q6KL4SD0095921;
	Fri, 20 Jul 2012 21:04:28 GMT
	(envelope-from nobody)
Message-Id: <201207202104.q6KL4SD0095921@red.freebsd.org>
Date: Fri, 20 Jul 2012 21:04:28 GMT
From: Pawel Pekala <pawel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: multimedia/mplayer not bumped after recent libogg update
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: thomas.e.zander@googlemail.com

>Number:         170035
>Category:       ports
>Synopsis:       multimedia/mplayer not bumped after recent libogg update
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pawel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 20 21:10:15 UTC 2012
>Closed-Date:    Sat Jul 21 17:45:52 UTC 2012
>Last-Modified:  Sat Jul 21 17:50:10 UTC 2012
>Originator:     Pawel Pekala
>Release:        10.0-CURRENT
>Organization:
>Environment:
FreeBSD blaviken.slowicza.org 10.0-CURRENT FreeBSD 10.0-CURRENT #10: Sat Jul 14 11:00:18 CEST 2012     corn@blaviken.slowicza.org:/usr/obj/usr/src/sys/BLAVIKEN  i386

>Description:
This port links to libogg and it's portrevision wasn't bumped after recent
libogg update. I propose to bump port revision and add explicit dependency
on audio/libogg so in the future this can be avoided.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -urN /usr/ports/multimedia/mplayer/Makefile multimedia/mplayer/Makefile
--- /usr/ports/multimedia/mplayer/Makefile	2012-06-01 07:22:38.000000000 +0200
+++ multimedia/mplayer/Makefile	2012-07-20 23:01:57.000000000 +0200
@@ -7,7 +7,7 @@
 
 PORTNAME=	mplayer
 PORTVERSION=	${MPLAYER_PORT_VERSION}
-PORTREVISION=	2
+PORTREVISION=	3
 
 COMMENT=	High performance media player supporting many formats
 
diff -urN /usr/ports/multimedia/mplayer/Makefile.options multimedia/mplayer/Makefile.options
--- /usr/ports/multimedia/mplayer/Makefile.options	2012-04-17 20:50:38.000000000 +0200
+++ multimedia/mplayer/Makefile.options	2012-07-20 22:04:29.000000000 +0200
@@ -94,7 +94,8 @@
 .endif
 
 .if defined(WITH_THEORA)
-LIB_DEPENDS+=	theora.0:${PORTSDIR}/multimedia/libtheora
+LIB_DEPENDS+=	theora.0:${PORTSDIR}/multimedia/libtheora \
+		ogg:${PORTSDIR}/audio/libogg
 .else
 CONFIGURE_ARGS+=	--disable-theora
 .endif


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pawel 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jul 20 21:10:36 UTC 2012 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170035 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Jul 20 21:10:39 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170035 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: thomas.e.zander@googlemail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/170035: multimedia/mplayer not bumped after recent libogg update
Date: Fri, 20 Jul 2012 21:10:38 UT

 Maintainer of multimedia/mplayer,
 
 Please note that PR ports/170035 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/170035
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Thomas Zander <thomas.e.zander@googlemail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/170035: multimedia/mplayer not bumped after recent libogg update
Date: Sat, 21 Jul 2012 13:54:14 +0200

 While I understand that this is an inconvenience in this particular
 case, let us take a step back for one moment.
 The ports infrastructure is actually doing a very good job in taking
 the burden of taking manual care of transitive dependencies from us
 port maintainers. Like some other ports, mplayer has a ridiculous
 number of OPTIONS that cause additional dependencies to be pulled in
 via dependencies on other ports. libogg is one example of the very
 recent past where this happened for mplayer, but it's a totally common
 case for many ports. That's why there is portmaster -r.
 I don't think it's a wise idea to start maintaining all possible
 combinations of transitive dependencies now manually. Other ports
 don't do it either (e.g. the number of LIB_DEPENDS and RUN_DEPENDS in
 www/chromium don't add up to the 99 dependencies it has on my system),
 because the ports infrastructure is already doing it.
 An entry in UPDATING and a portmaster -r should be the solution here.
 
 I can't approve of this patch because it does only work around one
 particular edge case for which a proven mechanism is already in place.
 
 Best regards
 Riggs
State-Changed-From-To: feedback->closed 
State-Changed-By: pawel 
State-Changed-When: Sat Jul 21 17:45:51 UTC 2012 
State-Changed-Why:  
Rejected by maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170035 

From: Pawel Pekala <pawel@FreeBSD.org>
To: Thomas Zander <thomas.e.zander@googlemail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/170035: multimedia/mplayer not bumped after recent libogg
 update
Date: Sat, 21 Jul 2012 19:44:31 +0200

 Dnia 2012-07-21, o godz. 12:00:33
 Thomas Zander <thomas.e.zander@googlemail.com> napisa=B3(a):
 
 > While I understand that this is an inconvenience in this particular
 > case, let us take a step back for one moment.
 
 Firstly port bumping after library update should be done by person who
 did it, not maintainers of affected ports. This was in my opinion
 neglected and broke mplayer for me and I assume for others as well.
 Hence I did this PR.
 
 > The ports infrastructure is actually doing a very good job in taking
 > the burden of taking manual care of transitive dependencies from us
 > port maintainers. Like some other ports, mplayer has a ridiculous
 > number of OPTIONS that cause additional dependencies to be pulled in
 > via dependencies on other ports. libogg is one example of the very
 > recent past where this happened for mplayer, but it's a totally common
 > case for many ports. That's why there is portmaster -r.
 > I don't think it's a wise idea to start maintaining all possible
 > combinations of transitive dependencies now manually. Other ports
 > don't do it either (e.g. the number of LIB_DEPENDS and RUN_DEPENDS in
 > www/chromium don't add up to the 99 dependencies it has on my system),
 > because the ports infrastructure is already doing it.
 > An entry in UPDATING and a portmaster -r should be the solution here.
 
 Maintaining list of all libraries (in Makefile) your package links to is
 IMHO good practice. It helps port committers find ports to bump and keep
 things working for all users. portmaster -r is in my eyes last resort
 and not good option, dependencies between ports stay not well
 described and overall ports tree quality does not improve.
 
 > I can't approve of this patch because it does only work around one
 > particular edge case for which a proven mechanism is already in place.
 
 Fair enough.
 
 --=20
 pozdrawiam / with regards
 Pawe=B3 P=EAkala
>Unformatted:
