From crees@bayofrum.net  Thu Jul 19 21:04:51 2012
Return-Path: <crees@bayofrum.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1A7811065670
	for <freebsd-gnats-submit@freebsd.org>; Thu, 19 Jul 2012 21:04:51 +0000 (UTC)
	(envelope-from crees@bayofrum.net)
Received: from mk-outboundfilter-1.mail.uk.tiscali.com (mk-outboundfilter-1.mail.uk.tiscali.com [212.74.114.37])
	by mx1.freebsd.org (Postfix) with ESMTP id 9D0838FC1C
	for <freebsd-gnats-submit@freebsd.org>; Thu, 19 Jul 2012 21:04:50 +0000 (UTC)
Received: from host-2-102-4-87.as13285.net (HELO pegasus.bayofrum.net) ([2.102.4.87])
  by smtp.pipex.tiscali.co.uk with ESMTP; 19 Jul 2012 22:03:31 +0100
Received: by pegasus.bayofrum.net (Postfix, from userid 1001)
	id D9F2910F08; Thu, 19 Jul 2012 22:03:21 +0100 (BST)
Message-Id: <20120719210321.D9F2910F08@pegasus.bayofrum.net>
Date: Thu, 19 Jul 2012 22:03:21 +0100 (BST)
From: Chris Rees <crees@bayofrum.net>
Reply-To: Chris Rees <crees@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] dns/unbound Incorrect use of empty()
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         170007
>Category:       ports
>Synopsis:       [PATCH] dns/unbound Incorrect use of empty()
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 19 21:10:11 UTC 2012
>Closed-Date:    Sat Jul 21 20:43:53 UTC 2012
>Last-Modified:  Sat Jul 21 20:50:04 UTC 2012
>Originator:     Chris Rees
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD pegasus.bayofrum.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Sun Apr 29 12:29:02 BST 2012 root@pegasus.bayofrum.net:/usr/obj/usr/src/sys/PEGASUS amd64


	
>Description:
	.if empty() in a Makefile should not have a $ in;

	correct:
	.if empty(FOO)

	incorrect:
	.if empty(${FOO})
>How-To-Repeat:
	
>Fix:

	Submitted by Alexey Kouznetsov

--- patch.txt begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 301190)
+++ Makefile	(working copy)
@@ -88,7 +88,7 @@
 CONFIGURE_ARGS+=--with-libevent=no
 .endif
 
-.if empty(${PORT_OPTIONS:MTHREADS})
+.if empty(PORT_OPTIONS:MTHREADS)
 CONFIGURE_ARGS+=--without-pthreads
 .endif
 
--- patch.txt ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sem 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Jul 19 21:10:24 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170007 
State-Changed-From-To: open->		 closed 
State-Changed-By: sunpoet 
State-Changed-When: Sat Jul 21 20:41:14 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 


Responsible-Changed-From-To: sem->sunpoet 
Responsible-Changed-By: sunpoet 
Responsible-Changed-When: Sat Jul 21 20:41:14 UTC 2012 
Responsible-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170007 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/170007: commit references a PR
Date: Sat, 21 Jul 2012 20:41:22 +0000 (UTC)

 Author: sunpoet
 Date: Sat Jul 21 20:41:09 2012
 New Revision: 301286
 URL: http://svn.freebsd.org/changeset/ports/301286
 
 Log:
   - Fix option handling of THREADS
   
   PR:		ports/170007
   Reported by:	Alexey Kouznetsov <alexey@kouznetsov.com>
   Submitted by:	crees
   Approved by:	sem (maintainer)
 
 Modified:
   head/dns/unbound/Makefile   (contents, props changed)
 
 Modified: head/dns/unbound/Makefile
 ==============================================================================
 --- head/dns/unbound/Makefile	Sat Jul 21 20:02:06 2012	(r301285)
 +++ head/dns/unbound/Makefile	Sat Jul 21 20:41:09 2012	(r301286)
 @@ -88,7 +88,7 @@ CONFIGURE_ARGS+=--with-libevent=${LOCALB
  CONFIGURE_ARGS+=--with-libevent=no
  .endif
  
 -.if empty(${PORT_OPTIONS:MTHREADS})
 +.if empty(PORT_OPTIONS:MTHREADS)
  CONFIGURE_ARGS+=--without-pthreads
  .endif
  
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
