From bryan@shatow.net  Wed Jul 18 15:57:04 2012
Return-Path: <bryan@shatow.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0CE15106567A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Jul 2012 15:57:04 +0000 (UTC)
	(envelope-from bryan@shatow.net)
Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92])
	by mx1.freebsd.org (Postfix) with ESMTP id 4CCD38FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Jul 2012 15:57:03 +0000 (UTC)
Received: (qmail 7364 invoked from network); 18 Jul 2012 10:56:55 -0500
Received: from unknown (HELO test8.xzibition.com) (10.10.0.34)
  by sweb.xzibition.com with SMTP; 18 Jul 2012 10:56:55 -0500
Received: by test8.xzibition.com (sSMTP sendmail emulation); Wed, 18 Jul 2012 10:56:46 -0500
Message-Id: <20120718155704.0CE15106567A@hub.freebsd.org>
Date: Wed, 18 Jul 2012 10:56:46 -0500
From: "Bryan Drewery" <bryan@shatow.net>
Reply-To: Bryan Drewery <bryan@shatow.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: eadler@freebsd.org
Subject: [PATCH] devel/ioncube: Use DIST_SUBDIR to fix upgrade distfile caching issues
X-Send-Pr-Version: 3.113
X-GNATS-Notify: svyatoslav.lempert@gmail.com

>Number:         169975
>Category:       ports
>Synopsis:       [PATCH] devel/ioncube: Use DIST_SUBDIR to fix upgrade distfile caching issues
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 18 16:00:07 UTC 2012
>Closed-Date:    Thu Jul 26 12:21:21 UTC 2012
>Last-Modified:  Thu Jul 26 12:21:21 UTC 2012
>Originator:     Bryan Drewery
>Release:        FreeBSD 8.3-RELEASE i386
>Organization:
>Environment:

	
>Description:
	ports/163872 reported an issue where the old local distfile is reused even during upgrade.
>How-To-Repeat:
	
>Fix:

	Fix uses a versioned subdir. The upstream is already mirrored using a versioned directory, so nothing further is needed there.

--- patch-ioncube-distsubdir.txt begins here ---
diff -u /usr/ports/devel/ioncube.orig/Makefile ./Makefile
--- /usr/ports/devel/ioncube.orig/Makefile	2012-06-20 16:24:14.000000000 -0500
+++ ./Makefile	2012-07-18 10:54:02.000000000 -0500
@@ -22,6 +22,7 @@
 
 SUB_FILES=	pkg-message
 WRKSRC=		${WRKDIR}/${PORTNAME}
+DIST_SUBDIR=	${PORTNAME}/${DISTVERSION}
 
 .include <bsd.port.pre.mk>
 
diff -u /usr/ports/devel/ioncube.orig/distinfo ./distinfo
--- /usr/ports/devel/ioncube.orig/distinfo	2012-06-20 16:24:14.000000000 -0500
+++ ./distinfo	2012-07-18 10:35:58.000000000 -0500
@@ -1,8 +1,8 @@
-SHA256 (ioncube_loaders_fre_7_x86.tar.bz2) = 382435cbd74527857f0a15c94c5364cc7a2ede48ce92cabcbe045229795202f4
-SIZE (ioncube_loaders_fre_7_x86.tar.bz2) = 3330295
-SHA256 (ioncube_loaders_fre_7_x86-64.tar.bz2) = f54d5fe28c47d0b3d43f7fda2ad5cc800fe3aef6f852e9e0033f1400a1e4fc60
-SIZE (ioncube_loaders_fre_7_x86-64.tar.bz2) = 3441909
-SHA256 (ioncube_loaders_fre_8_x86.tar.bz2) = edcbdb01bedd94bae53a4c07515950fcaee3c3b241a3d39567cd289964047504
-SIZE (ioncube_loaders_fre_8_x86.tar.bz2) = 3332128
-SHA256 (ioncube_loaders_fre_8_x86-64.tar.bz2) = 2a8a59f03f0a815bf41c5a1e59dfdc733be9d98cd4cae0c02c9366d68e3ec2cf
-SIZE (ioncube_loaders_fre_8_x86-64.tar.bz2) = 3442231
+SHA256 (ioncube/4.2.1/ioncube_loaders_fre_7_x86.tar.bz2) = 382435cbd74527857f0a15c94c5364cc7a2ede48ce92cabcbe045229795202f4
+SIZE (ioncube/4.2.1/ioncube_loaders_fre_7_x86.tar.bz2) = 3330295
+SHA256 (ioncube/4.2.1/ioncube_loaders_fre_7_x86-64.tar.bz2) = f54d5fe28c47d0b3d43f7fda2ad5cc800fe3aef6f852e9e0033f1400a1e4fc60
+SIZE (ioncube/4.2.1/ioncube_loaders_fre_7_x86-64.tar.bz2) = 3441909
+SHA256 (ioncube/4.2.1/ioncube_loaders_fre_8_x86.tar.bz2) = edcbdb01bedd94bae53a4c07515950fcaee3c3b241a3d39567cd289964047504
+SIZE (ioncube/4.2.1/ioncube_loaders_fre_8_x86.tar.bz2) = 3332128
+SHA256 (ioncube/4.2.1/ioncube_loaders_fre_8_x86-64.tar.bz2) = 2a8a59f03f0a815bf41c5a1e59dfdc733be9d98cd4cae0c02c9366d68e3ec2cf
+SIZE (ioncube/4.2.1/ioncube_loaders_fre_8_x86-64.tar.bz2) = 3442231
--- patch-ioncube-distsubdir.txt ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Jul 18 16:00:41 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169975 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: svyatoslav.lempert@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/169975: [PATCH] devel/ioncube: Use DIST_SUBDIR to fix upgrade distfile caching issues
Date: Wed, 18 Jul 2012 16:00:39 UT

 Maintainer of devel/ioncube,
 
 Please note that PR ports/169975 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169975
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Svyatoslav Lempert <svyatoslav.lempert@gmail.com>
To: bug-followup@freebsd.org, bryan@shatow.net
Cc:  
Subject: Re: ports/169975: [PATCH] devel/ioncube: Use DIST_SUBDIR to fix
 upgrade distfile caching issues
Date: Sun, 22 Jul 2012 15:02:54 +0900

 Added to update 4.2.2
 http://www.freebsd.org/cgi/query-pr.cgi?pr=170060 , thank you
 Port commiters, you please close this PR
 
 -- 
 Svyatoslav
State-Changed-From-To: feedback->closed 
State-Changed-By: scheidell 
State-Changed-When: Thu Jul 26 12:21:19 UTC 2012 
State-Changed-Why:  
Pr closed at maintainers request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169975 
>Unformatted:
