From bsdkaffee@gmail.com  Sun Jul  1 11:53:53 2012
Return-Path: <bsdkaffee@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B02B41065672
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Jul 2012 11:53:53 +0000 (UTC)
	(envelope-from bsdkaffee@gmail.com)
Received: from mail-qc0-f182.google.com (mail-qc0-f182.google.com [209.85.216.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 71BD78FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Jul 2012 11:53:53 +0000 (UTC)
Received: by qcsg15 with SMTP id g15so2840957qcs.13
        for <FreeBSD-gnats-submit@freebsd.org>; Sun, 01 Jul 2012 04:53:53 -0700 (PDT)
Received: by 10.224.191.194 with SMTP id dn2mr16370058qab.42.1341143632885;
        Sun, 01 Jul 2012 04:53:52 -0700 (PDT)
Received: from mocha.verizon.net (c-71-61-40-68.hsd1.oh.comcast.net. [71.61.40.68])
        by mx.google.com with ESMTPS id u4sm23768819qaa.1.2012.07.01.04.53.52
        (version=TLSv1/SSLv3 cipher=OTHER);
        Sun, 01 Jul 2012 04:53:52 -0700 (PDT)
Message-Id: <1341143632.415046.21604@mocha.verizon.net>
Date: Sun, 1 Jul 2012 07:53:52 -0400
From: Jason E. Hale <bsdkaffee@gmail.com>
Reply-To: Jason E. Hale <bsdkaffee@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] audio/libmusicbrainz3: Use LATEST_LINK 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         169573
>Category:       ports
>Synopsis:       [MAINTAINER] audio/libmusicbrainz3: Use LATEST_LINK
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jase
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 01 12:00:28 UTC 2012
>Closed-Date:    Fri Jul 27 13:35:46 UTC 2012
>Last-Modified:  Fri Jul 27 13:35:46 UTC 2012
>Originator:     Jason E. Hale
>Release:        FreeBSD 9.0-RELEASE i386
>Organization:
none 
>Environment:
System: FreeBSD mocha.verizon.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Thu Jan 19 11:42:41 EST 2012 Jason@mocha.verizon.net:/usr/obj/usr/src/sys/MOCHA9 i386


	
>Description:
- Use LATEST_LINK in audio/libmusicbrainz3 instead of defining the version in PORTNAME
- Fix LICENSE - it's LGPL21 not GPLv2
- Remove shlib version from LIB_DEPENDS

	
>How-To-Repeat:
- Use attached diff
- The following ports depend on libmusicbrainz3 and should have PORTREVISION
  bumped since PORTNAME changed:
   - audio/goobox
   - audio/rhythmbox
   - audio/sound-juicer
   - multimedia/gnome-mplayer
   - multimedia/kdemultimedia4
	
>Fix:

	



--- 2012-07-01-libmusicbrainz3.diff begins here ---
diff -ruN libmusicbrainz3.orig/Makefile libmusicbrainz3/Makefile
--- libmusicbrainz3.orig/Makefile	2012-07-01 07:04:05.000000000 -0400
+++ libmusicbrainz3/Makefile	2012-07-01 07:08:10.000000000 -0400
@@ -5,20 +5,23 @@
 # $FreeBSD: ports/audio/libmusicbrainz3/Makefile,v 1.46 2011/03/28 03:01:31 wen Exp $
 #
 
-PORTNAME=	libmusicbrainz3
+PORTNAME=	libmusicbrainz
 PORTVERSION=	3.0.3
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	audio
 MASTER_SITES=	ftp://ftp.musicbrainz.org/pub/musicbrainz/ \
 		http://uk.musicbrainz.org/pub/musicbrainz/ \
 		http://ftp.osuosl.org/pub/musicbrainz/
-DISTNAME=	${PORTNAME:S/3//}-${PORTVERSION}
 
 MAINTAINER=	bsdkaffee@gmail.com
 COMMENT=	MusicBrainz client library for audio metadata lookup
 
+LICENSE=	LGPL21
+
 LIB_DEPENDS=	discid:${PORTSDIR}/audio/libdiscid \
-		neon.27:${PORTSDIR}/www/neon29
+		neon:${PORTSDIR}/www/neon29
+
+LATEST_LINK=	${PORTNAME}3
 
 USE_CMAKE=	yes
 USE_GNOME=	pkgconfig
@@ -26,9 +29,6 @@
 
 MAKE_JOBS_SAFE=	yes
 
-LICENSE=	GPLv2
-LICENSE_FILE=	${WRKSRC}/COPYING.txt
-
 post-patch:
 	${REINPLACE_CMD} -e '/pkgconfig/s|$${LIB_INSTALL_DIR}|libdata|' \
 		-e '/CppUnit/d' ${WRKSRC}/CMakeLists.txt
--- 2012-07-01-libmusicbrainz3.diff ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jase 
Responsible-Changed-By: jase 
Responsible-Changed-When: Sun 1 Jul 2012 13:54:14 UTC 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169573 

From: "Jason E. Hale" <bsdkaffee@gmail.com>
To: bug-followup@freebsd.org, bsdkaffee@gmail.com, jase@freebsd.org
Cc:  
Subject: Re: ports/169573: [MAINTAINER] audio/libmusicbrainz3: Use LATEST_LINK
Date: Fri, 27 Jul 2012 04:57:49 -0400

 Here is an updated patch to use the new USE_PKGCONFIG macro.
 
 --- 2012-07-27-libmusicbrainz3.diff begins here ---
 Index: Makefile
 ===================================================================
 --- Makefile	(revision 301592)
 +++ Makefile	(working copy)
 @@ -5,30 +5,29 @@
  # $FreeBSD$
  #
  
 -PORTNAME=	libmusicbrainz3
 +PORTNAME=	libmusicbrainz
  PORTVERSION=	3.0.3
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	audio
  MASTER_SITES=	ftp://ftp.musicbrainz.org/pub/musicbrainz/ \
 -		http://uk.musicbrainz.org/pub/musicbrainz/ \
  		http://ftp.osuosl.org/pub/musicbrainz/
 -DISTNAME=	${PORTNAME:S/3//}-${PORTVERSION}
  
  MAINTAINER=	bsdkaffee@gmail.com
  COMMENT=	MusicBrainz client library for audio metadata lookup
  
 +LICENSE=	LGPL21
 +
  LIB_DEPENDS=	discid:${PORTSDIR}/audio/libdiscid \
 -		neon.27:${PORTSDIR}/www/neon29
 +		neon:${PORTSDIR}/www/neon29
  
 +LATEST_LINK=	${PORTNAME}3
 +
  USE_CMAKE=	yes
 -USE_GNOME=	pkgconfig
 +USE_PKGCONFIG=	yes
  USE_LDCONFIG=	yes
  
  MAKE_JOBS_SAFE=	yes
  
 -LICENSE=	GPLv2
 -LICENSE_FILE=	${WRKSRC}/COPYING.txt
 -
  post-patch:
  	${REINPLACE_CMD} -e '/pkgconfig/s|$${LIB_INSTALL_DIR}|libdata|' \
  		-e '/CppUnit/d' ${WRKSRC}/CMakeLists.txt
 --- 2012-07-27-libmusicbrainz3.diff ends here ---

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169573: commit references a PR
Date: Fri, 27 Jul 2012 13:28:30 +0000 (UTC)

 Author: makc
 Date: Fri Jul 27 13:28:20 2012
 New Revision: 301614
 URL: http://svn.freebsd.org/changeset/ports/301614
 
 Log:
   - Use LATEST_LINK instead of defining the version in PORTNAME
   - Fix LICENSE - it's LGPL21 not GPLv2
   - Remove shlib version from LIB_DEPENDS
   
   - while I'm here, respect LOCALBASE and thus remove needless dependency
     on pkg-config. pkg-config is often used by cmake as auxiliary tool
     to populate search paths. Until stuff is located at standard location,
     there is no need for pkg-config utility. [1]
   
   PR:		ports/169573
   Submitted by:	Jason E. Hale (maintainer)
   Approved by:	maintainer via irc [1]
 
 Modified:
   head/audio/libmusicbrainz3/Makefile   (contents, props changed)
 
 Modified: head/audio/libmusicbrainz3/Makefile
 ==============================================================================
 --- head/audio/libmusicbrainz3/Makefile	Fri Jul 27 13:24:51 2012	(r301613)
 +++ head/audio/libmusicbrainz3/Makefile	Fri Jul 27 13:28:20 2012	(r301614)
 @@ -5,32 +5,33 @@
  # $FreeBSD$
  #
  
 -PORTNAME=	libmusicbrainz3
 +PORTNAME=	libmusicbrainz
  PORTVERSION=	3.0.3
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	audio
  MASTER_SITES=	ftp://ftp.musicbrainz.org/pub/musicbrainz/ \
  		http://uk.musicbrainz.org/pub/musicbrainz/ \
  		http://ftp.osuosl.org/pub/musicbrainz/
 -DISTNAME=	${PORTNAME:S/3//}-${PORTVERSION}
  
  MAINTAINER=	bsdkaffee@gmail.com
  COMMENT=	MusicBrainz client library for audio metadata lookup
  
 +LICENSE=	LGPL21
 +
  LIB_DEPENDS=	discid:${PORTSDIR}/audio/libdiscid \
 -		neon.27:${PORTSDIR}/www/neon29
 +		neon:${PORTSDIR}/www/neon29
 +
 +LATEST_LINK=	${PORTNAME}3
  
  USE_CMAKE=	yes
 -USE_GNOME=	pkgconfig
  USE_LDCONFIG=	yes
  
  MAKE_JOBS_SAFE=	yes
  
 -LICENSE=	GPLv2
 -LICENSE_FILE=	${WRKSRC}/COPYING.txt
 -
  post-patch:
  	${REINPLACE_CMD} -e '/pkgconfig/s|$${LIB_INSTALL_DIR}|libdata|' \
  		-e '/CppUnit/d' ${WRKSRC}/CMakeLists.txt
 +	${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
 +		 ${WRKSRC}/cmake/modules/*.cmake
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: makc 
State-Changed-When: Fri Jul 27 13:35:45 UTC 2012 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169573 
>Unformatted:
