From nobody@FreeBSD.org  Fri Jun 22 06:40:19 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 10FCF1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jun 2012 06:40:19 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D82878FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jun 2012 06:40:18 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5M6eIWL059153
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jun 2012 06:40:18 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q5M6eIGx059152;
	Fri, 22 Jun 2012 06:40:18 GMT
	(envelope-from nobody)
Message-Id: <201206220640.q5M6eIGx059152@red.freebsd.org>
Date: Fri, 22 Jun 2012 06:40:18 GMT
From: jb <jb.1234abcd@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: bsdconfig test results and fixes
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         169316
>Category:       ports
>Synopsis:       sysutils/bsdconfig test results and fixes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dteske
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 22 06:50:13 UTC 2012
>Closed-Date:    Tue Apr 01 00:37:25 UTC 2014
>Last-Modified:  Tue Apr 01 00:37:25 UTC 2014
>Originator:     jb
>Release:        FreeBSD 9.0-RELEASE-p3 #0
>Organization:
>Environment:
FreeBSD localhost.localdomain 9.0-RELEASE-p3 FreeBSD 9.0-RELEASE-p3 #0: Tue Jun 12 01:47:53 UTC 2012     root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
Disk Management
  Partition     Managing disk partitions               <============ non-verb
  Label         Label allocated disk partitions  

Fix: use verbs consistently
  Partition     Manage disk partitions
-----------------------------------------------------------------------------
Login/Group Management
  Exit
  ...

Console
  Exit     Exit this menu (returning to previous)    <============ too verbose 
  ...

Fix: be consistent
Console
  Exit
  ...

Same for other menu:

Mouse
  Exit     Exit this menu (returning to previous)    <============ too verbose 
  ...

Fix: be consistent
Mouse
  Exit
  ...

Same for other menu:

Security
  <<< Exit     Exit this menu (returning to previous)    <============ too
                                                         verbose, and <<< too ?
  ...

Fix: be consistent
Security
  Exit

-----------------------------------------------------------------------------
Console
  Repeat
    Slow           <============== highlighted 
    ...
    Default        <============== wrong position in menu
           
Fix: place default menu items at top, highlighted, so they can be selected
     immediately by hitting ENTER


    Default        <============== highlighted
    Slow
    ...
-----------------------------------------------------------------------------
Console
  ...
  Saver
    1 Blank    Simply blank the screen   <============ too verbose
    ...
    d None     Disable the screensaver   <============ wrong position 
    ...

Fix: place it (default) at top of menu, highlighted (btw, you did it right
     under Screenmap and Ttys menus ...)

  Saver
    1 None     Disable the screensaver  
    2 Blank    Blank screen   <======== better than "Simply blank the screen"
    ...

  NOTE:
  The choice of selectors is too limiting: 1-9,a,...,z       <============
  Make it consistent and almost unlimited: 1,...,99 or 1,...,999
  Leave alpha chars (a,...,A,...) for command selectors, e.g. Timeout.
-----------------------------------------------------------------------------
Timezone

It would be good to tell the user the difference between UTC and local time
selection for multi-boot OS users:
  if the other OS manages and adjusts the local time, then users should select
  local time.
-----------------------------------------------------------------------------

>How-To-Repeat:
run bsdconfig
$ ls /var/db/pkg/bsdconfig-0.7.2/

>Fix:
as above

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dteske 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Jun 22 07:41:11 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169316 

From: Devin Teske <devin.teske@fisglobal.com>
To: <bug-followup@FreeBSD.org>, <jb.1234abcd@gmail.com>
Cc:  
Subject: Re: ports/169316: sysutils/bsdconfig test results and fixes
Date: Fri, 22 Jun 2012 01:30:41 -0700

 RE: Partition Management
 
 This menu is not part of bsdconfig but is actually sade(8) (no sense in fil=
 ing a PR on sade(8) as it's destined for replacement, imho -- doesn't suppo=
 rt GEOM and/or gpart).
 
 Notice that when you select "Disk Management" the "bsdconfig" backtitle dis=
 appears (that's the clue that you just left bsdconfig and are now in sade).=
  The second clue that you left bsdconfig and entered sade is that bsdconfig=
  uses dialog(1) which is linked against lib dialog (RELENG_9 or higher) mea=
 nwhile sade is linked against libodialog; the difference between libdialog =
 and libodialog is very obvious (menu items are yellow in odialog and nearly=
  unreable; meanwhile yellow is not used in menu items in the new libdialog).
 
 RE: "too verbose" =85
 
 I'll sleep on it and look at consistencies. But in-general, we're replicati=
 ng sysinstall almost exactly. Any inconsistency is likely to exist in sysin=
 stall at the same time. I personally noticed many.
 
 My plan was to address the inconsistencies after we had reached a point of =
 parity where it is agreed that we can dump sysinstall in favor of bsdconfig=
  (which is best reached if we have functional parity).
 
 RE: wrong position in menu=85
 
 See sysinstall's menu -- we're currently going for parity.
 
 I have no qualms with changing AFTER initial import/MFC, but initial import=
  is targeting feature/menu/quirk parity for ease of transition for user bas=
 e (tho I agree on default being on top).
 
 RE: unlimited menutagging via 1..999999 versus 1-9A-Z
 
 ... you can't -- multi-letter keywords don't work.
 
 Only the first letter of a menutag is referenced when performing type-ahead=
  (9, 99, and 9999999 all have the same hot-key... 9; pressing 9 three times=
  cyclicly jumps between each of the items beginning with 9 -- there is no t=
 imed/stacked buffer for type-ahead characters as there is in Mac OS; this l=
 imitation is below dialog(1) and in libdialog and was even worse back in li=
 bodialog).
 
 RE: Timezone
 
 I hear your suggestion for timezone, but again -- compare to tzsetup (we're=
  shooting for parity during replacement; we shall not enhance at the same t=
 ime as replacing).
 --=20
 Devin
 
 _____________
 The information contained in this message is proprietary and/or confidentia=
 l. If you are not the intended recipient, please: (i) delete the message an=
 d all copies; (ii) do not disclose, distribute or use the message in any ma=
 nner; and (iii) notify the sender immediately. In addition, please be aware=
  that any message addressed to our domain is subject to archiving and revie=
 w by persons other than the intended recipient. Thank you.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169316: commit references a PR
Date: Tue,  4 Jun 2013 16:48:37 +0000 (UTC)

 Author: dteske
 Date: Tue Jun  4 16:48:23 2013
 New Revision: 251389
 URL: http://svnweb.freebsd.org/changeset/base/251389
 
 Log:
   Lessen verbosity of "Exit" menutag items to appear more consistent across
   menus from one module to the next.
   
   Replacing "Exit this menu (returning to previous)" with "Exit this menu".
   
   PR:		ports/169316
 
 Modified:
   head/usr.sbin/bsdconfig/console/include/messages.subr
   head/usr.sbin/bsdconfig/mouse/include/messages.subr
   head/usr.sbin/bsdconfig/security/include/messages.subr
   head/usr.sbin/bsdconfig/startup/include/messages.subr
   head/usr.sbin/bsdconfig/startup/rcconf
   head/usr.sbin/bsdconfig/startup/share/rcconf.subr
 
 Modified: head/usr.sbin/bsdconfig/console/include/messages.subr
 ==============================================================================
 --- head/usr.sbin/bsdconfig/console/include/messages.subr	Tue Jun  4 16:32:17 2013	(r251388)
 +++ head/usr.sbin/bsdconfig/console/include/messages.subr	Tue Jun  4 16:48:23 2013	(r251389)
 @@ -78,7 +78,7 @@ msg_estonian_iso_desc="Estonian ISO keym
  msg_estonian_iso_15="Estonian ISO 15"
  msg_estonian_iso_15_desc="Estonian ISO 8859-15 keymap"
  msg_exit="Exit"
 -msg_exit_this_menu="Exit this menu (returning to previous)"
 +msg_exit_this_menu="Exit this menu"
  msg_fade="Fade"
  msg_fade_desc="Fade out effect screen saver"
  msg_fast="Fast"
 
 Modified: head/usr.sbin/bsdconfig/mouse/include/messages.subr
 ==============================================================================
 --- head/usr.sbin/bsdconfig/mouse/include/messages.subr	Tue Jun  4 16:32:17 2013	(r251388)
 +++ head/usr.sbin/bsdconfig/mouse/include/messages.subr	Tue Jun  4 16:48:23 2013	(r251389)
 @@ -42,7 +42,7 @@ msg_disable="Disable"
  msg_disable_the_mouse_daemon="Disable the mouse daemon"
  msg_enable="Enable"
  msg_exit="Exit"
 -msg_exit_this_menu="Exit this menu (returning to previous)"
 +msg_exit_this_menu="Exit this menu"
  msg_flags="Flags"
  msg_glidepoint="GlidePoint"
  msg_glidepoint_desc="ALPS GlidePoint pad (serial)"
 
 Modified: head/usr.sbin/bsdconfig/security/include/messages.subr
 ==============================================================================
 --- head/usr.sbin/bsdconfig/security/include/messages.subr	Tue Jun  4 16:32:17 2013	(r251388)
 +++ head/usr.sbin/bsdconfig/security/include/messages.subr	Tue Jun  4 16:48:23 2013	(r251389)
 @@ -30,7 +30,7 @@ msg_cancel="Cancel"
  msg_disable_securelevels="Disable securelevels"
  msg_disabled="Disabled"
  msg_exit="Exit"
 -msg_exit_this_menu="Exit this menu (returning to previous)"
 +msg_exit_this_menu="Exit this menu"
  msg_highly_secure="Highly Secure"
  msg_highly_secure_mode="Highly secure mode"
  msg_menu_text="This menu allows you to configure aspects of the operating system security\npolicy.  Please read the system documentation carefully before modifying\nthese settings, as they may cause service disruption if used improperly.\n\nMost settings will take affect only following a system reboot."
 
 Modified: head/usr.sbin/bsdconfig/startup/include/messages.subr
 ==============================================================================
 --- head/usr.sbin/bsdconfig/startup/include/messages.subr	Tue Jun  4 16:32:17 2013	(r251388)
 +++ head/usr.sbin/bsdconfig/startup/include/messages.subr	Tue Jun  4 16:48:23 2013	(r251389)
 @@ -63,8 +63,7 @@ msg_exit_cancel="Exit/Cancel"
  msg_exit_cancel_desc="Return to previous menu"
  msg_exit_cancel_help="Return to the previous menu (selected items are untouched)"
  msg_exit_desc="Return to previous menu"
 -msg_exit_help="Exit this menu (returning to previous)"
 -msg_exit_this_menu="Exit this menu (returning to previous)"
 +msg_exit_this_menu="Exit this menu"
  msg_info="Info"
  msg_lpd="lpd"
  msg_lpd_desc="This host has a printer and wants to run lpd."
 
 Modified: head/usr.sbin/bsdconfig/startup/rcconf
 ==============================================================================
 --- head/usr.sbin/bsdconfig/startup/rcconf	Tue Jun  4 16:32:17 2013	(r251388)
 +++ head/usr.sbin/bsdconfig/startup/rcconf	Tue Jun  4 16:48:23 2013	(r251389)
 @@ -81,7 +81,7 @@ dialog_menu_main()
  	local prompt=
  	local menu_list="
  		'X $msg_exit'    '$msg_exit_desc'
 -		                  ${SHOW_DESC:+'$msg_exit_help'}
 +		                  ${SHOW_DESC:+'$msg_exit_this_menu'}
  		'> $msg_add_new' '$msg_add_new_desc'
  		                  ${SHOW_DESC:+'$msg_add_new_help'}
  		'> $msg_delete'  '$msg_delete_desc'
 
 Modified: head/usr.sbin/bsdconfig/startup/share/rcconf.subr
 ==============================================================================
 --- head/usr.sbin/bsdconfig/startup/share/rcconf.subr	Tue Jun  4 16:32:17 2013	(r251388)
 +++ head/usr.sbin/bsdconfig/startup/share/rcconf.subr	Tue Jun  4 16:48:23 2013	(r251389)
 @@ -372,7 +372,7 @@ f_dialog_input_rclist()
  {
  	local prompt="$msg_please_select_an_rcconf_directive"
  	local menu_list="
 -		'X $msg_exit' '' ${SHOW_DESC:+'$msg_exit_help'}
 +		'X $msg_exit' '' ${SHOW_DESC:+'$msg_exit_this_menu'}
  	" # END-QUOTE
  	local hline="$hline_arrows_tab_enter"
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169316: commit references a PR
Date: Tue,  4 Jun 2013 17:08:40 +0000 (UTC)

 Author: dteske
 Date: Tue Jun  4 17:08:26 2013
 New Revision: 251390
 URL: http://svnweb.freebsd.org/changeset/base/251390
 
 Log:
   Shift Console->Saver menu items to place the default item at the top, making
   this menu consistent with Console->Repeat, Console->Font, Console->Screenmap
   and many others which place the default choice at the top.
   
   NOTE: SVN r249751 changed things so that these menus highlight the active
   selection, so the idea that the default choice (now at top) "can be selected
   immediately by hitting ENTER" is not possible unless the default choice is
   the currently active setting (e.g., on first visit to the menu). However, it
   is still warranted to have the default choice at the top of the menu.
   
   PR:		bin/169316
 
 Modified:
   head/usr.sbin/bsdconfig/console/saver
 
 Modified: head/usr.sbin/bsdconfig/console/saver
 ==============================================================================
 --- head/usr.sbin/bsdconfig/console/saver	Tue Jun  4 16:48:23 2013	(r251389)
 +++ head/usr.sbin/bsdconfig/console/saver	Tue Jun  4 17:08:26 2013	(r251390)
 @@ -51,19 +51,19 @@ dialog_menu_main()
  {
  	local prompt="$msg_saver_menu_text"
  	local menu_list="
 -		'1 $msg_blank'   '$msg_blank_desc'
 -		'2 $msg_beastie' '$msg_beastie_desc'
 -		'3 $msg_daemon'  '$msg_daemon_desc'
 -		'4 $msg_dragon'  '$msg_dragon_desc'
 -		'5 $msg_fade'    '$msg_fade_desc'
 -		'6 $msg_fire'    '$msg_fire_desc'
 -		'7 $msg_green'   '$msg_green_desc'
 -		'8 $msg_logo'    '$msg_logo_desc'
 -		'9 $msg_rain'    '$msg_rain_desc'
 -		'a $msg_snake'   '$msg_snake_desc'
 -		'b $msg_star'    '$msg_star_desc'
 -		'c $msg_warp'    '$msg_warp_desc'
 -		'd $msg_none'    '$msg_none_saver_desc'
 +		'1 $msg_none'    '$msg_none_saver_desc'
 +		'2 $msg_blank'   '$msg_blank_desc'
 +		'3 $msg_beastie' '$msg_beastie_desc'
 +		'4 $msg_daemon'  '$msg_daemon_desc'
 +		'5 $msg_dragon'  '$msg_dragon_desc'
 +		'6 $msg_fade'    '$msg_fade_desc'
 +		'7 $msg_fire'    '$msg_fire_desc'
 +		'8 $msg_green'   '$msg_green_desc'
 +		'9 $msg_logo'    '$msg_logo_desc'
 +		'a $msg_rain'    '$msg_rain_desc'
 +		'b $msg_snake'   '$msg_snake_desc'
 +		'c $msg_star'    '$msg_star_desc'
 +		'd $msg_warp'    '$msg_warp_desc'
  		'$msg_timeout'   '$msg_timeout_desc'
  	" # END-QUOTE
  	local defaultitem= # Calculated below
 @@ -78,19 +78,19 @@ dialog_menu_main()
  	                        $menu_list
  
  	case "$( f_sysrc_get saver )" in
 -	blank)       defaultitem="1 $msg_blank"  ;;
 -	beastie)     defaultitem="2 $msg_beastie";;
 -	daemon)      defaultitem="3 $msg_daemon" ;;
 -	dragon)      defaultitem="4 $msg_dragon" ;;
 -	fade)        defaultitem="5 $msg_fade"   ;;
 -	fire)        defaultitem="6 $msg_fire"   ;;
 -	green)       defaultitem="7 $msg_green"  ;;
 -	logo)        defaultitem="8 $msg_logo"   ;;
 -	rain)        defaultitem="9 $msg_rain"   ;;
 -	snake)       defaultitem="a $msg_snake"  ;;
 -	star)        defaultitem="b $msg_star"   ;;
 -	warp)        defaultitem="c $msg_warp"   ;;
 -	[Nn][Oo]|'') defaultitem="d $msg_none"   ;;
 +	[Nn][Oo]|'') defaultitem="1 $msg_none"   ;;
 +	blank)       defaultitem="2 $msg_blank"  ;;
 +	beastie)     defaultitem="3 $msg_beastie";;
 +	daemon)      defaultitem="4 $msg_daemon" ;;
 +	dragon)      defaultitem="5 $msg_dragon" ;;
 +	fade)        defaultitem="6 $msg_fade"   ;;
 +	fire)        defaultitem="7 $msg_fire"   ;;
 +	green)       defaultitem="8 $msg_green"  ;;
 +	logo)        defaultitem="9 $msg_logo"   ;;
 +	rain)        defaultitem="a $msg_rain"   ;;
 +	snake)       defaultitem="b $msg_snake"  ;;
 +	star)        defaultitem="c $msg_star"   ;;
 +	warp)        defaultitem="d $msg_warp"   ;;
  	esac
  
  	local menu_choice
 @@ -141,45 +141,45 @@ while :; do
  	f_dialog_menutag_fetch mtag
  
  	case "$mtag" in
 -	"1 $msg_blank") # Simply blank the screen
 +	"1 $msg_none") # Disable the screensaver
 +		f_sysrc_set saver "NO" || f_die
 +		break ;;
 +	"2 $msg_blank") # Simply blank the screen
  		f_sysrc_set saver "blank" || f_die
  		break ;;
 -	"2 $msg_beastie") # "BSD Daemon" animated screen saver (graphics)
 +	"3 $msg_beastie") # "BSD Daemon" animated screen saver (graphics)
  		f_sysrc_set saver "beastie" || f_die
  		break ;;
 -	"3 $msg_daemon") # "BSD Daemon" animated screen saver (text)
 +	"4 $msg_daemon") # "BSD Daemon" animated screen saver (text)
  		f_sysrc_set saver "daemon" || f_die
  		break ;;
 -	"4 $msg_dragon") # Dragon screensaver (graphics)
 +	"5 $msg_dragon") # Dragon screensaver (graphics)
  		f_sysrc_set saver "dragon" || f_die
  		break ;;
 -	"5 $msg_fade") # Fade out effect screen saver
 +	"6 $msg_fade") # Fade out effect screen saver
  		f_sysrc_set saver "fade" || f_die
  		break ;;
 -	"6 $msg_fire") # Flames effect screen saver
 +	"7 $msg_fire") # Flames effect screen saver
  		f_sysrc_set saver "fire" || f_die
  		break ;;
 -	"7 $msg_green") # "Green" power saving mode (if supported by monitor)
 +	"8 $msg_green") # "Green" power saving mode (if supported by monitor)
  		f_sysrc_set saver "green" || f_die
  		break ;;
 -	"8 $msg_logo") # FreeBSD "logo" animated screen saver (graphics)
 +	"9 $msg_logo") # FreeBSD "logo" animated screen saver (graphics)
  		f_sysrc_set saver "logo" || f_die
  		break ;;
 -	"9 $msg_rain") # Rain drops screen saver
 +	"a $msg_rain") # Rain drops screen saver
  		f_sysrc_set saver "rain" || f_die
  		break ;;
 -	"a $msg_snake") # Draw a FreeBSD "snake" on your screen
 +	"b $msg_snake") # Draw a FreeBSD "snake" on your screen
  		f_sysrc_set saver "snake" || f_die
  		break ;;
 -	"b $msg_star") # A "twinkling stars" effect
 +	"c $msg_star") # A "twinkling stars" effect
  		f_sysrc_set saver "star" || f_die
  		break ;;
 -	"c $msg_warp") # A "stars warping" effect
 +	"d $msg_warp") # A "stars warping" effect
  		f_sysrc_set saver "warp" || f_die
  		break ;;
 -	"d $msg_none") # Disable the screensaver
 -		f_sysrc_set saver "NO" || f_die
 -		break ;;
  	"$msg_timeout") # Set the screen saver timeout interval
  		f_dialog_title "$msg_value_required"
  		f_dialog_input blanktime "$msg_enter_timeout_period" \
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169316: commit references a PR
Date: Sat,  8 Jun 2013 16:28:23 +0000 (UTC)

 Author: dteske
 Date: Sat Jun  8 16:28:08 2013
 New Revision: 251540
 URL: http://svnweb.freebsd.org/changeset/base/251540
 
 Log:
   Remove extraneous characters ('<<<') from `Exit' menutag in the "Security"
   and "Startup"->"Misc" modules to make the menus appear more consistent with
   the numerous other modules and look a little cleaner.
   
   PR:		ports/169316
 
 Modified:
   head/usr.sbin/bsdconfig/security/security
   head/usr.sbin/bsdconfig/startup/misc
 
 Modified: head/usr.sbin/bsdconfig/security/security
 ==============================================================================
 --- head/usr.sbin/bsdconfig/security/security	Sat Jun  8 16:24:49 2013	(r251539)
 +++ head/usr.sbin/bsdconfig/security/security	Sat Jun  8 16:28:08 2013	(r251540)
 @@ -51,7 +51,7 @@ dialog_menu_main()
  {
  	local prompt="$msg_menu_text"
  	local menu_list="
 -		'X <<< $msg_exit' '$msg_exit_this_menu'
 +		'X $msg_exit' '$msg_exit_this_menu'
  	" # END-QUOTE
  	local defaultitem= # Calculated below
  	local hline="$hline_arrows_tab_enter"
 @@ -158,7 +158,7 @@ while :; do
  	f_dialog_menutag_fetch mtag
  
  	case "$mtag" in
 -	"X <<< $msg_exit") break ;;
 +	"X $msg_exit") break ;;
  	"2 ["?"] $msg_securelevel") # Configure securelevels for the system
  		$BSDCFG_LIBE/$APP_DIR/kern_securelevel ${USE_XDIALOG:+-X} ;;
  	"3 [X] $msg_nfs_port") # Require that NFS clients use reserved ports
 
 Modified: head/usr.sbin/bsdconfig/startup/misc
 ==============================================================================
 --- head/usr.sbin/bsdconfig/startup/misc	Sat Jun  8 16:24:49 2013	(r251539)
 +++ head/usr.sbin/bsdconfig/startup/misc	Sat Jun  8 16:28:08 2013	(r251540)
 @@ -58,7 +58,7 @@ dialog_menu_main()
  {
  	local prompt="$msg_miscellaneous_menu_text"
  	local menu_list="
 -		'X <<< $msg_exit' '$msg_exit_this_menu'
 +		'X $msg_exit' '$msg_exit_this_menu'
  	" # END-QUOTE
  	local defaultitem= # Calculated below
  	local hline="$hline_arrows_tab_enter"
 @@ -345,7 +345,7 @@ while :; do
  	f_dialog_menutag_fetch mtag
  
  	case "$mtag" in
 -	"X <<< $msg_exit") break ;;
 +	"X $msg_exit") break ;;
  	?" ["?"] $msg_apm")
  		case "$mtag" in
  		?" [X] "*) err=$( f_sysrc_set apm_enable NO 2>&1 ) ;;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169316: commit references a PR
Date: Sat,  8 Jun 2013 16:49:31 +0000 (UTC)

 Author: dteske
 Date: Sat Jun  8 16:49:19 2013
 New Revision: 251541
 URL: http://svnweb.freebsd.org/changeset/base/251541
 
 Log:
   Reduce verbosity in the "Console"->"Saver" module (bsdconfig syscons_saver)
   by replacing the infinitive [verb] phrase "Simply blank the screen" with a
   simple description of what you get; "Blank screen".
   
   PR:		ports/169316
 
 Modified:
   head/usr.sbin/bsdconfig/console/include/messages.subr
 
 Modified: head/usr.sbin/bsdconfig/console/include/messages.subr
 ==============================================================================
 --- head/usr.sbin/bsdconfig/console/include/messages.subr	Sat Jun  8 16:28:08 2013	(r251540)
 +++ head/usr.sbin/bsdconfig/console/include/messages.subr	Sat Jun  8 16:49:19 2013	(r251541)
 @@ -36,7 +36,7 @@ msg_beastie_desc="\"BSD Daemon\" animate
  msg_belgian="Belgian"
  msg_belgian_desc="Belgian ISO keymap"
  msg_blank="Blank"
 -msg_blank_desc="Simply blank the screen"
 +msg_blank_desc="Blank screen"
  msg_brazil_cp850="Brazil CP850"
  msg_brazil_cp850_desc="Brazil CP850 keymap"
  msg_brazil_iso="Brazil ISO"
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: "Teske, Devin" <Devin.Teske@fisglobal.com>
To: "<bug-followup@FreeBSD.org>" <bug-followup@FreeBSD.org>,
        J B
	<jb.1234abcd@gmail.com>
Cc:  
Subject: Re: ports/169316: sysutils/bsdconfig test results and fixes
Date: Sat, 8 Jun 2013 17:03:24 +0000

 Having another look at this PR now that we've progressed significantly (to =
 the point where I can now start focusing on code clean-up, consistencies, a=
 nd other general updates such as those mentioned in this PR).
 
 =3D=3D=3D
 
 As previously mentioned w/respect to Disk Partitioning:
 
 That module forks off to sade(8) (which is now a pointer to "bsdinstall par=
 tedit"). So changes there will have to wait until I get to the bsdinstall c=
 ode.
 
 No changes committed.
 
 =3D=3D=3D
 
 W/respect to "Exit this menu (returning to previous)" being too verbose for=
  the Login Management, Console, Mouse, Security, and (previously unmentione=
 d -- probably because it didn't exist at the time this PR was filed) the St=
 artup modules:
 
 I agree and am making the necessary changes.
 
 Across all the mentioned modules, the consistent behavior is to now:
 
 a. If a menu uses both tags and items (such as "Console", "Mouse", "Securit=
 y", and "Startup"), use "Exit" for the tag and "Exit this menu" for the item
 
 b. If a menu uses only tags (such as "Login Management"), use "Exit" as the=
  tag (same tag value as (a) above).
 
 Changes committed via SVN r251389.
 
 =3D=3D=3D
 
 With respect to the the extra leading "<<<" characters to the left of the "=
 Exit" tag in the "Security" module.
 
 Was emulating sysinstall (verbatim). After much testing, I've decided to fo=
 llow the PR's recommendation and remove them.
 
 Changes committed via SVN r251540.
 
 =3D=3D=3D
 
 With respect to the "wrong position in menu" argument=85 6 weeks ago, I mad=
 e an enhancement to the code (SVN r249751) that selects the currently-activ=
 e value as the default item, so the menu (Console for example) now is dual-=
 purpose in that it shows you the active selection as well as allowing you t=
 o change the active selection.
 
 However=85 because I sympathize with the argument from this PR, I have also=
  moved the "Default" (or "None" in the case of Console->Saver) choice to th=
 e top (just note however that it may not be highlighted unless it is the ac=
 tive choice or no choice is currently active).
 
 FYI: Because of the new "highlight the active selection by default" feature=
  (again, SVN r249751) the idea that the default choice "can be selected imm=
 ediately by hitting ENTER" is incorrect (regardless of where the default it=
 em is). However, I do agree that the default item should be at the top.
 
 NOTE: In the case of Console->Repeat, the moving of the default choice to t=
 he top was already accomplished by SVN r249751.
 
 Changes committed via SVN r251390.
 
 =3D=3D=3D
 
 With respect to "Simply blank the screen" being too verbose (and suggestion=
  to replace with "Blank screen").
 
 Agreed.
 
 Changes committed via SVN r251541.
 
 =3D=3D=3D
 
 With respect to adding the following text to the Timezone module:
 
 "If the [sic] other OS manages and adjusts the local time, then users shoul=
 d select local time."
 
 I find that the text does not (regardless of typo) accurately represent the=
  situation for multi-OS hardware/customers.
 
 The UTC versus "Local Time" question is about your BIOS. Regardless of whet=
 her you have multiple OSes or not, your BIOS is free to be in UTC or "Local=
  Time" (HINT: Just as FreeBSD can be told that the BIOS is in UTC, so can t=
 he other OS; and vice-versa if the BIOS is set to "Local Time"). The only d=
 ifference is that when your BIOS is in UTC, every OS will have to set a tim=
 ezone; meanwhile if your BIOS is in "Local Time", then each OS needs to add=
 itionally be informed that the BIOS (CMOS) clock represents "Wall Time" in =
 your Locale.
 
 Saying that your BIOS must be in "Local Time" or "UTC" based on whether  "[=
 an]other OS manages and adjusts the local time" is not accurate in my opini=
 on.
 
 No changes committed.
 
 =3D=3D=3D
 
 Thank you for taking the time to test bsdconfig and reporting these problem=
 s. I look forward to any/all future feedback.
 --=20
 Devin
 
 NOTE: Looks like in the PR you were using bsdconfig-0.7.2. I'll spin a new =
 version with these enhancements from this PR. Latest version is 0.8.3, but =
 expect 0.8.4 or higher to include these (from this PR; and many more) enhan=
 cements not found in 0.8.3.
 
 _____________
 The information contained in this message is proprietary and/or confidentia=
 l. If you are not the intended recipient, please: (i) delete the message an=
 d all copies; (ii) do not disclose, distribute or use the message in any ma=
 nner; and (iii) notify the sender immediately. In addition, please be aware=
  that any message addressed to our domain is subject to archiving and revie=
 w by persons other than the intended recipient. Thank you.
State-Changed-From-To: open->closed 
State-Changed-By: dteske 
State-Changed-When: Tue Apr 1 00:37:05 UTC 2014 
State-Changed-Why:  
Thanks for the feedback! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169316 
>Unformatted:
