From jhelfman@experts-exchange.com  Mon Jun 18 23:45:40 2012
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AA9B01065672;
	Mon, 18 Jun 2012 23:45:40 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 89DC08FC0A;
	Mon, 18 Jun 2012 23:45:40 +0000 (UTC)
Received: from mail.dw.redsrci.com (localhost [127.0.0.1])
	by mail.dw.redsrci.com (Postfix) with ESMTP id 77B2D6FDA48;
	Mon, 18 Jun 2012 16:45:40 -0700 (PDT)
Received: from mail.dw.redsrci.com ([127.0.0.1])
	by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 30QM8IOVyy9E; Mon, 18 Jun 2012 16:45:40 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.dw.redsrci.com (Postfix) with SMTP id 53FFE6FDA47;
	Mon, 18 Jun 2012 16:45:40 -0700 (PDT)
Received: (nullmailer pid 25155 invoked by uid 1001);
	Mon, 18 Jun 2012 23:44:06 -0000
Message-Id: <1340063046.270576.25154.nullmailer@experts-exchange.com>
Date: Mon, 18 Jun 2012 16:44:06 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: vbox@FreeBSD.org
Subject: [PATCH] emulators/virtualbox-ose: fix usage of ${SRC_BASE} before it is defined
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         169223
>Category:       ports
>Synopsis:       [PATCH] emulators/virtualbox-ose: fix usage of ${SRC_BASE} before it is defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 18 23:50:22 UTC 2012
>Closed-Date:    Sun Jul 01 23:09:07 UTC 2012
>Last-Modified:  Sun Jul  1 23:50:07 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.3-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr  9 21:23:18 UTC
>Description:
Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

pet portlint on license placement

Port maintainer (vbox@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- virtualbox-ose-4.1.16_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/emulators/virtualbox-ose/Makefile,v
retrieving revision 1.52
diff -u -r1.52 Makefile
--- Makefile	6 Jun 2012 06:43:44 -0000	1.52
+++ Makefile	18 Jun 2012 23:44:56 -0000
@@ -20,6 +20,9 @@
 MAINTAINER=	vbox@FreeBSD.org
 COMMENT=	A general-purpose full virtualizer for x86 hardware
 
+LICENSE=	GPLv2
+LICENSE_FILE=	${WRKSRC}/COPYING
+
 BUILD_DEPENDS=	yasm:${PORTSDIR}/devel/yasm \
 		as86:${PORTSDIR}/devel/dev86 \
 		xsltproc:${PORTSDIR}/textproc/libxslt \
@@ -30,9 +33,6 @@
 		curl.6:${PORTSDIR}/ftp/curl
 RUN_DEPENDS=	/boot/modules/vboxdrv.ko:${PORTSDIR}/emulators/virtualbox-ose-kmod
 
-LICENSE=	GPLv2
-LICENSE_FILE=	${WRKSRC}/COPYING
-
 WRKSRC=		${WRKDIR}/VirtualBox-${PORTVERSION}
 ONLY_FOR_ARCHS=	i386 amd64
 USE_CDRTOOLS=	yes
@@ -81,10 +81,6 @@
 SUB_LIST+=	VBOXUSER=${VBOXUSER}
 USE_RC_SUBR+=	vboxheadless
 
-KMK_BUILDTYPE=	release
-KMK_CONFIG=	VBOX_LIBPATH_X11=${LOCALBASE} VBOX_FREEBSD_SRC=${SRC_BASE}/sys
-KMK_FLAGS=
-
 .if defined(WITHOUT_QT4) && !defined(WITHOUT_NLS)
 BROKEN=		NLS support requires QT4 frontend. Run 'make config' again!
 .endif
@@ -125,6 +121,12 @@
 PLIST_SUB+=	GUESTADDITIONS="@comment "
 .endif
 
+.include <bsd.port.pre.mk>
+
+KMK_BUILDTYPE=	release
+KMK_CONFIG=	VBOX_LIBPATH_X11=${LOCALBASE} VBOX_FREEBSD_SRC=${SRC_BASE}/sys
+KMK_FLAGS=
+
 .if defined(WITH_DEBUG)
 KMK_FLAGS+=	BUILD_TYPE=debug
 KMK_BUILDTYPE=	debug
@@ -175,8 +177,6 @@
 PLIST_SUB+=	I386="@comment "
 .endif
 
-.include <bsd.port.pre.mk>
-
 .if ${OSVERSION} < 802000
 BROKEN=		Does not compile on FreeBSD < 8.2
 .endif
--- virtualbox-ose-4.1.16_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->vbox 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 18 23:51:02 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169223 
Responsible-Changed-From-To: vbox->jgh 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Sun Jul 1 06:34:55 UTC 2012 
Responsible-Changed-Why:  
maintainer timeout (14 days) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169223 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169223: commit references a PR
Date: Sun,  1 Jul 2012 22:52:55 +0000 (UTC)

 jgh         2012-07-01 22:52:41 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/virtualbox-ose Makefile 
   Log:
   - re-order, include bsd.port.pre.mk so SRC_BASE is defined before referenced
   - pet portlint on placement of LICENSE
   
   PR:     ports/169223
   Submitted by:   jgh@
   Approved by:    maintainer timeout ( 14 days )
   
   Revision  Changes    Path
   1.54      +5 -5      ports/emulators/virtualbox-ose/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: jgh 
State-Changed-When: Sun Jul 1 23:09:07 UTC 2012 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169223 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169223: commit references a PR
Date: Sun,  1 Jul 2012 23:41:41 +0000 (UTC)

 jgh         2012-07-01 23:41:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/virtualbox-ose Makefile 
   Log:
   - revert previous commit, index breakage
   
   PR:     ports/169223
   VS: ----------------------------------------------------------------------
   
   Revision  Changes    Path
   1.55      +5 -5      ports/emulators/virtualbox-ose/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
