From jhelfman@experts-exchange.com  Mon Jun 18 23:29:23 2012
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B6E461065672
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 18 Jun 2012 23:29:23 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 95B048FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 18 Jun 2012 23:29:23 +0000 (UTC)
Received: from mail.dw.redsrci.com (localhost [127.0.0.1])
	by mail.dw.redsrci.com (Postfix) with ESMTP id 8F87C6FDA2D;
	Mon, 18 Jun 2012 16:29:23 -0700 (PDT)
Received: from mail.dw.redsrci.com ([127.0.0.1])
	by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 75V4oeX+7GvI; Mon, 18 Jun 2012 16:29:23 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.dw.redsrci.com (Postfix) with SMTP id 6B7186FDA30;
	Mon, 18 Jun 2012 16:29:23 -0700 (PDT)
Received: (nullmailer pid 56285 invoked by uid 1001);
	Mon, 18 Jun 2012 23:27:49 -0000
Message-Id: <1340062069.466114.56284.nullmailer@experts-exchange.com>
Date: Mon, 18 Jun 2012 16:27:49 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: admin@lissyara.su
Subject: [PATCH] net/skystar2: fix usage of ${SRC_BASE} before it is defined
X-Send-Pr-Version: 3.113
X-GNATS-Notify: admin@lissyara.su

>Number:         169216
>Category:       ports
>Synopsis:       [PATCH] net/skystar2: fix usage of ${SRC_BASE} before it is defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 18 23:30:19 UTC 2012
>Closed-Date:    Sun Jul 01 22:58:11 UTC 2012
>Last-Modified:  Sun Jul 01 22:58:11 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.3-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr  9 21:23:18 UTC
>Description:
 
Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

pet portlint on pkg-message and placement of USE_BZIP2

Port maintainer (admin@lissyara.su) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- skystar2-1.32,1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/net/skystar2/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- Makefile	1 Apr 2010 05:27:58 -0000	1.12
+++ Makefile	18 Jun 2012 23:28:21 -0000
@@ -17,6 +17,9 @@
 COMMENT=	Kernel module and program for SkyStar2/SkyStar2.8A, ver. ${PORTVERSION}
 
 USE_BZIP2=	yes
+
+.include <bsd.port.pre.mk>
+
 SYSDIR?=	${SRC_BASE}/sys
 KMODDIR=	/boot/modules
 PLIST_SUB+=	KMODDIR=${KMODDIR}
@@ -49,8 +52,6 @@
 .endfor
 .endif
 
-.include <bsd.port.pre.mk>
-
 .if ${ARCH} == "ia64" || ${ARCH} == "powerpc" || ${ARCH} == "sparc64"
 BROKEN=		Does not compile on ia64, powerprc, or sparc64
 .elif ${OSVERSION} >= 900000
Index: pkg-message
===================================================================
RCS file: /home/pcvs/ports/net/skystar2/pkg-message,v
retrieving revision 1.2
diff -u -r1.2 pkg-message
--- pkg-message	3 Jun 2008 18:12:12 -0000	1.2
+++ pkg-message	18 Jun 2012 23:28:21 -0000
@@ -11,5 +11,3 @@
 
 to your /boot/loader.conf.
 *********************************************************************
-
-
--- skystar2-1.32,1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jgh 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 18 23:31:18 UTC 2012 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169216 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Jun 18 23:31:29 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169216 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: admin@lissyara.su
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/169216: [PATCH] net/skystar2: fix usage of ${SRC_BASE} before it is defined
Date: Mon, 18 Jun 2012 23:31:24 UT

 Maintainer of net/skystar2,
 
 Please note that PR ports/169216 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169216
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->open 
State-Changed-By: jgh 
State-Changed-When: Sun Jul 1 06:35:49 UTC 2012 
State-Changed-Why:  
maintainer timeout (14 days) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169216 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169216: commit references a PR
Date: Sun,  1 Jul 2012 22:32:09 +0000 (UTC)

 jgh         2012-07-01 22:31:53 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/skystar2         Makefile pkg-message 
   Log:
   - re-order, include bsd.port.pre.mk so SRC_BASE is defined before referenced
   - pet portlint (empty lines in pkg-message)
   
   PR:     ports/169216
   Submitted by:   jgh@
   Approved by:    maintainer timeout ( 14 days )
   
   Revision  Changes    Path
   1.13      +3 -2      ports/net/skystar2/Makefile
   1.3       +0 -2      ports/net/skystar2/pkg-message
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: jgh 
State-Changed-When: Sun Jul 1 22:58:10 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169216 
>Unformatted:
