From jhelfman@experts-exchange.com  Mon Jun 18 23:19:22 2012
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AFB3B1065806;
	Mon, 18 Jun 2012 23:19:22 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 8EB0A8FC15;
	Mon, 18 Jun 2012 23:19:22 +0000 (UTC)
Received: from mail.dw.redsrci.com (localhost [127.0.0.1])
	by mail.dw.redsrci.com (Postfix) with ESMTP id 434046FD9EC;
	Mon, 18 Jun 2012 16:19:22 -0700 (PDT)
Received: from mail.dw.redsrci.com ([127.0.0.1])
	by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id RyP3uxXug4Vo; Mon, 18 Jun 2012 16:19:22 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.dw.redsrci.com (Postfix) with SMTP id 1F7D06FD9CA;
	Mon, 18 Jun 2012 16:19:22 -0700 (PDT)
Received: (nullmailer pid 21117 invoked by uid 1001);
	Mon, 18 Jun 2012 23:17:48 -0000
Message-Id: <1340061468.158863.21105.nullmailer@experts-exchange.com>
Date: Mon, 18 Jun 2012 16:17:48 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jkim@FreeBSD.org
Subject: [PATCH] audio/oss: fix usage of ${SRC_BASE} before it is defined
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         169212
>Category:       ports
>Synopsis:       [PATCH] audio/oss: fix usage of ${SRC_BASE} before it is defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jkim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 18 23:20:08 UTC 2012
>Closed-Date:    Mon Jun 25 20:52:30 UTC 2012
>Last-Modified:  Mon Jun 25 21:00:25 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.3-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr  9 21:23:18 UTC
>Description:

Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to 
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

Port maintainer (jkim@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- oss-4.2.b2006_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/audio/oss/Makefile,v
retrieving revision 1.49
diff -u -r1.49 Makefile
--- Makefile	4 Jun 2012 18:09:14 -0000	1.49
+++ Makefile	18 Jun 2012 23:17:46 -0000
@@ -55,6 +55,8 @@
 PROTO_MANDIR=	${PROTO_DIR}/usr/share/man
 PROTO_OSSLIBDIR=${PROTO_DIR}${PREFIX}/lib/oss
 
+.include <bsd.port.pre.mk>
+
 .if !exists(${SRC_BASE}/sys/Makefile)
 IGNORE=		requires kernel source to be installed
 .endif
--- oss-4.2.b2006_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jkim 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 18 23:20:20 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169212 
State-Changed-From-To: open->closed 
State-Changed-By: jkim 
State-Changed-When: Mon Jun 25 20:52:05 UTC 2012 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169212 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169212: commit references a PR
Date: Mon, 25 Jun 2012 20:51:49 +0000 (UTC)

 jkim        2012-06-25 20:51:35 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/oss            Makefile 
   Log:
   Include bsd.port.pre.mk before SRC_BASE is referenced.
   
   PR:     ports/169212
   
   Revision  Changes    Path
   1.50      +7 -5      ports/audio/oss/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
