From nobody@FreeBSD.org  Sat Jun 16 07:39:22 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E99D6106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 16 Jun 2012 07:39:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id BB9F58FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 16 Jun 2012 07:39:22 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5G7dMtY088550
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 16 Jun 2012 07:39:22 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q5G7dMk4088549;
	Sat, 16 Jun 2012 07:39:22 GMT
	(envelope-from nobody)
Message-Id: <201206160739.q5G7dMk4088549@red.freebsd.org>
Date: Sat, 16 Jun 2012 07:39:22 GMT
From: Green Dog <fiziologus@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [games/wesnoth] NLS is broken
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         169144
>Category:       ports
>Synopsis:       games/wesnoth: NLS is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ak
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 16 07:40:09 UTC 2012
>Closed-Date:    Tue Jul 10 17:21:58 UTC 2012
>Last-Modified:  Tue Jul 10 17:21:58 UTC 2012
>Originator:     Green Dog
>Release:        FreeBSD-9.0
>Organization:
>Environment:
>Description:
NLS doesn't work even when the game is built WITH_NLS. Removing files/patch-src-gettext.* fixes this. 
>How-To-Repeat:
Build wesnoth with NLS enabled, run `env LC_ALL=ru_RU.UTF-8 wesnoth`, see no localization.
>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->philip 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jun 16 16:21:03 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169144 

From: Jan Beich <jbeich@tormail.org>
To: Green Dog <fiziologus@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/169144: [games/wesnoth] NLS is broken
Date: Sat, 16 Jun 2012 09:18:40 -0500

 --=-=-=
 Content-Type: text/plain
 Content-Disposition: inline
 
 Can you test? Looks like cmake build doesn't define ENABLE_NLS unlike autoconf.
 I've tested with LC_MESSAGES=ru_RU.UTF-8 and a few other locales.
 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: attachment; filename=nls.diff
 
 Index: games/wesnoth/files/patch-CMakeLists.txt
 ===================================================================
 RCS file: /a/.csup/ports/games/wesnoth/files/patch-CMakeLists.txt,v
 retrieving revision 1.1
 diff -u -p -r1.1 patch-CMakeLists.txt
 --- games/wesnoth/files/patch-CMakeLists.txt	10 Jun 2012 13:08:48 -0000	1.1
 +++ games/wesnoth/files/patch-CMakeLists.txt	16 Jun 2012 13:57:00 -0000
 @@ -48,6 +48,18 @@
   				CACHE STRING "Flags used by the CXX compiler during release builds." FORCE)
   
   	endif(NOT CONFIGURED)
 +@@ -158,6 +157,11 @@ if(X11_FOUND)
 + 	add_definitions(-D_X11)
 + endif(X11_FOUND)
 + 
 ++if(ENABLE_NLS)
 ++	set(CMAKE_C_FLAGS "-DENABLE_NLS ${CMAKE_C_FLAGS}")
 ++	set(CMAKE_CXX_FLAGS "-DENABLE_NLS ${CMAKE_CXX_FLAGS}")
 ++endif(ENABLE_NLS)
 ++
 + add_definitions(-DLOCALEDIR=\\\"${LOCALEDIR}\\\")
 + 
 + # When the path starts with a / on a Unix system it's an absolute path.
  @@ -154,6 +153,7 @@ add_definitions(-DLOCALEDIR=\\\"${LOCALE
   if(LOCALEDIR MATCHES "^/")
   	add_definitions(-DHAS_RELATIVE_LOCALEDIR=0)
 
 --=-=-=--

From: Jan Beich <jbeich@tormail.org>
To: green dog <fiziologus@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/169144: [games/wesnoth] NLS is broken
Date: Tue, 19 Jun 2012 06:55:53 +1200

 green dog <fiziologus@gmail.com> writes:
 
 > 2012/6/16 Jan Beich <jbeich@tormail.org>
 >
 >> Can you test? Looks like cmake build doesn't define ENABLE_NLS unlike
 >> autoconf.
 >> I've tested with LC_MESSAGES=ru_RU.UTF-8 and a few other locales.
 >>
 >>
 > work
 
 Good. And don't drop bug-followup@ from CC unless you want the PR to end
 up in `feedback' state.
Responsible-Changed-From-To: philip->ak 
Responsible-Changed-By: ak 
Responsible-Changed-When: Mon Jul 9 16:03:57 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169144 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169144: commit references a PR
Date: Tue, 10 Jul 2012 17:19:54 +0000 (UTC)

 ak          2012-07-10 17:19:40 UTC
 
   FreeBSD ports repository
 
   Modified files:
     games/wesnoth        Makefile 
     games/wesnoth/files  patch-CMakeLists.txt 
   Log:
   - Fix NLS support [1]
   - Give maintainership to Rusty Nejdl <rnejdl@ringofsaturn.com>
   - Remove ABI version numbers in LIB_DEPENDS
   - Convert to new options framework
   
   PR:     ports/169144 [1]
   Submitted by:   Green Dog <fiziologus@gmail.com>, Jan Beich <jbeich@tormail.org> [1]
   
   Revision  Changes    Path
   1.99      +65 -61    ports/games/wesnoth/Makefile
   1.2       +20 -9     ports/games/wesnoth/files/patch-CMakeLists.txt
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: ak 
State-Changed-When: Tue Jul 10 17:21:58 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169144 
>Unformatted:
