From koobs.freebsd@gmail.com  Thu Jun 14 13:10:57 2012
Return-Path: <koobs.freebsd@gmail.com>
Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 469561065673
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 Jun 2012 13:10:57 +0000 (UTC)
	(envelope-from koobs.freebsd@gmail.com)
Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 18B748FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 Jun 2012 13:10:57 +0000 (UTC)
Received: by dadv36 with SMTP id v36so2660058dad.13
        for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 Jun 2012 06:10:56 -0700 (PDT)
Received: by 10.68.135.201 with SMTP id pu9mr7852132pbb.146.1339679456705;
        Thu, 14 Jun 2012 06:10:56 -0700 (PDT)
Received: from freebsd-90-amd64.elysium (ppp59-167-128-11.static.internode.on.net. [59.167.128.11])
        by mx.google.com with ESMTPS id hw6sm9469398pbc.73.2012.06.14.06.10.54
        (version=TLSv1/SSLv3 cipher=OTHER);
        Thu, 14 Jun 2012 06:10:55 -0700 (PDT)
Received: by freebsd-90-amd64.elysium (Postfix, from userid 1001)
	id 0849017D45; Thu, 14 Jun 2012 23:10:49 +1000 (EST)
Message-Id: <20120614131050.0849017D45@freebsd-90-amd64.elysium>
Date: Thu, 14 Jun 2012 23:10:49 +1000 (EST)
From: koobs <koobs.freebsd@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] security/py27-oauthlib: Fix PKGORIGIN
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         169068
>Category:       ports
>Synopsis:       [MAINTAINER] security/py27-oauthlib: Fix PKGORIGIN
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 14 13:20:01 UTC 2012
>Closed-Date:    Fri Jun 15 11:24:30 UTC 2012
>Last-Modified:  Fri Jun 15 11:30:01 UTC 2012
>Originator:     koobs
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD freebsd-90-amd64.elysium 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Sat May  5 14:51:14 EST
>Description:
- Fix PKGORIGIN

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- py27-oauthlib-0.1.3.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/security/py-oauthlib/Makefile ./Makefile
--- /usr/ports/security/py-oauthlib/Makefile	2012-06-14 10:36:22.000000000 +1000
+++ ./Makefile	2012-06-14 23:09:49.000000000 +1000
@@ -7,7 +7,7 @@
 
 PORTNAME=	oauthlib
 PORTVERSION=	0.1.3
-CATEGORIES=	net python
+CATEGORIES=	security net python
 MASTER_SITES=	CHEESESHOP
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 
--- py27-oauthlib-0.1.3.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->rm 
Responsible-Changed-By: rm 
Responsible-Changed-When: Thu Jun 14 13:31:55 UTC 2012 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169068 

From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
To: koobs <koobs.freebsd@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/169068: [MAINTAINER] security/py27-oauthlib: Fix PKGORIGIN
Date: Thu, 14 Jun 2012 18:04:48 +0400

 This is a multi-part message in MIME format.
 --------------030908040409090704060600
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Hi koobs,
 
 In first may I ask you to not add py27 prefix when filling pr next time? 
 :). GNATS tries (in simple-case) to auto-assign pr by checking this line 
 for portname. There is no such port security/py27-oauthlib, but there is 
 security/py-oauthlib. Please just omit this 27 prefix next time. Thank 
 you in advance.
 
 I just reviewed the port and want to suggest some changes. Here is the 
 patch, that:
 - adds some tabs in Makefile header for aligning
 - removes LICENSE_FILE knob, because it doesn't needed for well-known
    licenses
 - py-rsa needs both at build time (for tests, if they are used) and run
    time (for signature module), so it adds py-rsa to RUN_DEPENDS too.
 - marks this port python3 ready
 
 The last and the most contradictory - why you need to unpack the egg 
 before installing it? In my patch I removed all the custom easy_install 
 args and moved pkg-plist into a Makefile:PLIST_FILES. It works just 
 fine, but I'm not sure, may be you had a specific reason to do so..
 
 What do you say? Do you approve?
 
 -- 
 Regards,
 Ruslan
 
 Tinderboxing kills... the drives.
 
 --------------030908040409090704060600
 Content-Type: text/plain; charset=UTF-8;
  name="py-oauthlib.diff.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="py-oauthlib.diff.txt"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/security/py-oauthlib/Makefile,v
 retrieving revision 1.1
 diff -u -r1.1 Makefile
 --- Makefile	14 Jun 2012 00:36:22 -0000	1.1
 +++ Makefile	14 Jun 2012 13:42:54 -0000
 @@ -1,13 +1,13 @@
  # New ports collection makefile for:	py-oauthlib
 -# Date created:		2012-05-23
 -# Whom:			koobs <koobs.freebsd@gmail.com>
 +# Date created:				2012-05-23
 +# Whom:					koobs <koobs.freebsd@gmail.com>
  #
  # $FreeBSD: ports/security/py-oauthlib/Makefile,v 1.1 2012/06/14 00:36:22 tj Exp $
  #
  
  PORTNAME=	oauthlib
  PORTVERSION=	0.1.3
 -CATEGORIES=	net python
 +CATEGORIES=	security net python
  MASTER_SITES=	CHEESESHOP
  PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
  
 @@ -15,16 +15,14 @@
  COMMENT=	An RFC-compliant Python implementation of OAuth
  
  LICENSE=	BSD
 -LICENSE_FILE=	${WRKSRC}/LICENSE
  
 -BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}rsa>=0:${PORTSDIR}/security/py-rsa
 +BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}rsa>0:${PORTSDIR}/security/py-rsa
 +RUN_DEPENDS:=	${BUILD_DEPENDS}
  
 +# Python3 ready
  USE_PYTHON=	yes
  USE_PYDISTUTILS=easy_install
  
 -PYDISTUTILS_INSTALLARGS=	-Z -q -O 1 -N -S ${PYTHON_SITELIBDIR} \
 -				-d ${PYEASYINSTALL_SITELIBDIR} \
 -				-s ${PYEASYINSTALL_BINDIR} \
 -				${WRKSRC}/dist/${PYEASYINSTALL_EGG}
 +PLIST_FILES=	%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%
  
  .include <bsd.port.mk>
 Index: pkg-plist
 ===================================================================
 RCS file: pkg-plist
 diff -N pkg-plist
 --- pkg-plist	14 Jun 2012 00:36:22 -0000	1.1
 +++ /dev/null	1 Jan 1970 00:00:00 -0000
 @@ -1,47 +0,0 @@
 -@comment $FreeBSD: ports/security/py-oauthlib/pkg-plist,v 1.1 2012/06/14 00:36:22 tj Exp $
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/__init__.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/common.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/__init__.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/common.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/__init__.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/__init__.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/__init__.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/parameters.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/signature.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/utils.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/__init__.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/parameters.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/signature.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/utils.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/__init__.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/parameters.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/signature.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849/utils.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/__init__.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/__init__.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/__init__.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25/__init__.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25/tokens.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25/utils.py
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25/__init__.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25/tokens.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25/utils.pyc
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25/__init__.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25/tokens.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25/utils.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/__init__.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/__init__.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/common.pyo
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/EGG-INFO/PKG-INFO
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/EGG-INFO/SOURCES.txt
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/EGG-INFO/dependency_links.txt
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/EGG-INFO/requires.txt
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/EGG-INFO/top_level.txt
 -%%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/EGG-INFO/zip-safe
 -@dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2/draft25
 -@dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth2
 -@dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1/rfc5849
 -@dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib/oauth1
 -@dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/oauthlib
 -@dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/EGG-INFO
 -@dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%/
 
 --------------030908040409090704060600--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169068: commit references a PR
Date: Thu, 14 Jun 2012 14:28:39 +0000 (UTC)

 rm          2012-06-14 14:28:25 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/py-oauthlib Makefile 
   Log:
   - correct port category
   
   PR:             169068
   Submitted by:   koobs <koobs.freebsd at gmail dot com> (maintainer)
   
   Revision  Changes    Path
   1.2       +1 -1      ports/security/py-oauthlib/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->feedback 
State-Changed-By: rm 
State-Changed-When: Thu Jun 14 14:31:26 UTC 2012 
State-Changed-Why:  
Original patch committed. Waiting for maintainer's feedback about 
proposed changes. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169068 

From: koobs k <koobs.freebsd@gmail.com>
To: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
Cc: bug-followup@freebsd.org
Subject: Re: ports/169068: [MAINTAINER] security/py27-oauthlib: Fix PKGORIGIN
Date: Fri, 15 Jun 2012 18:55:45 +1000

 Absolutely approve, I'm the padawan here :)
 
 To address each point individually:
 
 > In first may I ask you to not add py27 prefix when filling pr next time? =
 :).
 
 I use porttools `port submit` to send-pr's and it is generating the
 Synopsis field. In this case I forgot to remove '27'. Perhaps a patch
 to omit *_PKGNAMEPREFIX from the generated Synopsis would be handy
 here?
 
 > I just reviewed the port and want to suggest some changes. Here is the
 > patch, that:
 > - adds some tabs in Makefile header for aligning
 
 Again i'm using the standard porttools port create template here. I
 assumed defaults were good, clean and safe :)
 
 > - removes LICENSE_FILE knob, because it doesn't needed for well-known
 > =C2=A0licenses
 
 Learned this last week and not doing this for BSD/GPLvX/MIT anymore.
 What constitutes 'well-known' ?
 
 > - py-rsa needs both at build time (for tests, if they are used) and run
 > =C2=A0time (for signature module), so it adds py-rsa to RUN_DEPENDS too.
 > - marks this port python3 ready
 
 Good to know, thank you, although I'm not 100% on this. What if the
 tests require non-stldlib nose/someotherpymod, do I BUILD_DEPEND these
 too? Or PORT_OPTIONS MTESTS to conditionally add it?
 
 > The last and the most contradictory - why you need to unpack the egg befo=
 re
 > installing it? In my patch I removed all the custom easy_install args and
 > moved pkg-plist into a Makefile:PLIST_FILES. It works just fine, but I'm =
 not
 > sure, may be you had a specific reason to do so..
 
 There is a bigger conversation happening about adding default -Z args
 in bsd.python.mk and moving onto py-distribute among other things.
 Alot of python modules do not set zip_safe=3DFalse when they should and
 there's no easy way to preffix-override PYEASINSTALL_ARGS.
 
 That leaves the choice of this, or patch setup.py. Having thought
 about it, i'll go the patch setup.py route from here on unless you
 have ideas?
 
 > What do you say? Do you approve?
 
 Absolutely, and thank you for the feedback
 
 Regards,
 
 Koobs

From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
To: koobs k <koobs.freebsd@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/169068: [MAINTAINER] security/py27-oauthlib: Fix PKGORIGIN
Date: Fri, 15 Jun 2012 15:08:17 +0400

 koobs k wrote on 15.06.2012 12:55:
 
 > I use porttools `port submit` to send-pr's and it is generating the
 > Synopsis field. In this case I forgot to remove '27'. Perhaps a patch
 > to omit *_PKGNAMEPREFIX from the generated Synopsis would be handy
 > here?
 
 Understood. I didn't know about this porttools feature and believe this 
 is incorrect. I'll look at this and tabs issue and will submit it as an 
 pr, thanks for clarifying :).
 
 >> - removes LICENSE_FILE knob, because it doesn't needed for well-known
 >>   licenses
 >
 > Learned this last week and not doing this for BSD/GPLvX/MIT anymore.
 > What constitutes 'well-known' ?
 
 You may treat it as `popular' I believe, this is about my poor English 
 skills. Generally, it's safe to omit this knob for any license listed in 
 Mk/bsd.licenses.db.mk
 
 >
 >> - py-rsa needs both at build time (for tests, if they are used) and run
 >>   time (for signature module), so it adds py-rsa to RUN_DEPENDS too.
 >> - marks this port python3 ready
 >
 > Good to know, thank you, although I'm not 100% on this. What if the
 > tests require non-stldlib nose/someotherpymod, do I BUILD_DEPEND these
 > too? Or PORT_OPTIONS MTESTS to conditionally add it?
 
 I just grep'd for rsa and see that is used signature.py (hence runtime 
 dependency) and for build it is only needed in tests. It's safe to 
 remove it from BUILD_DEPENDS at all, because we have not (yet) any 
 automatically tests running for python ports. If port testing framework 
 using nose, than tests will fail if it's not installed on build stage. 
 But, as I wright before, it's not important right now, because packaging 
 will succeed anyway. But there is one caveat - if the port has support 
 for building documentation (with py-sphinx for example), then someone 
 need to check port build with py-sphinx installed, because packing list 
 may (and in 80% cases will) changes because of the docs installed.
 
 >
 >> The last and the most contradictory - why you need to unpack the egg before
 >> installing it? In my patch I removed all the custom easy_install args and
 >> moved pkg-plist into a Makefile:PLIST_FILES. It works just fine, but I'm not
 >> sure, may be you had a specific reason to do so..
 >
 > There is a bigger conversation happening about adding default -Z args
 > in bsd.python.mk and moving onto py-distribute among other things.
 > Alot of python modules do not set zip_safe=False when they should and
 > there's no easy way to preffix-override PYEASINSTALL_ARGS.
 
 To be short, I dislike the idea and see no real reason to change 
 something. I have no problems with unpacked .egg's and believe that any 
 problems should be resolved in individual manner.
 
 > That leaves the choice of this, or patch setup.py. Having thought
 > about it, i'll go the patch setup.py route from here on unless you
 > have ideas?
 
 I will revert this part of my patch and commit just what is left :). 
 Let's see if -Z stuff will be committed into the tree, and they operate 
 accordingly of that.
 
 -- 
 Regards,
 Ruslan
 
 Tinderboxing kills... the drives.
State-Changed-From-To: feedback->closed 
State-Changed-By: rm 
State-Changed-When: Fri Jun 15 11:24:29 UTC 2012 
State-Changed-Why:  
Committed, thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169068 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/169068: commit references a PR
Date: Fri, 15 Jun 2012 11:22:58 +0000 (UTC)

 rm          2012-06-15 11:22:44 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/py-oauthlib Makefile pkg-plist 
   Log:
   - remove unneded LICENSE_FILE knob
   - add dependency on py-rsa to RUN_DEPENDS too
   - mark this port python3 ready
   - remove trailing slash from pkg-plist entry
   - bump PORTREVISION because of dependency change
   
   PR:             169068 (follow-up patch)
   Submitted by:   rm (myself)
   Approved by:    koobs k <koobs.freebsd at gmail dot com> (maintainer)
   
   Revision  Changes    Path
   1.3       +6 -4      ports/security/py-oauthlib/Makefile
   1.2       +2 -2      ports/security/py-oauthlib/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
