From david@catwhisker.org  Fri Jun  1 22:20:55 2012
Return-Path: <david@catwhisker.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7B0F6106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  1 Jun 2012 22:20:55 +0000 (UTC)
	(envelope-from david@catwhisker.org)
Received: from albert.catwhisker.org (m209-73.dsl.rawbw.com [198.144.209.73])
	by mx1.freebsd.org (Postfix) with ESMTP id 543928FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  1 Jun 2012 22:20:55 +0000 (UTC)
Received: from albert.catwhisker.org (localhost [127.0.0.1])
	by albert.catwhisker.org (8.14.5/8.14.5) with ESMTP id q51MKs0o021422
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 1 Jun 2012 15:20:54 -0700 (PDT)
	(envelope-from david@albert.catwhisker.org)
Received: (from david@localhost)
	by albert.catwhisker.org (8.14.5/8.14.5/Submit) id q51MKs2k021421;
	Fri, 1 Jun 2012 15:20:54 -0700 (PDT)
	(envelope-from david)
Message-Id: <201206012220.q51MKs2k021421@albert.catwhisker.org>
Date: Fri, 1 Jun 2012 15:20:54 -0700 (PDT)
From: David Wolfskill <david@catwhisker.org>
Reply-To: David Wolfskill <david@catwhisker.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: png-1.4.11 to png-1.5.10 upgrade breaks graphics/xfig-devel
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         168541
>Category:       ports
>Synopsis:       png-1.4.11 to png-1.5.10 upgrade breaks graphics/xfig-devel
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 01 22:30:10 UTC 2012
>Closed-Date:    Sun Jun 03 16:21:34 CEST 2012
>Last-Modified:  Sun Jun 03 16:21:34 CEST 2012
>Originator:     David Wolfskill
>Release:        FreeBSD 8.3-STABLE i386
>Organization:
Wolfskill & Dowling Residence
>Environment:
System: FreeBSD g1-227.catwhisker.org 8.3-STABLE FreeBSD 8.3-STABLE #398 236355M: Thu May 31 04:15:29 PDT 2012     root@g1-227.catwhisker.org:/common/S1/obj/usr/src/sys/CANARY  i386

>Description:
	Per the 20120531 entry in /usr/ports/UPDATING, I issued
	"portmaster -r png-" to update both graphics/png and
	everything that depends on it.

	After updating all of the ports on which xfig-devel depends, the
	attempt to re-build graphics/xfig-devel failed:

	...
	rm -f e_scale.o
	cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include
	 -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -
	 DNARROWPROTO                                                     -DUSE_INLINE -D
	 USE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     e_scale.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I
	 /usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNA
	 RROWPROTO                                                -DUSE_INLINE -DUSE_XPM 
	 -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c e_tangent.c
	 rm -f e_update.o
	 cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                     -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     e_update.c
	 rm -f f_load.o
	 cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                     -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     f_load.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c f_neuclrtab.c
	 rm -f f_picobj.o
	 cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                     -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     f_picobj.c
	 rm -f f_read.o
	 cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                     -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     f_read.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c f_readold.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c f_readppm.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c f_readpng.c
	 f_readpng.c: In function 'read_png':
	 f_readpng.c:73: error: dereferencing pointer to incomplete type
	 f_readpng.c:90: error: dereferencing pointer to incomplete type
	 f_readpng.c:91: error: dereferencing pointer to incomplete type
	 f_readpng.c:95: error: dereferencing pointer to incomplete type
	 f_readpng.c:97: error: dereferencing pointer to incomplete type
	 *** Error code 1

	 Stop in /common/ports/graphics/xfig-devel/work/xfig.3.2.5-alpha5.
	 *** Error code 1

	 Stop in /common/ports/graphics/xfig-devel.
	 *** Error code 1

	 Stop in /common/ports/graphics/xfig-devel.

	 ===>>> make failed for graphics/xfig-devel
	 ===>>> Aborting update

	 Terminated

>How-To-Repeat:
	As above.
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lesi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jun 2 07:17:57 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168541 

From: dirk.meyer@dinoex.sub.org (Dirk Meyer)
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/168541: png-1.4.11 to png-1.5.10 upgrade breaks
	graphics/xfig-devel
Date: Sat, 02 Jun 2012 12:05:32 +0200

 building xfig or xfig-devel fails here before reacjing png specific files.
 
 e_edit.c: In function 'str_panel':
 e_edit.c:4358: error: 'XtNinternational' undeclared (first use in this function)
 e_edit.c:4358: error: (Each undeclared identifier is reported only once
 e_edit.c:4358: error: for each function it appears in.)
 
 Please try the patch below.
 kind regards Dirk
 
 - Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany
 - [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org]
 http://people.freebsd.org/~dinoex/errorlogs/
 
 
 --- f_readpng.c.orig	2004-01-06 20:46:05.000000000 +0100
 +++ f_readpng.c	2012-06-02 11:51:52.000000000 +0200
 @@ -70,7 +70,7 @@
      }
  
      /* set long jump recovery here */
 -    if (setjmp(png_ptr->jmpbuf)) {
 +    if (setjmp(png_jmpbuf(png_ptr))) {
  	/* if we get here there was a problem reading the file */
  	png_destroy_read_struct(&png_ptr, &info_ptr, &end_info);
  	close_picfile(file,filetype);
 
Responsible-Changed-From-To: lesi->dinoex 
Responsible-Changed-By: dinoex 
Responsible-Changed-When: Sun Jun 3 16:10:03 CEST 2012 
Responsible-Changed-Why:  
I will take care of it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168541 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/168541: commit references a PR
Date: Sun,  3 Jun 2012 14:10:39 +0000 (UTC)

 dinoex      2012-06-03 14:10:27 UTC
 
   FreeBSD ports repository
 
   Added files:
     graphics/xfig-devel/files patch-f_readpng.c patch-f_wrpng.c 
   Log:
   - fix build with libpng 1.5.10
   PR:             168541
   Obtained from:  gentoo
   
   Revision  Changes    Path
   1.1       +47 -0     ports/graphics/xfig-devel/files/patch-f_readpng.c (new)
   1.1       +19 -0     ports/graphics/xfig-devel/files/patch-f_wrpng.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Sun Jun 3 16:21:15 CEST 2012 
State-Changed-Why:  

a fix has been committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168541 
>Unformatted:
