From madis555@gmail.com  Wed May 30 01:15:49 2012
Return-Path: <madis555@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1443B106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 30 May 2012 01:15:49 +0000 (UTC)
	(envelope-from madis555@gmail.com)
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 976D58FC19
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 30 May 2012 01:15:48 +0000 (UTC)
Received: by werg1 with SMTP id g1so3913824wer.13
        for <FreeBSD-gnats-submit@freebsd.org>; Tue, 29 May 2012 18:15:47 -0700 (PDT)
Received: by 10.216.213.226 with SMTP id a76mr9053323wep.142.1338340547754;
        Tue, 29 May 2012 18:15:47 -0700 (PDT)
Received: from ketas-laptop.mydomain (195.20.191.90.dyn.estpak.ee. [90.191.20.195])
        by mx.google.com with ESMTPS id m20sm22799552wie.6.2012.05.29.18.15.46
        (version=TLSv1/SSLv3 cipher=OTHER);
        Tue, 29 May 2012 18:15:46 -0700 (PDT)
Received: by ketas-laptop.mydomain (Postfix, from userid 1001)
	id 0C50111F83A; Wed, 30 May 2012 04:15:45 +0300 (EEST)
Message-Id: <20120530011545.0C50111F83A@ketas-laptop.mydomain>
Date: Wed, 30 May 2012 04:15:45 +0300 (EEST)
From: "Sulev-Madis 'ketas' Silber" <madis555@hot.ee>
Sender: Sulev-Madis Silber <madis555@gmail.com>
Reply-To: "Sulev-Madis 'ketas' Silber" <madis555@hot.ee>
To: FreeBSD-gnats-submit@freebsd.org
Cc: "Sulev-Madis 'ketas' Silber" <madis555@hot.ee>
Subject: [PATCH] net/dhcprelay: Fix for broken init script
X-Send-Pr-Version: 3.113
X-GNATS-Notify: edwin@mavetju.org

>Number:         168446
>Category:       ports
>Synopsis:       [PATCH] net/dhcprelay: Fix for broken init script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    edwin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 30 01:20:01 UTC 2012
>Closed-Date:    Sun May 11 10:03:45 UTC 2014
>Last-Modified:  Sun May 11 10:10:00 UTC 2014
>Originator:     ketas
>Release:        FreeBSD 8.2-RELEASE-p4 i386
>Organization:
>Environment:
System: FreeBSD ketas-laptop.mydomain 8.2-RELEASE-p4 FreeBSD 8.2-RELEASE-p4 #0: Sat Dec 10 22:25:43 EET 2011 root@ketas-laptop.mydomain:/usr/obj/usr/src/sys/KETASLAPTOP i386


	
>Description:
	
Port's init script is broken:

> /usr/local/etc/rc.d/dhcprelay 
/usr/local/etc/rc.d/dhcprelay: 28: Syntax error: Unterminated quoted string

Patch attached.
>How-To-Repeat:
	
>Fix:

	

--- dhcprelay.diff begins here ---
--- dhcprelay.orig	2012-05-29 22:44:27.000000000 +0300
+++ dhcprelay	2012-05-29 22:45:07.000000000 +0300
@@ -25,6 +25,6 @@
 
 load_rc_config ${name}
 
-dhcprelay_enable=${dhcprelay_enable:"NO"}
+dhcprelay_enable=${dhcprelay_enable:-"NO"}
 
 run_rc_command "$1"
--- dhcprelay.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->edwin 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed May 30 08:16:51 UTC 2012 
Responsible-Changed-Why:  
edwin@mavetju.org => edwin@ (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168446 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed May 30 08:16:57 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168446 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: edwin@mavetju.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/168446: [PATCH] net/dhcprelay: Fix for broken init script
Date: Wed, 30 May 2012 08:16:53 UT

 Maintainer of net/dhcprelay,
 
 Please note that PR ports/168446 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168446
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: edwin 
State-Changed-When: Sun May 11 10:03:33 UTC 2014 
State-Changed-Why:  
Commited, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168446 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/168446: commit references a PR
Date: Sun, 11 May 2014 10:03:38 +0000 (UTC)

 Author: edwin
 Date: Sun May 11 10:03:32 2014
 New Revision: 353666
 URL: http://svnweb.freebsd.org/changeset/ports/353666
 QAT: https://qat.redports.org/buildarchive/r353666/
 
 Log:
   Fix rc script.
   
   PR:		168446
   Submitted by:	"Sulev-Madis 'ketas' Silber" <madis555@hot.ee>
 
 Modified:
   head/net/dhcprelay/Makefile
   head/net/dhcprelay/files/dhcprelay.in
 
 Modified: head/net/dhcprelay/Makefile
 ==============================================================================
 --- head/net/dhcprelay/Makefile	Sun May 11 10:03:02 2014	(r353665)
 +++ head/net/dhcprelay/Makefile	Sun May 11 10:03:32 2014	(r353666)
 @@ -3,7 +3,7 @@
  
  PORTNAME=	dhcprelay
  PORTVERSION=	1.2
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	net
  MASTER_SITES=	http://www.mavetju.org/download/
  
 
 Modified: head/net/dhcprelay/files/dhcprelay.in
 ==============================================================================
 --- head/net/dhcprelay/files/dhcprelay.in	Sun May 11 10:03:02 2014	(r353665)
 +++ head/net/dhcprelay/files/dhcprelay.in	Sun May 11 10:03:32 2014	(r353666)
 @@ -25,6 +25,6 @@ command_args="${dhcprelay_ifaces} ${dhcp
  
  load_rc_config ${name}
  
 -dhcprelay_enable=${dhcprelay_enable:"NO"}
 +dhcprelay_enable=${dhcprelay_enable:-"NO"}
  
  run_rc_command "$1"
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
