From nobody@FreeBSD.org  Mon May 28 14:48:06 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id EEB2B106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 May 2012 14:48:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id BF8098FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 May 2012 14:48:06 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q4SEm6h7075806
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 May 2012 14:48:06 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q4SEm6IB075805;
	Mon, 28 May 2012 14:48:06 GMT
	(envelope-from nobody)
Message-Id: <201205281448.q4SEm6IB075805@red.freebsd.org>
Date: Mon, 28 May 2012 14:48:06 GMT
From: larry bradford <la_bradford@cox.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: x11/x3270 does not package - patch attached to possibly correct issue
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: ecrist@secure-computing.net

>Number:         168410
>Category:       ports
>Synopsis:       x11/x3270 does not package - patch attached to possibly correct issue
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    scheidell
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 28 14:50:01 UTC 2012
>Closed-Date:    Tue Jun 12 13:08:38 UTC 2012
>Last-Modified:  Tue Jun 12 13:10:07 UTC 2012
>Originator:     larry bradford
>Release:        7.4, 8.3, 9.0 i386 and amd64
>Organization:
self
>Environment:
representative; 
FreeBSD jetpump.okc.ok.us. 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #1: Fri May  4 17:04:32 UTC 2012     root@jetpump.okc.ok.us.:/usr/obj/usr/src/sys/JET  amd64

>Description:
Port has been marked broken for some time. While it will install, apparently features I do not use are not correctly installed. The special 3270 fonts included in the package are installed into the wrong location. The attached patch
provides the necessary font location override to place the included fonts with the
rest of the X11 fonts in "/usr/local/lib/X11/fonts/" vs "/usr/local/share/"

The true patch is to modify the CONFIGURE_ARGS variable to force the correct font
install location. The included patch also deletes the DEPRECIATED, EXPIRATION_DATE, and BROKEN variables.

With the patch installed, tinderbox produces what looks to me clean runs on amd64
7.4, 8.3, and 9.0 and i386 7.4 and 8.3. I'm still building an i386 9.0 environment
 but believe it will also pass. I'm new at working with tinderbox, so I understand
that I might not read the results the same as the maintainer/QA/CM does.

I also removed a no longer valid flag "--without-pr3287" that was generating a
warning during the configure run.
>How-To-Repeat:
n/a?
>Fix:
change the CONFIGURE_ARGS entry "--with-fontdir=local" to 
"--with-fontdir-${PREFIX}/lib/X11/fonts/local"

Patch attached with submission follows:

--- Makefile.orig	2012-05-28 03:04:30.000000000 +0000
+++ Makefile	2012-05-28 03:05:19.000000000 +0000
@@ -18,16 +18,11 @@
 		mkfontdir:${PORTSDIR}/x11-fonts/mkfontdir \
 		mkfontscale:${PORTSDIR}/x11-fonts/mkfontscale
 
-DEPRECATED=	BROKEN for more than 6 month
-EXPIRATION_DATE=	2012-06-30
-
-BROKEN=		does not package
-
 USE_IMAKE=	yes
 USE_ICONV=	yes
 USE_XORG=	ice sm x11 xaw xext xmu xt
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS+=	--without-pr3287 --with-fontdir=local --disable-dbcs
+CONFIGURE_ARGS+=	--with-fontdir=${PREFIX}/lib/X11/fonts/local --disable-dbcs
 CONFIGURE_ENV=	LIBS="-L${PREFIX}/lib"
 CPPFLAGS+=	-I${PREFIX}/include
 LDFLAGS+=	-L${PREFIX}/lib


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: scheidell 
State-Changed-When: Tue May 29 11:13:30 UTC 2012 
State-Changed-Why:  
Manually set GNATS notify to ecrist@secure-computing.net since GNATS took the morning off. 
ecrist@secure-computing.net:  patch included in PR. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=168410 
Responsible-Changed-From-To: freebsd-ports-bugs->scheidell 
Responsible-Changed-By: scheidell 
Responsible-Changed-When: Tue May 29 11:16:05 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168410 

From: Michael Scheidell <scheidell@FreeBSD.org>
To: <bug-followup@FreeBSD.org>
Cc:  
Subject: Re: ports/168410: x11/x3270 does not package - patch attached to
 possibly correct issue
Date: Tue, 29 May 2012 07:28:39 -0400

 Packages now where it did not package before.
 <http://lorie.secnap.net/tb/logs/7-scheidell_I386/x3270-3.3.10.log>
 
 Waiting for maintainer to approve the changes to CONFIG_ARGS.
 
 -- 
 Michael Scheidell, CTO
  >*| * SECNAP Network Security Corporation
 d: +1.561.948.2259
 w: http://people.freebsd.org/~scheidell
State-Changed-From-To: feedback->closed 
State-Changed-By: scheidell 
State-Changed-When: Tue Jun 12 13:08:36 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168410 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/168410: commit references a PR
Date: Tue, 12 Jun 2012 13:08:24 +0000 (UTC)

 scheidell    2012-06-12 13:08:10 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11/x3270            Makefile 
   Log:
   - Unbreak by fixing location of fontdir
   - Remove EXPIRATION/DEPRECATED/BROKEN
   - No PORTREVISION bump
   
   PR:             ports/168410
   Submitted by:   larry bradford <la_bradford@cox.net>
   Approved by:    maintainer (timeout)
   
   Revision  Changes    Path
   1.43      +1 -6      ports/x11/x3270/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
