From root@Leo.mi.chu.edu.tw  Thu May 24 13:42:27 2012
Return-Path: <root@Leo.mi.chu.edu.tw>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1F1F8106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 24 May 2012 13:42:27 +0000 (UTC)
	(envelope-from root@Leo.mi.chu.edu.tw)
Received: from Leo.mi.chu.edu.tw (Leo.mi.chu.edu.tw [140.126.143.63])
	by mx1.freebsd.org (Postfix) with ESMTP id B33638FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 24 May 2012 13:42:26 +0000 (UTC)
Received: from Leo.mi.chu.edu.tw (localhost [127.0.0.1])
	by Leo.mi.chu.edu.tw (Postfix) with ESMTP id 608194DFC64
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 24 May 2012 21:41:43 +0800 (CST)
Received: from Leo.mi.chu.edu.tw ([127.0.0.1])
	by Leo.mi.chu.edu.tw (Leo.mi.chu.edu.tw [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id eo9UPDhbsiiY for <FreeBSD-gnats-submit@freebsd.org>;
	Thu, 24 May 2012 21:41:43 +0800 (CST)
Received: by Leo.mi.chu.edu.tw (Postfix, from userid 0)
	id 250754DFC2B; Thu, 24 May 2012 21:41:43 +0800 (CST)
Message-Id: <20120524134143.250754DFC2B@Leo.mi.chu.edu.tw>
Date: Thu, 24 May 2012 21:41:43 +0800 (CST)
From: Joe Horn <joehorn@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] databases/php-adodb-ext: Fix for building failed with PHP 5.4
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         168302
>Category:       ports
>Synopsis:       [MAINTAINER] databases/php-adodb-ext: Fix for building failed with PHP 5.4
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    scheidell
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 24 13:50:02 UTC 2012
>Closed-Date:    Sat May 26 11:13:24 UTC 2012
>Last-Modified:  Sat May 26 11:20:01 UTC 2012
>Originator:     Joe Horn
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
Taiwanese User
>Environment:
System: FreeBSD joehorn.idv.tw 9.0-RELEASE FreeBSD 9.0-RELEASE #3: Mon Jan  9 22:14:09 CST
>Description:
- Change DEFAULT_PHP_VER to 53
- Fix for building failed with PHP 5.4
- Bupm PORTREVISION

Added file(s):
- files/extra-patch-php54-adodb.c

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- php-adodb-ext-5.04_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/databases/php-adodb-ext/Makefile ./Makefile
--- /usr/ports/databases/php-adodb-ext/Makefile	2012-05-20 14:42:50.000000000 +0800
+++ ./Makefile	2012-05-24 12:00:38.000000000 +0800
@@ -2,12 +2,12 @@
 # Date created:		29 July 2008
 # Whom:			JoeHorn <joehorn@gmail.com>
 #
-# $FreeBSD: ports/databases/php-adodb-ext/Makefile,v 1.4 2012/05/20 06:42:50 ale Exp $
+# $FreeBSD: ports/databases/php-adodb-ext/Makefile,v 1.3 2011/08/08 11:04:45 gabor Exp $
 #
 
 PORTNAME=	adodb-ext
 PORTVERSION=	5.04
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	databases
 MASTER_SITES=	http://phplens.com/lens/dl/
 PKGNAMEPREFIX=	php-
@@ -20,10 +20,10 @@
 
 USE_PHP=	yes
 USE_PHPIZE=	yes
-DEFAULT_PHP_VER=53
-IGNORE_WITH_PHP=5
 USE_ZIP=	yes
 
+DEFAULT_PHP_VER=53
+
 CONFIGURE_ARGS=		--with-php-config=${PREFIX}/bin/php-config \
 			--prefix=${PREFIX}/lib/php/${PHP_EXT_DIR}
 SUB_FILES=	pkg-message
@@ -32,7 +32,9 @@
 
 .include <bsd.port.pre.mk>
 
-.if ${PHP_VER} != "52"
+.if ${PHP_VER} == "5"
+EXTRA_PATCHES=	${PATCHDIR}/extra-patch-php54-adodb.c
+.elif ${PHP_VER} != "52"
 EXTRA_PATCHES=	${PATCHDIR}/extra-patch-adodb.c
 .endif
 
diff -ruN --exclude=CVS /usr/ports/databases/php-adodb-ext/files/extra-patch-php54-adodb.c ./files/extra-patch-php54-adodb.c
--- /usr/ports/databases/php-adodb-ext/files/extra-patch-php54-adodb.c	1970-01-01 08:00:00.000000000 +0800
+++ ./files/extra-patch-php54-adodb.c	2012-05-20 23:24:38.000000000 +0800
@@ -0,0 +1,37 @@
+--- adodb.c.orig	2012-05-20 14:42:41.000000000 +0000
++++ adodb.c	2012-05-20 14:41:28.000000000 +0000
+@@ -108,7 +108,7 @@
+ }; 
+ #else
+ /* PHP 5 */
+-function_entry adodb_functions[] = {
++zend_function_entry adodb_functions[] = {
+    	PHP_FE(adodb_movenext,NULL) 
+ 	PHP_FE(adodb_getall,NULL)   
+ 	{NULL, NULL, NULL} 
+@@ -159,11 +159,11 @@
+ 
+ static void adodb_init_zval(zval *v, char *s)
+ {
+-	v->type = IS_STRING;
+-	v->value.str.val = s;
+-	v->value.str.len = strlen(s);
+-	v->is_ref = 0;
+-	v->refcount = 1;
++	Z_TYPE_P(v) = IS_STRING;
++	Z_STRVAL_P(v) = s;
++	Z_STRLEN_P(v) = strlen(s);
++	Z_UNSET_ISREF_P(v);
++	Z_SET_REFCOUNT_P(v, 1);
+ }
+ 
+ /* {{{ PHP_MINIT_FUNCTION
+@@ -277,7 +277,7 @@
+ 	fci.function_table = EG(function_table);
+ 	fci.function_name = &adodb_zvals[zval_ocifetch];
+ 	fci.symbol_table = NULL;
+-	fci.object_pp = NULL;
++	fci.object_ptr = NULL;
+ 	fci.retval_ptr_ptr = &retval;
+ 	fci.param_count = 2;
+ 	fci.params = &params[1];
--- php-adodb-ext-5.04_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->scheidell 
Responsible-Changed-By: scheidell 
Responsible-Changed-When: Fri May 25 13:13:56 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168302 
State-Changed-From-To: open->closed 
State-Changed-By: scheidell 
State-Changed-When: Sat May 26 11:13:23 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168302 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/168302: commit references a PR
Date: Sat, 26 May 2012 11:11:27 +0000 (UTC)

 scheidell    2012-05-26 11:11:12 UTC
 
   FreeBSD ports repository
 
   Modified files:
     databases/php-adodb-ext Makefile 
   Added files:
     databases/php-adodb-ext/files extra-patch-php54-adodb.c 
   Log:
   - Fix for building failed with PHP 5.4
   - Bump PORTREVISION
   
   PR:             ports/168302
   Submitted by:   Joe Horn <joehorn@gmail.com> (maintainer)
   
   Revision  Changes    Path
   1.5       +4 -3      ports/databases/php-adodb-ext/Makefile
   1.1       +37 -0     ports/databases/php-adodb-ext/files/extra-patch-php54-adodb.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
