From crees@FreeBSD.org  Wed May 23 20:06:42 2012
Return-Path: <crees@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8A2D5106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 23 May 2012 20:06:42 +0000 (UTC)
	(envelope-from crees@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 746E18FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 23 May 2012 20:06:42 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4NK6gkc027276
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 23 May 2012 20:06:42 GMT
	(envelope-from crees@freefall.freebsd.org)
Received: (from crees@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4NK6ghc027275;
	Wed, 23 May 2012 20:06:42 GMT
	(envelope-from crees)
Message-Id: <201205232006.q4NK6ghc027275@freefall.freebsd.org>
Date: Wed, 23 May 2012 20:06:42 GMT
From: Chris Rees <crees@freebsd.org>
Reply-To: Chris Rees <crees@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] net-mgmt/nagios-pf-plugin remove obsolete OSVERSION check
X-Send-Pr-Version: 3.113
X-GNATS-Notify: kian.mohageri@gmail.com

>Number:         168278
>Category:       ports
>Synopsis:       [PATCH] net-mgmt/nagios-pf-plugin remove obsolete OSVERSION check
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 23 20:10:06 UTC 2012
>Closed-Date:    Wed Jun 06 16:53:08 UTC 2012
>Last-Modified:  Wed Jun  6 17:00:25 UTC 2012
>Originator:     Chris Rees
>Release:        FreeBSD 9.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 9.0-STABLE FreeBSD 9.0-STABLE #6 r235139: Tue May 8 21:19:03 UTC 2012 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386


	
>Description:
FreeBSD ports tree doesn't support <7.x, so this check is unnecessary.

Also, creating a directory under PREFIX is a privileged operation, so pre-su-install must be used.
>How-To-Repeat:
	
>Fix:

	

--- net-mgmt-nagios-pf-plugin.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/net-mgmt/nagios-pf-plugin/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile	13 Feb 2010 11:28:36 -0000	1.3
+++ Makefile	23 May 2012 19:54:46 -0000
@@ -23,12 +23,6 @@
 SUB_FILES=	pkg-message
 SUB_LIST=	NAGIOS_PLUGIN_DIR=${NAGIOS_PLUGIN_DIR}
 
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} < 601000
-IGNORE=		requires FreeBSD 6.1 or later
-.endif
-
 pre-everything::
 	@${ECHO_MSG} ""
 	@${ECHO_MSG} "You can redefine the following additional variables:"
@@ -45,10 +39,10 @@
 	    "s,/usr/local/libexec/nagios,${PREFIX}/${NAGIOS_PLUGIN_DIR}," \
 	    ${WRKSRC}/Makefile
 
-pre-install:
+pre-su-install:
 	@${MKDIR} ${PREFIX}/${NAGIOS_PLUGIN_DIR}
 
 post-install:
 	@${CAT} ${PKGMESSAGE}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
--- net-mgmt-nagios-pf-plugin.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed May 23 20:10:58 UTC 2012 
Responsible-Changed-Why:  
pgollucci@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168278 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed May 23 20:11:02 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168278 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: kian.mohageri@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/168278: [PATCH] net-mgmt/nagios-pf-plugin remove obsolete OSVERSION check
Date: Wed, 23 May 2012 20:11:00 UT

 Maintainer of net-mgmt/nagios-pf-plugin,
 
 Please note that PR ports/168278 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168278
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: crees 
State-Changed-When: Wed Jun 6 16:53:07 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 


Responsible-Changed-From-To: pgollucci->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Wed Jun 6 16:53:07 UTC 2012 
Responsible-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168278 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/168278: commit references a PR
Date: Wed,  6 Jun 2012 16:53:12 +0000 (UTC)

 crees       2012-06-06 16:52:58 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-mgmt/nagios-pf-plugin Makefile 
   Log:
   Remove obsolete OSVERSION conditional.
   
   While here, use pre-su-install for privileged actions.
   
   PR:             ports/168278
   Submitted by:   crees
   Approved by:    maintainer timeout (kian.mohageri@gmail.com, 2w)
   
   Revision  Changes    Path
   1.4       +2 -8      ports/net-mgmt/nagios-pf-plugin/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
