From m.seaman@infracaninophile.co.uk  Sat May 19 18:44:46 2012
Return-Path: <m.seaman@infracaninophile.co.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id F0F3A1065675
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 May 2012 18:44:46 +0000 (UTC)
	(envelope-from m.seaman@infracaninophile.co.uk)
Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78])
	by mx1.freebsd.org (Postfix) with ESMTP id 61DE38FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 May 2012 18:44:46 +0000 (UTC)
Received: from lucid-nonsense.infracaninophile.co.uk (localhost [IPv6:::1])
	by smtp.infracaninophile.co.uk (8.14.5/8.14.5) with ESMTP id q4JIigmM094176;
	Sat, 19 May 2012 19:44:42 +0100 (BST)
	(envelope-from matthew@lucid-nonsense.infracaninophile.co.uk)
Received: (from matthew@localhost)
	by lucid-nonsense.infracaninophile.co.uk (8.14.5/8.14.5/Submit) id q4JIifnU094175;
	Sat, 19 May 2012 19:44:41 +0100 (BST)
	(envelope-from matthew)
Message-Id: <201205191844.q4JIifnU094175@lucid-nonsense.infracaninophile.co.uk>
Date: Sat, 19 May 2012 19:44:41 +0100 (BST)
From: Matthew Seaman <matthew@freebsd.org>
Reply-To: Matthew Seaman <matthew@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: dsh@vlink.ru
Subject: www/p5-HTML-Mason -- fix USE_APACHE syntax for WITH_MOD_PERL=yes
X-Send-Pr-Version: 3.113
X-GNATS-Notify: dsh@vlink.ru

>Number:         168143
>Category:       ports
>Synopsis:       www/p5-HTML-Mason -- fix USE_APACHE syntax for WITH_MOD_PERL=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    matthew
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 19 18:50:05 UTC 2012
>Closed-Date:    Mon Jun 04 19:31:27 UTC 2012
>Last-Modified:  Mon Jun 04 19:31:27 UTC 2012
>Originator:     Matthew Seaman
>Release:        FreeBSD 9.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD lucid-nonsense.infracaninophile.co.uk 9.0-STABLE FreeBSD 9.0-STABLE #12: Thu May 3 22:05:28 BST 2012 root@lucid-nonsense.infracaninophile.co.uk:/usr/obj/usr/src/sys/LUCID-NONSENSE amd64


	
>Description:

Looks like a trivial typo has slipped through.

The argument to USE_APACHE should be 20+ rather than 2.0+.  This
breaks building the port if WITH_MOD_PERL is set in OPTIONS.

No PORTREVISION bump, as this doesn't affect the package built with
the default OPTIONS.

Maintainer: OK for me to commit this?

>How-To-Repeat:
	
>Fix:

	

--- p5-HTML-Mason.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/www/p5-HTML-Mason/Makefile,v
retrieving revision 1.69
diff -u -u -r1.69 Makefile
--- Makefile	16 May 2012 04:09:48 -0000	1.69
+++ Makefile	19 May 2012 18:36:40 -0000
@@ -68,7 +68,7 @@
 .include <bsd.port.pre.mk>
 
 .if defined(WITH_MOD_PERL)
-USE_APACHE=	2.0+
+USE_APACHE=	20+
 RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/Apache2/Request.pm:${PORTSDIR}/www/p5-libapreq2
 .endif
 
--- p5-HTML-Mason.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->perl 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat May 19 18:50:43 UTC 2012 
Responsible-Changed-Why:  
perl@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168143 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat May 19 18:50:51 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168143 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: dsh@vlink.ru
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/168143: www/p5-HTML-Mason -- fix USE_APACHE syntax for WITH_MOD_PERL=yes
Date: Sat, 19 May 2012 18:50:47 UT

 Maintainer of www/p5-HTML-Mason,
 
 Please note that PR ports/168143 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168143
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: perl->matthew 
Responsible-Changed-By: matthew 
Responsible-Changed-When: Sat May 19 19:15:21 UTC 2012 
Responsible-Changed-Why:  
No need to bother the perl@ guys for this. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=168143 

From: Matthew Seaman <matthew@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc: dsh@vlink.ru
Subject: Re: ports/168143: www/p5-HTML-Mason -- fix USE_APACHE syntax for
 WITH_MOD_PERL=yes
Date: Sun, 20 May 2012 11:05:04 +0200

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig0EE53211D0943CEDC6DA9211
 Content-Type: multipart/mixed;
  boundary="------------080008090102030200090500"
 
 This is a multi-part message in MIME format.
 --------------080008090102030200090500
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 
 Updated patch -- RUN_DEPENDS also needs to be initialised from
 BUILD_DEPENDS.
 
 --=20
 Dr Matthew J Seaman MA, D.Phil.
 PGP: http://www.infracaninophile.co.uk/pgpkey
 
 
 --------------080008090102030200090500
 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
  name="p5-HTML-Mason.diff"
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: attachment;
  filename="p5-HTML-Mason.diff"
 
 Index: Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /home/ncvs/ports/www/p5-HTML-Mason/Makefile,v
 retrieving revision 1.69
 diff -u -u -r1.69 Makefile
 --- Makefile	16 May 2012 04:09:48 -0000	1.69
 +++ Makefile	20 May 2012 08:50:27 -0000
 @@ -20,6 +20,7 @@
  		p5-Exception-Class>=3D1.15:${PORTSDIR}/devel/p5-Exception-Class \
  		p5-Log-Any>=3D0.08:${PORTSDIR}/devel/p5-Log-Any \
  		p5-Cache-Cache>=3D1:${PORTSDIR}/devel/p5-Cache-Cache
 +RUN_DEPENDS:=3D	${BUILD_DEPENDS}
  TEST_DEPENDS=3D	p5-Test-Deep>=3D0:${PORTSDIR}/devel/p5-Test-Deep
 =20
  PERL_MODBUILD=3D	yes
 @@ -68,7 +69,7 @@
  .include <bsd.port.pre.mk>
 =20
  .if defined(WITH_MOD_PERL)
 -USE_APACHE=3D	2.0+
 +USE_APACHE=3D	20+
  RUN_DEPENDS+=3D	${SITE_PERL}/${PERL_ARCH}/Apache2/Request.pm:${PORTSDIR}=
 /www/p5-libapreq2
  .endif
 =20
 
 --------------080008090102030200090500--
 
 --------------enig0EE53211D0943CEDC6DA9211
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
 iEYEARECAAYFAk+4s8AACgkQ8Mjk52CukIxaQQCfbeIH17JyoW8t+Dgx9yKWYdP1
 yiEAnjJvfJ3zixnzyXPJaQ0h/UyijW5G
 =ilmn
 -----END PGP SIGNATURE-----
 
 --------------enig0EE53211D0943CEDC6DA9211--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/168143: commit references a PR
Date: Mon,  4 Jun 2012 19:11:26 +0000 (UTC)

 matthew     2012-06-04 19:11:13 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/p5-HTML-Mason    Makefile 
   Log:
     - Fix USE_APACHE syntax
     - Set RUN_DEPENDS from BUILD_DEPENDS
     - update to new OPTIONS framework
   
   Approved by:    shaun (mentor)
   PR:             ports/168143
   Submitted by:   me
   
   Revision  Changes    Path
   1.70      +7 -5      ports/www/p5-HTML-Mason/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: matthew 
State-Changed-When: Mon Jun 4 19:30:04 UTC 2012 
State-Changed-Why:  
Committed after maintainer timeout. Also included update to OPTIONSng 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168143 
>Unformatted:
