From truckman@FreeBSD.org  Thu May 17 01:42:55 2012
Return-Path: <truckman@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D468B106566B;
	Thu, 17 May 2012 01:42:55 +0000 (UTC)
	(envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (gw.catspoiler.org [75.1.14.242])
	by mx1.freebsd.org (Postfix) with ESMTP id A0A7C8FC08;
	Thu, 17 May 2012 01:42:55 +0000 (UTC)
Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id q4H1gtF6095034;
	Wed, 16 May 2012 18:42:55 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Received: from mousie.catspoiler.org (localhost.catspoiler.org [127.0.0.1])
	by mousie.catspoiler.org (8.14.5/8.14.5) with ESMTP id q4H1gs2F074825;
	Wed, 16 May 2012 18:42:54 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Received: (from dl@localhost)
	by mousie.catspoiler.org (8.14.5/8.14.5/Submit) id q4H1gs22074824;
	Wed, 16 May 2012 18:42:54 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <201205170142.q4H1gs22074824@mousie.catspoiler.org>
Date: Wed, 16 May 2012 18:42:54 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Reply-To: Don Lewis <truckman@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: gnome@FreeBSD.org
Subject: databases/evolution-data-server build fails on FreeBSD 10 with new Heimdal
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         167989
>Category:       ports
>Synopsis:       databases/evolution-data-server build fails on FreeBSD 10 with new Heimdal
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 17 01:50:02 UTC 2012
>Closed-Date:    Sun May 20 16:27:54 UTC 2012
>Last-Modified:  Sun May 20 16:30:09 UTC 2012
>Originator:     Don Lewis
>Release:        FreeBSD 10.0-CURRENT i386
>Organization:
FreeBSD project
>Environment:
System: FreeBSD scratch.catspoiler.org 10.0-CURRENT FreeBSD 10.0-CURRENT #6: Tue May 15 14:19:58 PDT 2012 dl@scratch.catspoiler.org:/usr/obj/usr/src/sys/GENERIC SMB i386


>Description:

The databases/evolution-data-server port fails to build on FreeBSD 10 since
Heimdel was upgraded to 1.5.1.

  CC     libcamel_provider_1_2_la-camel-sasl-gssapi.lo
In file included from camel-sasl-gssapi.c:51:
/usr/include/gssapi.h:3:2: warning: #warning "this file includes <gssapi.h> which is deprecated, use <gssapi/gssapi.h> instead"
camel-sasl-gssapi.c: In function 'gssapi_set_exception':
camel-sasl-gssapi.c:157: error: implicit declaration of function 'error_message'
camel-sasl-gssapi.c:157: warning: nested extern declaration of 'error_message'
camel-sasl-gssapi.c:157: warning: assignment makes pointer from integer without a cast
gmake[4]: *** [libcamel_provider_1_2_la-camel-sasl-gssapi.lo] Error 1
gmake[4]: Leaving directory `/usr/ports/databases/evolution-data-server/work/evolution-data-server-2.32.1/camel'

The problem is that <com_err.h>, which declares error_message(), is not being
included.  The reason for that problem is that the port's configure test
for this header is failing because <com_err.h> includes <com_right.h>, which
uses size_t in the function prototype for com_right_r(), but size_t has not
been declared because the compile test for this header doesn't include
<sys/types.h>.

The com_err(3) man page imported with the new Heimdel distribution says
that the proper list of includes is:

     #include <stdio.h>
     #include <stdarg.h>
     #include <krb5/com_err.h>

though com_err.h is still being installed directly under /usr/include in
FreeBSD 10.  It appears that this relies on <stdio.h> defining size_t.

>How-To-Repeat:

Attempt to build the port on a recent version of FreeBSD 10.

>Fix:

The configure script should probably be enhanced to handle the new Heimdel
version, but that is probably best handled upstream.  The following patch
uses config.cache to bypass the test for <com_err.h> and just force it
to be included.

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/evolution-data-server/Makefile,v
retrieving revision 1.84
diff -u -u -r1.84 Makefile
--- Makefile	23 Sep 2011 22:21:32 -0000	1.84
+++ Makefile	17 May 2012 01:14:45 -0000
@@ -38,7 +38,8 @@
 CONFIGURE_ARGS=	--enable-static \
 		--enable-gnome-keyring=yes \
 		--with-openldap=yes \
-		--with-libdb=${LOCALBASE}
+		--with-libdb=${LOCALBASE} \
+		-C
 CPPFLAGS+=	-I${LOCALBASE}/include -I${BDB_INCLUDE_DIR} ${PTHREAD_CFLAGS}
 LDFLAGS+=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
 
--- /dev/null	2012-05-16 18:35:04.000000000 -0700
+++ files/patch-config.cache	2012-05-16 18:14:18.000000000 -0700
@@ -0,0 +1,4 @@
+--- /dev/null	2012-05-16 18:11:00.000000000 -0700
++++ config.cache	2012-05-16 18:13:49.000000000 -0700
+@@ -0,0 +1 @@
++ac_cv_header_com_err_h=yes
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu May 17 01:50:26 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167989 
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Sun May 20 16:27:40 UTC 2012 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167989 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/167989: commit references a PR
Date: Sun, 20 May 2012 16:27:46 +0000 (UTC)

 mezz        2012-05-20 16:27:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     databases/evolution-data-server/files patch-configure 
   Log:
   Fix the build with Heimdal 1.5.x.
   
   PR:             ports/167989
   Reported by:    truckman
   
   Revision  Changes    Path
   1.13      +23 -5     ports/databases/evolution-data-server/files/patch-configure
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
