From nobody@FreeBSD.org  Fri May 11 22:07:24 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 86C90106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 May 2012 22:07:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 589608FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 May 2012 22:07:24 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q4BM7OVw056789
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 May 2012 22:07:24 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q4BM7Oe9056788;
	Fri, 11 May 2012 22:07:24 GMT
	(envelope-from nobody)
Message-Id: <201205112207.q4BM7Oe9056788@red.freebsd.org>
Date: Fri, 11 May 2012 22:07:24 GMT
From: Pawel Pekala <pawel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: lang/squeak incomplete plist when libGL is installed
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: mutoh@openedu.org

>Number:         167809
>Category:       ports
>Synopsis:       lang/squeak incomplete plist when libGL is installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pawel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 11 22:10:11 UTC 2012
>Closed-Date:    Mon May 14 14:10:12 UTC 2012
>Last-Modified:  Mon May 14 14:20:13 UTC 2012
>Originator:     Pawel Pekala
>Release:        10.0-CURRENT
>Organization:
>Environment:
FreeBSD blaviken.slowicza.org 10.0-CURRENT FreeBSD 10.0-CURRENT #1: Sat May  5 13:30:03 CEST 2012     corn@blaviken.slowicza.org:/usr/obj/usr/src/sys/BLAVIKEN  i386

>Description:
When graphics/libGL is installed (any desktop system I guess) port builds additonal plugin - B3DAcceleratorPlugin. This means that plist is incomplete:

[corn:~]# pkg_delete squeak-4.4.7/
pkg_delete: unable to completely remove directory '/usr/local/lib/squeak/4.4.7-2375'
pkg_delete: unable to completely remove directory '/usr/local/lib/squeak'
pkg_delete: couldn't entirely delete package `squeak-4.4.7'
(perhaps the packing list is incorrectly specified?)
[corn:~]# ls -l /usr/local/lib/squeak/4.4.7-2375/
total 58
-rwxr-xr-x  1 root  wheel  58920 11 maj 23:58 so.B3DAcceleratorPlugin

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -urN /usr/ports/lang/squeak/Makefile ./Makefile
--- /usr/ports/lang/squeak/Makefile	2012-04-20 19:18:25.000000000 +0200
+++ ./Makefile	2012-05-11 23:25:19.000000000 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=		squeak
 PORTVERSION=		4.4.7
+PORTREVISION=		1
 CATEGORIES=		lang
 ##################################################
 MASTER_SITES=		http://www.squeakvm.org/unix/release/:vmsrc \
@@ -46,6 +47,7 @@
 ONLY_FOR_ARCHS=		i386
 MAN1=			squeak.1
 USE_GMAKE=		yes
+USE_GL=			gl
 HAS_CONFIGURE=		yes
 
 # Plugin image must be writable, because of it copy to user's ~/.npsqueak/ and
diff -urN /usr/ports/lang/squeak/pkg-plist ./pkg-plist
--- /usr/ports/lang/squeak/pkg-plist	2012-04-20 19:18:25.000000000 +0200
+++ ./pkg-plist	2012-05-11 23:32:10.000000000 +0200
@@ -1,6 +1,7 @@
 bin/squeak
 bin/squeak.sh
 lib/squeak/%%SQUEAK_LIB_DIR%%/so.AioPlugin
+lib/squeak/%%SQUEAK_LIB_DIR%%/so.B3DAcceleratorPlugin
 lib/squeak/%%SQUEAK_LIB_DIR%%/so.ClipboardExtendedPlugin
 lib/squeak/%%SQUEAK_LIB_DIR%%/so.DBusPlugin
 lib/squeak/%%SQUEAK_LIB_DIR%%/so.FileCopyPlugin


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pawel 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri May 11 22:10:28 UTC 2012 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167809 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri May 11 22:10:51 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167809 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: mutoh@openedu.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/167809: lang/squeak incomplete plist when libGL is installed
Date: Fri, 11 May 2012 22:10:35 UT

 Maintainer of lang/squeak,
 
 Please note that PR ports/167809 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/167809
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Takeshi MUTOH <mutoh@openedu.org>
To: bug-followup@FreeBSD.org
Cc: =?iso-2022-jp?B?GyRCSXBGIxsoQiAbJEJJcDtOGyhC?= <mutoh@openedu.org>,
 pawel@FreeBSD.org
Subject: Re: ports/167809: lang/squeak incomplete plist when libGL is installed
Date: Sun, 13 May 2012 17:11:40 +0900

 Thank you Pawel.
 
 On 2012/05/12, at 7:10, Edwin Groothuis wrote:
 > Maintainer of lang/squeak,
 > 
 > Please note that PR ports/167809 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/167809
 
 I check this patch, build, and deinstall, there is no problem.
 
 So please commit it.
 
 See also my redports build below:
 - https://redports.org/buildarchive/20120513021510-62605/
 
 Thanks in advance.
 --
 Takeshi MUTOH <mutoh@openedu.org> 
 
State-Changed-From-To: feedback->closed 
State-Changed-By: pawel 
State-Changed-When: Mon May 14 14:10:07 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167809 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/167809: commit references a PR
Date: Mon, 14 May 2012 14:09:49 +0000 (UTC)

 pawel       2012-05-14 14:09:40 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/squeak          Makefile pkg-plist 
   Log:
   Add dependency on opengl lib, port builds additional plugin when it's
   installed on system, this fixes incomplete plist in that case.
   
   PR:             ports/167809
   Submitted by:   me
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.24      +2 -0      ports/lang/squeak/Makefile
   1.11      +1 -0      ports/lang/squeak/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
