From nobody@FreeBSD.org  Fri May 11 16:31:14 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0071D1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 May 2012 16:31:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id DF7338FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 May 2012 16:31:13 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q4BGVDXW075219
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 May 2012 16:31:13 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q4BGVDlo075217;
	Fri, 11 May 2012 16:31:13 GMT
	(envelope-from nobody)
Message-Id: <201205111631.q4BGVDlo075217@red.freebsd.org>
Date: Fri, 11 May 2012 16:31:13 GMT
From: Ryan Steinmetz <zi@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Fix mail/opendkim whenever WITH_FILTER is not specified
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: umq@ueo.co.jp

>Number:         167803
>Category:       ports
>Synopsis:       [patch] Fix mail/opendkim whenever WITH_FILTER is not specified
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    zi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 11 16:40:12 UTC 2012
>Closed-Date:    Tue May 15 00:24:24 UTC 2012
>Last-Modified:  Tue May 15 00:30:02 UTC 2012
>Originator:     Ryan Steinmetz
>Release:        
>Organization:
Rochester Institute of Technology
>Environment:
>Description:
If mail/opendkim is built WITHOUT_FILTER, installation will fail due to a logic error in post-install:

test -z "/usr/ports/mail/opendkim/work/doc" || build-aux/install-sh -c -d "/usr/ports/mail/opendkim/work/doc"
 install  -o root -g wheel -m 444 FEATURES KNOWNBUGS LICENSE LICENSE.Sendmail RELEASE_NOTES.Sendmail '/usr/ports/mail/opendkim/work/doc'
/usr/bin/strip: '/usr/local/sbin/opendkim': No such file
*** Error code 1

Stop in /usr/ports/mail/opendkim.
*** Error code 1

Stop in /usr/ports/mail/opendkim.
>How-To-Repeat:
Build/install mail/opendkim without FILTER selected in OPTIONS.
>Fix:
Apply the attached patch.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/opendkim/Makefile,v
retrieving revision 1.15
diff -u -r1.15 Makefile
--- Makefile	10 Apr 2012 09:20:44 -0000	1.15
+++ Makefile	11 May 2012 16:27:29 -0000
@@ -141,7 +141,7 @@
 .endif
 
 post-install:
-.if !defined(WITH_DEBUG)
+.if !defined(WITH_DEBUG) && defined(WITH_FILTER) && !defined(WITHOUT_FILTER)
 	@${STRIP_CMD} ${PREFIX}/sbin/opendkim
 .endif
 	@${MKDIR} ${PREFIX}/etc/mail


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->zi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri May 11 16:40:21 UTC 2012 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167803 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri May 11 16:40:26 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167803 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: umq@ueo.co.jp
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/167803: [patch] Fix mail/opendkim whenever WITH_FILTER is not specified
Date: Fri, 11 May 2012 16:40:24 UT

 Maintainer of mail/opendkim,
 
 Please note that PR ports/167803 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/167803
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Hirohisa Yamaguchi <umq@ueo.co.jp>
To: zi@FreeBSD.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/167803: [patch] Fix mail/opendkim whenever WITH_FILTER is not specified
Date: Tue, 15 May 2012 08:57:24 +0900

 Hi,
 
 I see the problem and the patch looks okay.
 I approve it, thanks.
 
 At Fri, 11 May 2012 16:40:24 UT,
 Edwin Groothuis wrote:
 > Please note that PR ports/167803 has just been submitted.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/167803
 
 
 Regards,
 -- 
 
 	Hirohisa Yamaguchi
 	  umq@ueo.co.jp
State-Changed-From-To: feedback->closed 
State-Changed-By: zi 
State-Changed-When: Tue May 15 00:24:23 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167803 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/167803: commit references a PR
Date: Tue, 15 May 2012 00:24:19 +0000 (UTC)

 zi          2012-05-15 00:24:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/opendkim        Makefile 
   Log:
   - Fix install whenever WITH_FILTER is not specified
   - Do not bump PORTREVISION
   
   PR:             ports/167803
   Submitted by:   zi
   Approved by:    Hirohisa Yamaguchi <umq@ueo.co.jp> (maintainer)
   
   Revision  Changes    Path
   1.16      +1 -1      ports/mail/opendkim/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
