From ust@cert.siemens.de  Sun Feb 13 03:45:17 2000
Return-Path: <ust@cert.siemens.de>
Received: from david.siemens.de (david.siemens.de [192.35.17.14])
	by builder.freebsd.org (Postfix) with ESMTP id 667CE4052
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 13 Feb 2000 03:45:16 -0800 (PST)
Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14])
	by david.siemens.de (8.9.3/8.9.3) with ESMTP id MAA01633
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 13 Feb 2000 12:44:45 +0100 (MET)
Received: from mars.cert.siemens.de (ust.mchp.siemens.de [139.23.201.17])
	by mail1.siemens.de (8.9.3/8.9.3) with ESMTP id MAA19956
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 13 Feb 2000 12:44:45 +0100 (MET)
Received: from alaska.cert.siemens.de (reims.mchp.siemens.de [139.23.202.134])
	by mars.cert.siemens.de (8.9.3/8.9.3/Siemens CERT [ $Revision: 1.4 ]) with ESMTP id MAA10101
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 13 Feb 2000 12:44:45 +0100 (CET)
	(envelope-from ust@alaska.cert.siemens.de)
Received: (from ust@localhost)
	by alaska.cert.siemens.de (8.9.3/8.9.3/alaska [ $Revision: 1.3 ]) id LAA25861;
	Sun, 13 Feb 2000 11:44:44 GMT
	(envelope-from ust)
Message-Id: <200002131144.LAA25861@alaska.cert.siemens.de>
Date: Sun, 13 Feb 2000 11:44:44 GMT
From: Udo Schweigert <ust@cert.siemens.de>
Reply-To: ust@cert.siemens.de
To: FreeBSD-gnats-submit@freebsd.org
Subject: Fix a problem in port sysutils/mkisofs
X-Send-Pr-Version: 3.2

>Number:         16697
>Category:       ports
>Synopsis:       Fix a problem in port sysutils/mkisofs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dirk
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 13 03:50:01 PST 2000
>Closed-Date:    Sun Feb 13 12:49:50 PST 2000
>Last-Modified:  Sun Feb 13 12:50:16 PST 2000
>Originator:     Udo Schweigert
>Release:        FreeBSD 3.4-STABLE i386
>Organization:
Siemens AG, ZT IK 3
>Environment:

FreeBSD 3.4-RELEASE

>Description:

When using mkisofs with -T (generate TRANS.TBL) I got a core dump.
This occured because for one directory I had tablesize%SECTORSIZE==0.

>How-To-Repeat:


>Fix:
	
Increase the malloc by 1, as stated in this diff:

diff -ruN mkisofs.orig/patches/patch-bb mkisofs/patches/patch-bb
--- mkisofs.orig/patches/patch-bb	Thu Jan  1 01:00:00 1970
+++ mkisofs/patches/patch-bb	Sun Feb 13 12:29:07 2000
@@ -0,0 +1,13 @@
+--- mkisofs/tree.c.orig	Mon Jan 10 23:17:25 2000
++++ mkisofs/tree.c	Sun Feb 13 12:27:28 2000
+@@ -446,8 +446,8 @@
+       	table->de_flags    |= INHIBIT_JOLIET_ENTRY;
+ /*      table->name = strdup("<translation table>");*/
+       table->name = strdup(trans_tbl);
+-      table->table = (char *) e_malloc(ROUND_UP(tablesize));
+-      memset(table->table, 0, ROUND_UP(tablesize));
++      table->table = (char *) e_malloc(ROUND_UP(tablesize+1));
++      memset(table->table, 0, ROUND_UP(tablesize+1));
+       iso9660_file_length  (trans_tbl, table, 0);
+       
+       if(use_RockRidge)

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->dirk  
Responsible-Changed-By: cpiazza 
Responsible-Changed-When: Sun Feb 13 11:41:08 PST 2000 
Responsible-Changed-Why:  
Over to maintainer 
State-Changed-From-To: open->closed 
State-Changed-By: dirk 
State-Changed-When: Sun Feb 13 12:49:50 PST 2000 
State-Changed-Why:  
Patch committed. Thanks! 
>Unformatted:
