From amdmi3@amdmi3.ru  Wed Apr 11 00:15:32 2012
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9BE71106566B;
	Wed, 11 Apr 2012 00:15:32 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (unknown [IPv6:2a03:6f00:1::5c35:743c])
	by mx1.freebsd.org (Postfix) with ESMTP id 2A7218FC08;
	Wed, 11 Apr 2012 00:15:31 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
	(Exim 4.76)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1SHlDe-0001iU-GG; Wed, 11 Apr 2012 04:15:30 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id 401A2B852;
	Wed, 11 Apr 2012 04:15:30 +0400 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id 2309E474; Wed, 11 Apr 2012 04:15:30 +0400 (MSK)
Message-Id: <20120411001530.2309E474@hades.panopticon>
Date: Wed, 11 Apr 2012 04:15:30 +0400 (MSK)
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: lua@FreeBSD.org, mandree@FreeBSD.org
Subject: [PATCH] lang/lua: unbreak support for several important functions
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         166832
>Category:       ports
>Synopsis:       [PATCH] lang/lua: unbreak support for several important functions
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    lua
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 11 00:20:14 UTC 2012
>Closed-Date:    Wed Apr 11 05:12:48 UTC 2012
>Last-Modified:  Thu Apr 12 06:20:06 UTC 2012
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD hades.panopticon 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 10 01:33:18 MSK 2012
>Description:
This change:
http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/lua/Makefile.diff?r1=1.47;r2=1.48

is
1) Not needed, as CFLAGS are passed via MAKE_ENV anyway
2) Makes lua's make not able to append CFLAGS with additional flags (namely -DLUA_USE_LINUX) which enables support for crucial features like readline, popen and posix support.

The patch attached reverts the change and thus fixes support for these functions in lua.

Port maintainer (lua@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_5 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- lua-5.1.5_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/lang/lua/Makefile,v
retrieving revision 1.50
diff -u -u -r1.50 Makefile
--- Makefile	6 Apr 2012 17:50:44 -0000	1.50
+++ Makefile	11 Apr 2012 00:08:34 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	lua
 PORTVERSION=	5.1.5
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	lang
 MASTER_SITES=	http://www.lua.org/ftp/ \
 		ftp://ftp.ntua.gr/pub/lang/lua/ \
@@ -24,7 +24,6 @@
 USE_LDCONFIG=	yes
 MAKE_JOBS_SAFE=	yes
 MAKE_ENV=	LUA_SONAME="liblua-${LUA_VER}.so.${LUA_VER_SH}"
-MAKE_ARGS=	CFLAGS="${CFLAGS}"
 
 MAN1=		lua-${LUA_VER}.1 luac-${LUA_VER}.1
 DOCSDIR=	${PREFIX}/share/doc/${LUA_SUBDIR}
--- lua-5.1.5_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lua 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Apr 11 00:20:24 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166832 
State-Changed-From-To: open->closed 
State-Changed-By: ohauer 
State-Changed-When: Wed Apr 11 05:09:07 UTC 2012 
State-Changed-Why:  
Already fixed with PR ports/166753 


http://www.freebsd.org/cgi/query-pr.cgi?pr=166832 

From: Matthias Andree <mandree@FreeBSD.org>
To: amdmi3@amdmi3.ru, bug-followup@FreeBSD.org
Cc: lua@FreeBSD.ORG
Subject: Re: ports/166832: [PATCH] lang/lua: unbreak support for several important
 functions
Date: Thu, 12 Apr 2012 08:11:13 +0200

 Note that we lose changes we make to CFLAGS if users set "CFLAGS=..."
 (rather than ?= or +=) in /etc/make.conf -- they are permitted to do
 that, it has been documented as examples and in documents for years.
 
 Details: http://wiki.freebsd.org/MatthiasAndree/LuaLessonsLearnt
>Unformatted:
