From nobody@FreeBSD.org  Tue Apr 10 13:29:34 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7C3881065673
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Apr 2012 13:29:34 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 673B18FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Apr 2012 13:29:34 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q3ADTYRj055730
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Apr 2012 13:29:34 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q3ADTXOk055729;
	Tue, 10 Apr 2012 13:29:33 GMT
	(envelope-from nobody)
Message-Id: <201204101329.q3ADTXOk055729@red.freebsd.org>
Date: Tue, 10 Apr 2012 13:29:33 GMT
From: Shin-ichi Okano <s-okano@n08.itscom.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] audio/sound-juicer suddenly exits
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         166817
>Category:       ports
>Synopsis:       [PATCH] audio/sound-juicer suddenly exits
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 10 13:30:01 UTC 2012
>Closed-Date:    Sun May 20 16:24:54 UTC 2012
>Last-Modified:  Sun May 20 16:30:05 UTC 2012
>Originator:     Shin-ichi Okano
>Release:        9-STABLE
>Organization:
>Environment:
FreeBSD wombat.s-okano.n08.itscom.net 9.0-STABLE FreeBSD 9.0-STABLE #0 r233835: Tue Apr  3 20:57:43 JST 2012     s-okano@wombat.s-okano.n08.itscom.net:/usr/obj/usr/src/sys/WOMBAT  amd64
>Description:
sound-juicer suddenly exits when inserting the disc whose information is not registered in musicbrainz.

This problem is caused by reference to unset variables.

>How-To-Repeat:
Launch sound-juicer and insert the disc whose information is not 
registered in musicbrainz yet.
>Fix:
This is already fixed in upstream.
Applied the attached patch should fix this problem.
(See http://mail.gnome.org/archives/commits-list/2011-May/msg06778.html)


Patch attached with submission follows:

--- src/sj-main.c.orig	2012-02-14 16:44:03.000000000 +0900
+++ src/sj-main.c	2012-02-14 16:46:41.000000000 +0900
@@ -410,9 +410,11 @@
   g_return_val_if_fail (title != NULL, NULL);
   g_return_val_if_fail (artist != NULL, NULL);
 
-  infobar = gtk_info_bar_new_with_buttons (_("S_ubmit Album"), GTK_RESPONSE_OK,
-                                           GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
-                                           NULL);
+  infobar = gtk_info_bar_new ();
+  button = gtk_info_bar_add_button (GTK_INFO_BAR (infobar),
+                                    _("S_ubmit Album"), GTK_RESPONSE_OK);
+  gtk_info_bar_add_button (GTK_INFO_BAR (infobar),
+                           GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL);
 
   /* Translators: title, artist */
   primary_text = g_strdup_printf (_("Could not find %s by %s on MusicBrainz."), title, artist);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Apr 10 13:30:47 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166817 
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Sun May 20 16:24:41 UTC 2012 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166817 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166817: commit references a PR
Date: Sun, 20 May 2012 16:24:40 +0000 (UTC)

 mezz        2012-05-20 16:24:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/sound-juicer   Makefile 
   Added files:
     audio/sound-juicer/files patch-src_sj-main.c 
   Log:
   Fix the crash when disable musicbrainz, bump the PORTREVISION.
   
   PR:             ports/166817
   Submitted by:   Shin-ichi Okano <s-okano@n08.itscom.net>
   Obtained from:  Its git
   
   Revision  Changes    Path
   1.62      +1 -1      ports/audio/sound-juicer/Makefile
   1.1       +17 -0     ports/audio/sound-juicer/files/patch-src_sj-main.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
