From mel@datakitty.lan.rachie.is-a-geek.net  Fri Apr  6 23:52:52 2012
Return-Path: <mel@datakitty.lan.rachie.is-a-geek.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EE302106566C;
	Fri,  6 Apr 2012 23:52:52 +0000 (UTC)
	(envelope-from mel@datakitty.lan.rachie.is-a-geek.net)
Received: from datakitty.lan.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 8661D8FC12;
	Fri,  6 Apr 2012 23:52:52 +0000 (UTC)
Received: from datakitty.lan.rachie.is-a-geek.net (localhost [127.0.0.1])
	by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5) with ESMTP id q36Nqjq1067866;
	Fri, 6 Apr 2012 15:52:45 -0800 (AKDT)
	(envelope-from mel@datakitty.lan.rachie.is-a-geek.net)
Received: (from mel@localhost)
	by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5/Submit) id q36Nqh3J067865;
	Fri, 6 Apr 2012 15:52:43 -0800 (AKDT)
	(envelope-from mel)
Message-Id: <201204062352.q36Nqh3J067865@datakitty.lan.rachie.is-a-geek.net>
Date: Fri, 6 Apr 2012 15:52:43 -0800 (AKDT)
From: Mel Flynn <rflynn@acsalaska.net>
Reply-To: Mel Flynn <rflynn@acsalaska.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Steve Wills <swills@FreeBSD.net>, Maintainer <perl@freebsd.org>
Subject: [patch] www/p5-WWW-Mechanize: fix test hangs.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         166712
>Category:       ports
>Synopsis:       [patch] www/p5-WWW-Mechanize: fix test hangs.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    swills
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 07 00:00:11 UTC 2012
>Closed-Date:    Thu Apr 12 03:17:43 UTC 2012
>Last-Modified:  Thu Apr 12 03:20:15 UTC 2012
>Originator:     Mel Flynn
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD datakitty.lan.rachie.is-a-geek.net 8.2-STABLE FreeBSD 8.2-STABLE #6 r230977: Sun Feb 5 06:20:11 AKST 2012 mel@datakitty.lan.rachie.is-a-geek.net:/data/obj/data/RELENG_8/src/sys/GENERIC amd64


>Description:
Tests in t/local all use LocalServer.pm, a module emulating a HTTP server.
This module closes a file handle from the child, after sending a
'quit_server' URL. This is supposed to stop the server, but does not on
FreeBSD, for reasons I'm unable to determine.
The filehandle cannot be closed SIGINFO shows that perl is in 'accept'.

>How-To-Repeat:

cd /usr/ports/www/p5-WWW-Mechanize
make build
cd `make -V WRKSRC`
make test

>Fix:

The fix below is a work around. It kills the server using a SIGTERM to the
server pid. It doesn't impact the test results.
Issue submitted upstream:
http://code.google.com/p/www-mechanize/issues/detail?id=234

--- www__p5-WWW-Mechanize.patch begins here ---
diff -urN --exclude CVS --exclude '*~' www/p5-WWW-Mechanize/files/patch-t__local__LocalServer.pm /usr/ports/www/p5-WWW-Mechanize/files/patch-t__local__LocalServer.pm
--- www/p5-WWW-Mechanize/files/patch-t__local__LocalServer.pm.orig	1969-12-31 14:00:00.000000000 -1000
+++ www/p5-WWW-Mechanize/files/patch-t__local__LocalServer.pm	2012-04-06 14:37:36.000000000 -0800
@@ -0,0 +1,11 @@
+--- t/local/LocalServer.pm.orig	2011-08-05 12:48:08.000000000 -0800
++++ t/local/LocalServer.pm	2012-04-06 14:37:36.000000000 -0800
+@@ -152,7 +152,7 @@
+ sub stop {
+     my ($self) = @_;
+     get( $self->quit_server );
+-    undef $self->{_server_url};
++    $self->kill();
+     if ( $self->{_fh} ) {
+         close $self->{_fh};
+         delete $self->{_fh};
--- www__p5-WWW-Mechanize.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->perl 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Apr 7 00:00:37 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166712 
Responsible-Changed-From-To: perl->swills 
Responsible-Changed-By: swills 
Responsible-Changed-When: Sat Apr 7 18:36:42 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166712 
State-Changed-From-To: open->closed 
State-Changed-By: swills 
State-Changed-When: Thu Apr 12 03:17:40 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166712 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166712: commit references a PR
Date: Thu, 12 Apr 2012 03:17:46 +0000 (UTC)

 swills      2012-04-12 03:17:32 UTC
 
   FreeBSD ports repository
 
   Added files:
     www/p5-WWW-Mechanize/files patch-t__local__LocalServer.pm 
   Log:
   - Fix tests
   
   PR:             ports/166712
   Submitted by:   Mel Flynn <rflynn@acsalaska.net>
   
   Revision  Changes    Path
   1.1       +11 -0     ports/www/p5-WWW-Mechanize/files/patch-t__local__LocalServer.pm (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
