From mel@datakitty.lan.rachie.is-a-geek.net  Fri Apr  6 16:49:12 2012
Return-Path: <mel@datakitty.lan.rachie.is-a-geek.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 205811065672;
	Fri,  6 Apr 2012 16:49:12 +0000 (UTC)
	(envelope-from mel@datakitty.lan.rachie.is-a-geek.net)
Received: from datakitty.lan.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B2EB8FC0A;
	Fri,  6 Apr 2012 16:49:08 +0000 (UTC)
Received: from datakitty.lan.rachie.is-a-geek.net (localhost [127.0.0.1])
	by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5) with ESMTP id q36Gn6j6085093;
	Fri, 6 Apr 2012 08:49:06 -0800 (AKDT)
	(envelope-from mel@datakitty.lan.rachie.is-a-geek.net)
Received: (from mel@localhost)
	by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5/Submit) id q36Gn6Li085092;
	Fri, 6 Apr 2012 08:49:06 -0800 (AKDT)
	(envelope-from mel)
Message-Id: <201204061649.q36Gn6Li085092@datakitty.lan.rachie.is-a-geek.net>
Date: Fri, 6 Apr 2012 08:49:06 -0800 (AKDT)
From: Mel Flynn <rflynn@acsalaska.net>
Reply-To: Mel Flynn <rflynn@acsalaska.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Steve Wills <swills@freebsd.org>, Mantainer <perl@freebsd.org>
Subject: [patch] net/p5-Net-Radius: Fix test breakage
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         166695
>Category:       ports
>Synopsis:       [patch] net/p5-Net-Radius: Fix test breakage
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    swills
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 06 16:50:10 UTC 2012
>Closed-Date:    Thu Apr 12 03:05:29 UTC 2012
>Last-Modified:  Thu Apr 12 03:10:16 UTC 2012
>Originator:     Mel Flynn
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD datakitty.lan.rachie.is-a-geek.net 8.2-STABLE FreeBSD 8.2-STABLE #6 r230977: Sun Feb 5 06:20:11 AKST 2012 mel@datakitty.lan.rachie.is-a-geek.net:/data/obj/data/RELENG_8/src/sys/GENERIC amd64


>Description:
The post-extract target deletes carriage returns from all files in the
distribution. There's only one file containing a carriage return and this
isn't the usual case of "windows line endings", but is part of a binary
packet.
Removing these carriage returns breaks t/packet.t for that packet test.

>How-To-Repeat:

cd /usr/ports/net/p5-Net-Radius
make build
cd `make -V WRKSRC`
make test

>Fix:

While in here, add TEST_DEPENDS.


--- net__p5-Net-Radius.patch begins here ---
Removing \r in packets/huawei-me60-accreq-01.p will make the tests fail.
diff -urN --exclude CVS --exclude '*~' net/p5-Net-Radius/Makefile /usr/ports/net/p5-Net-Radius/Makefile
--- net/p5-Net-Radius/Makefile.orig	2009-12-14 21:26:23.000000000 -0900
+++ net/p5-Net-Radius/Makefile	2012-04-06 07:56:26.000000000 -0800
@@ -14,10 +14,10 @@
 MAINTAINER=	perl@FreeBSD.org
 COMMENT=	A perl module to manipulate RADIUS packets
 
+TEST_DEPENDS=	p5-Test-Warn>=0:${PORTSDIR}/devel/p5-Test-Warn \
+		p5-Test-Pod>=0:${PORTSDIR}/devel/p5-Test-Pod
+
 PERL_CONFIGURE=	yes
 MAN3=		Net::Radius::Dictionary.3 Net::Radius::Packet.3
 
-post-extract:
-	${FIND} ${WRKDIR} -type f | ${XARGS} ${PERL5} -pi -e "s:\r::g"
-
 .include <bsd.port.mk>
--- net__p5-Net-Radius.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->perl 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Apr 6 16:50:20 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166695 
Responsible-Changed-From-To: perl->swills 
Responsible-Changed-By: swills 
Responsible-Changed-When: Sat Apr 7 18:36:31 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166695 
State-Changed-From-To: open->closed 
State-Changed-By: swills 
State-Changed-When: Thu Apr 12 03:05:26 UTC 2012 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166695 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166695: commit references a PR
Date: Thu, 12 Apr 2012 03:05:27 +0000 (UTC)

 swills      2012-04-12 03:05:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/p5-Net-Radius    Makefile 
   Log:
   - Fix tests
   
   PR:             ports/166695
   Submitted by:   Mel Flynn <rflynn@acsalaska.net>
   
   Revision  Changes    Path
   1.18      +2 -3      ports/net/p5-Net-Radius/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
