From mel@datakitty.lan.rachie.is-a-geek.net  Tue Apr  3 21:00:15 2012
Return-Path: <mel@datakitty.lan.rachie.is-a-geek.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0C0D91065673
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  3 Apr 2012 21:00:14 +0000 (UTC)
	(envelope-from mel@datakitty.lan.rachie.is-a-geek.net)
Received: from datakitty.lan.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 41F6E8FC19
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  3 Apr 2012 21:00:12 +0000 (UTC)
Received: from datakitty.lan.rachie.is-a-geek.net (localhost [127.0.0.1])
	by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5) with ESMTP id q33L010V088760;
	Tue, 3 Apr 2012 13:00:01 -0800 (AKDT)
	(envelope-from mel@datakitty.lan.rachie.is-a-geek.net)
Received: (from mel@localhost)
	by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5/Submit) id q33L00U3088578;
	Tue, 3 Apr 2012 13:00:00 -0800 (AKDT)
	(envelope-from mel)
Message-Id: <201204032100.q33L00U3088578@datakitty.lan.rachie.is-a-geek.net>
Date: Tue, 3 Apr 2012 13:00:00 -0800 (AKDT)
From: Mel Flynn <rflynn@acsalaska.net>
Reply-To: Mel Flynn <rflynn@acsalaska.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: <milki@rescomp.berkeley.edu>
Subject: [patch] devel/p5-Dist-CheckConflicts: incorrect test depends
X-Send-Pr-Version: 3.113
X-GNATS-Notify: milki@rescomp.berkeley.edu

>Number:         166623
>Category:       ports
>Synopsis:       [patch] devel/p5-Dist-CheckConflicts: incorrect test depends
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    swills
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 03 21:10:01 UTC 2012
>Closed-Date:    Thu Apr 12 02:02:09 UTC 2012
>Last-Modified:  Thu Apr 12 02:02:09 UTC 2012
>Originator:     Mel Flynn
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD datakitty.lan.rachie.is-a-geek.net 8.2-STABLE FreeBSD 8.2-STABLE #6 r230977: Sun Feb 5 06:20:11 AKST 2012 mel@datakitty.lan.rachie.is-a-geek.net:/data/obj/data/RELENG_8/src/sys/GENERIC amd64


>Description:

TEST_DEPENDS mentioned in Makefile are incomplete. It also needs it's
run dependencies to successfully do testing.

>How-To-Repeat:
Build it and try to run it's test.

>Fix:

--- p5-Dist-CheckConflicts.patch begins here ---
--- devel/p5-Dist-CheckConflicts/Makefile.orig	2012-03-15 09:13:55.000000000 -0800
+++ devel/p5-Dist-CheckConflicts/Makefile	2012-04-03 11:17:48.000000000 -0800
@@ -21,7 +21,8 @@
 RUN_DEPENDS=	p5-List-MoreUtils>=0.12:${PORTSDIR}/lang/p5-List-MoreUtils \
 		p5-Sub-Exporter>=0:${PORTSDIR}/devel/p5-Sub-Exporter
 
-TEST_DEPENDS=	p5-Test-Fatal>=0:${PORTSDIR}/devel/p5-Test-Fatal
+TEST_DEPENDS=	p5-Test-Fatal>=0:${PORTSDIR}/devel/p5-Test-Fatal \
+		${RUN_DEPENDS}
 
 .include <bsd.port.pre.mk>
 
--- p5-Dist-CheckConflicts.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->perl 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Apr 3 21:10:16 UTC 2012 
Responsible-Changed-Why:  
perl@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166623 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Apr 3 21:10:20 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166623 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: milki@rescomp.berkeley.edu
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/166623: [patch] devel/p5-Dist-CheckConflicts: incorrect test depends
Date: Tue, 3 Apr 2012 21:10:18 UT

 Maintainer of devel/p5-Dist-CheckConflicts,
 
 Please note that PR ports/166623 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166623
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Mel Flynn <rflynn@acsalaska.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166623: [patch] devel/p5-Dist-CheckConflicts: incorrect
 test depends
Date: Tue, 03 Apr 2012 23:40:14 +0200

 Can be closed.
 After conversing with swills@ decided to add RUN_DEPENDS to TEST_DEPENDS
 automatically.
 
 Sorry for the noise.
 -- 
 Mel
Responsible-Changed-From-To: perl->swills 
Responsible-Changed-By: swills 
Responsible-Changed-When: Fri Apr 6 16:04:49 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166623 
State-Changed-From-To: feedback->closed 
State-Changed-By: swills 
State-Changed-When: Thu Apr 12 02:02:08 UTC 2012 
State-Changed-Why:  
Closed at submitter request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166623 
>Unformatted:
