From nobody@FreeBSD.org  Thu Mar 29 13:05:32 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 76E931065670
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 29 Mar 2012 13:05:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 624318FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 29 Mar 2012 13:05:32 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q2TD5Wef018888
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 29 Mar 2012 13:05:32 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q2TD5Wxr018887;
	Thu, 29 Mar 2012 13:05:32 GMT
	(envelope-from nobody)
Message-Id: <201203291305.q2TD5Wxr018887@red.freebsd.org>
Date: Thu, 29 Mar 2012 13:05:32 GMT
From: Sevan Janiyan <venture37@geeklan.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Add support for specifying flags to the rc script
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         166491
>Category:       ports
>Synopsis:       Add support for specifying flags to the rc script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ak
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 29 13:10:11 UTC 2012
>Closed-Date:    Fri Mar 30 13:20:51 UTC 2012
>Last-Modified:  Fri Mar 30 13:20:51 UTC 2012
>Originator:     Sevan Janiyan
>Release:        
>Organization:
>Environment:
>Description:
Attached patch adds support for specifying flags which the current script lacks
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- ../openntpd.orig/files/openntpd.in	2012-03-29 12:50:46.170179089 +0100
+++ ./files/openntpd.in	2012-03-29 13:40:07.887209117 +0100
@@ -12,6 +12,8 @@
 #
 # openntpd_enable (bool):	Set to NO by default.
 #				Set it to YES to enable openntpd.
+#
+# openntpd_flags 		Command line arguments
 
 . /etc/rc.subr
 
@@ -24,5 +26,6 @@
 load_rc_config $name
 
 : ${openntpd_enable="NO"}
+: ${openntpd_flags=""}
 
 run_rc_command "$1"


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ak 
Responsible-Changed-By: ak 
Responsible-Changed-When: Thu Mar 29 14:00:28 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166491 
State-Changed-From-To: open->feedback 
State-Changed-By: ak 
State-Changed-When: Thu Mar 29 14:19:31 UTC 2012 
State-Changed-Why:  
Ask for maintainer approval. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166491 

From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: Christian Weisgerber <naddy@FreeBSD.org>,
	Timothy Beyer <beyert@cs.ucr.edu>, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166491: Add support for specifying flags to the rc script
Date: Thu, 29 Mar 2012 17:17:54 +0300

 Hi, Christian
 
 Copypaste the wrong subj, sorry.
 
 Can You please review patch from this pr?
 Thanks.
 
 
 --
 Adios

From: Christian Weisgerber <naddy@FreeBSD.org>
To: Alex Kozlov <spam@rm-rf.kiev.ua>
Cc: Timothy Beyer <beyert@cs.ucr.edu>, bug-followup@FreeBSD.org
Subject: Re: ports/166491: Add support for specifying flags to the rc script
Date: Thu, 29 Mar 2012 22:01:07 +0200

 The proposed change is redundant; openntpd_flags is of course already
 available as described in rc.subr(5).
 
 -- 
 Christian "naddy" Weisgerber                          naddy@mips.inka.de

From: Venture37 <venture37@geeklan.co.uk>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166491: Add support for specifying flags to the rc script
Date: Fri, 30 Mar 2012 10:31:53 +0100

 In that case, my mistake, please close PR.
 
 Sorry about the noise
 
 
 
 Sevan
State-Changed-From-To: feedback->closed 
State-Changed-By: ak 
State-Changed-When: Fri Mar 30 13:20:49 UTC 2012 
State-Changed-Why:  
The proposed patch is redundant. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166491 
>Unformatted:
