From nobody@FreeBSD.org  Sun Mar 25 21:43:16 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9EF211065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Mar 2012 21:43:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8B2548FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Mar 2012 21:43:16 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q2PLhG1c091157
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Mar 2012 21:43:16 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q2PLhGbD091153;
	Sun, 25 Mar 2012 21:43:16 GMT
	(envelope-from nobody)
Message-Id: <201203252143.q2PLhGbD091153@red.freebsd.org>
Date: Sun, 25 Mar 2012 21:43:16 GMT
From: Stephen Hurd <shurd@sasktel.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [Maintainer Update] misc/jbidwatcher update
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         166402
>Category:       ports
>Synopsis:       [Maintainer Update] misc/jbidwatcher update
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 25 21:50:07 UTC 2012
>Closed-Date:    Sat Mar 31 18:51:38 UTC 2012
>Last-Modified:  Sat Mar 31 19:00:24 UTC 2012
>Originator:     Stephen Hurd
>Release:        9.0-RELEASE
>Organization:
>Environment:
FreeBSD stephen.hurd.local 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:15:25 UTC 2012     root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
Update to latest version
>How-To-Repeat:
N/A
>Fix:
Patch attached

Patch attached with submission follows:

diff -u misc/jbidwatcher.orig/Makefile misc/jbidwatcher/Makefile
--- misc/jbidwatcher.orig/Makefile	2012-03-25 14:39:47.000000000 -0700
+++ misc/jbidwatcher/Makefile	2012-03-25 14:39:11.000000000 -0700
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=	jbidwatcher
-DISTVERSION=	2.1.6
+DISTVERSION=	2.5
 CATEGORIES=	misc java
 MASTER_SITES=	http://www.jbidwatcher.com/download/
 DISTNAME=	JBidwatcher-${DISTVERSION}
diff -u misc/jbidwatcher.orig/distinfo misc/jbidwatcher/distinfo
--- misc/jbidwatcher.orig/distinfo	2012-03-25 14:39:31.000000000 -0700
+++ misc/jbidwatcher/distinfo	2012-03-25 14:40:23.000000000 -0700
@@ -1,2 +1,2 @@
-SHA256 (JBidwatcher-2.1.6.jar) = c1bd6342955959ec5e303626c0aad223af6e70874c2d6f91b732e8a6c88a89ce
-SIZE (JBidwatcher-2.1.6.jar) = 4291872
+SHA256 (JBidwatcher-2.5.jar) = 6e9294842dacde8b62cad14663fa81bf8f7039272e92b86eb18bf9a9fba67218
+SIZE (JBidwatcher-2.5.jar) = 14409608
Common subdirectories: misc/jbidwatcher.orig/files and misc/jbidwatcher/files


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jgh 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Sun Mar 25 22:16:38 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166402 

From: Jason Helfman <jgh@FreeBSD.org>
To: Stephen Hurd <shurd@sasktel.net>
Cc: bug-followup@freebsd.org
Subject: Re: ports/166402: [Maintainer Update] misc/jbidwatcher update
Date: Sun, 25 Mar 2012 16:25:54 -0700

 --vtzGhvizbBRQ85DL
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Disposition: inline
 
 Hi,
 
 Please consider this alternative patch:
 
 It altered it to build the jar via source, and I substitute on the jbidwatcher
 script, instead of doing seds. The patch file is there so git isn't a dependency
 of the build.  I've also put JAVA_VERSION as an environment variable into the
 script, and modified it to use the version named jar.
 
 Side-effect is cleaner install target with some of above changes.
 
 Thanks for your consideration!
 -jgh
 
 --vtzGhvizbBRQ85DL
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="jbidwatcher.txt"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/misc/jbidwatcher/Makefile,v
 retrieving revision 1.26
 diff -u -r1.26 Makefile
 --- Makefile	20 Oct 2011 18:29:47 -0000	1.26
 +++ Makefile	25 Mar 2012 23:19:15 -0000
 @@ -6,29 +6,26 @@
  #
  
  PORTNAME=	jbidwatcher
 -DISTVERSION=	2.1.6
 +PORTVERSION=	2.5
  CATEGORIES=	misc java
  MASTER_SITES=	http://www.jbidwatcher.com/download/
 -DISTNAME=	JBidwatcher-${DISTVERSION}
 -EXTRACT_SUFX=	.jar
 -EXTRACT_ONLY=
  
  MAINTAINER=	shurd@sasktel.net
  COMMENT=	A Java-based application allowing you to monitor eBay auctions
  
 +USE_BZIP2=	yes
  USE_JAVA=	yes
 +USE_ANT=	yes
 +ALL_TARGET=	jar
  JAVA_VERSION=	1.5+
 -NO_BUILD=	yes
  
 -PLIST_FILES=	%%JAVAJARDIR%%/${PORTNAME}.jar \
 +SUB_FILES=	jbidwatcher
 +SUB_LIST+=	PORTVERSION=${PORTVERSION}
 +PLIST_FILES=	%%JAVAJARDIR%%/JBidwatcher-${PORTVERSION}.jar \
  		bin/${PORTNAME}
  
  do-install:
 -	@${INSTALL_DATA} ${DISTDIR}/${DISTFILES} ${JAVAJARDIR}/${PORTNAME}.jar
 -	@${SED} -e "s:%%LOCALBASE%%:${LOCALBASE}:" \
 -		-e "s:%%JAVAJARDIR%%:${JAVAJARDIR}:" \
 -		${FILESDIR}/jbidwatcher.sh > ${PREFIX}/bin/${PORTNAME}
 -	@${CHOWN} ${BINOWN}:${BINGRP} ${PREFIX}/bin/${PORTNAME}
 -	@${CHMOD} a+rx ${PREFIX}/bin/${PORTNAME}
 +	@${INSTALL_DATA} ${WRKSRC}/JBidwatcher-${PORTVERSION}.jar ${JAVAJARDIR}
 +	@${INSTALL_SCRIPT} ${WRKDIR}/${PORTNAME} ${PREFIX}/bin
  
  .include <bsd.port.mk>
 Index: distinfo
 ===================================================================
 RCS file: /home/pcvs/ports/misc/jbidwatcher/distinfo,v
 retrieving revision 1.23
 diff -u -r1.23 distinfo
 --- distinfo	20 Oct 2011 18:29:47 -0000	1.23
 +++ distinfo	25 Mar 2012 23:19:15 -0000
 @@ -1,2 +1,2 @@
 -SHA256 (JBidwatcher-2.1.6.jar) = c1bd6342955959ec5e303626c0aad223af6e70874c2d6f91b732e8a6c88a89ce
 -SIZE (JBidwatcher-2.1.6.jar) = 4291872
 +SHA256 (jbidwatcher-2.5.tar.bz2) = 9934f6ddf6825023a2c533fb6855a8af1068c942f1d3d604f597eabe2cf9ee30
 +SIZE (jbidwatcher-2.5.tar.bz2) = 16082013
 Index: files/jbidwatcher.in
 ===================================================================
 RCS file: files/jbidwatcher.in
 diff -N files/jbidwatcher.in
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/jbidwatcher.in	25 Mar 2012 23:19:15 -0000
 @@ -0,0 +1,5 @@
 +#!/bin/sh
 +#
 +# $FreeBSD: ports/misc/jbidwatcher/files/jbidwatcher.sh,v 1.2 2005/02/01 00:59:11 hq Exp $
 +
 +JAVA_VERSION="%%JAVA_VERSION%%" "%%LOCALBASE%%/bin/java" -jar "%%JAVAJARDIR%%/JBidwatcher-%%PORTVERSION%%.jar" "$@"
 Index: files/jbidwatcher.sh
 ===================================================================
 RCS file: files/jbidwatcher.sh
 diff -N files/jbidwatcher.sh
 --- files/jbidwatcher.sh	1 Feb 2005 00:59:11 -0000	1.2
 +++ /dev/null	1 Jan 1970 00:00:00 -0000
 @@ -1,5 +0,0 @@
 -#!/bin/sh
 -#
 -# $FreeBSD: ports/misc/jbidwatcher/files/jbidwatcher.sh,v 1.2 2005/02/01 00:59:11 hq Exp $
 -
 -"%%LOCALBASE%%/bin/java" -jar "%%JAVAJARDIR%%/jbidwatcher.jar" "$@"
 Index: files/patch-build.xml
 ===================================================================
 RCS file: files/patch-build.xml
 diff -N files/patch-build.xml
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/patch-build.xml	25 Mar 2012 23:19:15 -0000
 @@ -0,0 +1,13 @@
 +--- ./build.xml.orig	2012-03-18 11:35:38.000000000 -0700
 ++++ ./build.xml	2012-03-25 16:08:00.000000000 -0700
 +@@ -125,10 +125,6 @@
 +     <echo level="info" message="Building primary .jar file." />
 +     <copy todir="help/" file="COPYING.html" />
 + 
 +-    <exec executable="git" outputproperty="GITVERSION">
 +-      <arg line="describe --tags --long"/>
 +-    </exec>
 +-
 +     <mkdir dir="META-INF"/>
 + 
 +     <manifest file="${MANIFEST}">
 
 --vtzGhvizbBRQ85DL--

From: Stephen Hurd <shurd@sasktel.net>
To: Jason Helfman <jgh@FreeBSD.org>, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166402
Date: Fri, 30 Mar 2012 19:20:54 -0700

 Jason Helfman wrote:
 > I was wondering if you have had any time to look at the patch I've 
 > submitted to your pr?
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166402
 
 I was actually unaware of it to be honest... I generally only check the 
 status of my PRs every couple weeks, and you must have hit my spam filter.
 
 Frankly, I don't see a reason to build from source.  The cleanup of the 
 do-install target looks nice... I inherited the port pretty much as-is, 
 and have only been updating the version number and checksums as I don't 
 care much except that it works.
 
 I'm also hazy on why fixing the java version at install time would be a 
 benefit.  It seems that then any upgrade of Java would require an 
 upgrade of jbidwatcher.
 
 So... off hand I like:
 The new do-install target
 
 And dislike:
 The new launcher script
 Building from source
 
 However, I think the update should be committed first, then enhancements 
 added.  If you would file a PR and CC me after this is committed, I'll 
 likely be a lot more receptive.

From: Jason Helfman <jgh@FreeBSD.org>
To: Stephen Hurd <shurd@sasktel.net>
Cc: bug-followup@freebsd.org
Subject: Re: ports/166402
Date: Fri, 30 Mar 2012 19:47:13 -0700

 --f46d043bdf3a6e469904bc80f98c
 Content-Type: text/plain; charset=ISO-8859-1
 
 On Fri, Mar 30, 2012 at 7:20 PM, Stephen Hurd <shurd@sasktel.net> wrote:
 
 > Jason Helfman wrote:
 >
 >> I was wondering if you have had any time to look at the patch I've
 >> submitted to your pr?
 >>
 >> http://www.freebsd.org/cgi/**query-pr.cgi?pr=ports/166402<http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166402>
 >>
 >
 > I was actually unaware of it to be honest... I generally only check the
 > status of my PRs every couple weeks, and you must have hit my spam filter.
 >
 > Frankly, I don't see a reason to build from source.  The cleanup of the
 > do-install target looks nice... I inherited the port pretty much as-is, and
 > have only been updating the version number and checksums as I don't care
 > much except that it works.
 >
 
 I chose to build from source, because in the portstree there is no reason
 to not build from it, in my humble opinion, if we can.
 
 
 >
 > I'm also hazy on why fixing the java version at install time would be a
 > benefit.  It seems that then any upgrade of Java would require an upgrade
 > of jbidwatcher.
 >
 
 It's not fixing anything. It is just exporting it as an environment
 variable.
 
 
 >
 > So... off hand I like:
 > The new do-install target
 >
 > Great.
 
 
 > And dislike:
 > The new launcher script
 >
 Is this based only on the environment variable export? This is becoming
 more standard in many java related ports.
 
 
 > Building from source
 >
 
 What is wrong with building from source?
 
 >
 > However, I think the update should be committed first, then enhancements
 > added.  If you would file a PR and CC me after this is committed, I'll
 > likely be a lot more receptive.
 >
 
 I can do that, thanks.
 
 --f46d043bdf3a6e469904bc80f98c
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 <br><br><div class=3D"gmail_quote">On Fri, Mar 30, 2012 at 7:20 PM, Stephen=
  Hurd <span dir=3D"ltr">&lt;<a href=3D"mailto:shurd@sasktel.net">shurd@sask=
 tel.net</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D=
 "margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 <div class=3D"im">Jason Helfman wrote:<br>
 <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
 x #ccc solid;padding-left:1ex">
 I was wondering if you have had any time to look at the patch I&#39;ve subm=
 itted to your pr?<br>
 <br>
 <a href=3D"http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/166402" targe=
 t=3D"_blank">http://www.freebsd.org/cgi/<u></u>query-pr.cgi?pr=3Dports/1664=
 02</a><br>
 </blockquote>
 <br></div>
 I was actually unaware of it to be honest... I generally only check the sta=
 tus of my PRs every couple weeks, and you must have hit my spam filter.<br>
 <br>
 Frankly, I don&#39;t see a reason to build from source. =A0The cleanup of t=
 he do-install target looks nice... I inherited the port pretty much as-is, =
 and have only been updating the version number and checksums as I don&#39;t=
  care much except that it works.<br>
 </blockquote><div><br>I chose to build from source, because in the portstre=
 e there is no reason to not build from it, in my humble opinion, if we can.=
 <br>=A0<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0pt 0pt =
 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 
 <br>
 I&#39;m also hazy on why fixing the java version at install time would be a=
  benefit. =A0It seems that then any upgrade of Java would require an upgrad=
 e of jbidwatcher.<br></blockquote><div><br>It&#39;s not fixing anything. It=
  is just exporting it as an environment variable.<br>
 =A0<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0pt 0pt 0pt =
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 <br>
 So... off hand I like:<br>
 The new do-install target<br>
 <br></blockquote><div>Great.<br>=A0<br></div><blockquote class=3D"gmail_quo=
 te" style=3D"margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204=
 );padding-left:1ex">
 And dislike:<br>
 The new launcher script<br></blockquote><div>Is this based only on the envi=
 ronment variable export? This is becoming more standard in many java relate=
 d ports.<br>=A0<br></div><blockquote class=3D"gmail_quote" style=3D"margin:=
 0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 
 Building from source<br></blockquote><div><br>What is wrong with building f=
 rom source? <br></div><blockquote class=3D"gmail_quote" style=3D"margin:0pt=
  0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 <br>
 However, I think the update should be committed first, then enhancements ad=
 ded. =A0If you would file a PR and CC me after this is committed, I&#39;ll =
 likely be a lot more receptive.<br></blockquote><div><br>I can do that, tha=
 nks. <br>
 </div></div><br>
 
 --f46d043bdf3a6e469904bc80f98c--
State-Changed-From-To: open->closed 
State-Changed-By: jgh 
State-Changed-When: Sat Mar 31 18:51:37 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166402 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166402: commit references a PR
Date: Sat, 31 Mar 2012 18:50:52 +0000 (UTC)

 jgh         2012-03-31 18:50:10 UTC
 
   FreeBSD ports repository
 
   Modified files:
     misc/jbidwatcher     Makefile distinfo 
   Log:
   - Update to 2.5
   
   PR:     ports/166402
   Submitted by:   maintainer, shurd@sasktel.net
   Feature safe:   yes
   
   Revision  Changes    Path
   1.27      +1 -1      ports/misc/jbidwatcher/Makefile
   1.24      +2 -2      ports/misc/jbidwatcher/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
